Repository navigation
fix: font-variant: tabular-nums issue - #105889
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
| <View> | ||
| {/* Invisible copy of the widest label this counter can show. It reserves a fixed width so the label doesn't | ||
| shift sideways as the user pages, and the real label is drawn over it, right-aligned against the arrows. */} | ||
| <Text |
There was a problem hiding this comment.
This is to prevent the UI shifting issue
Screen.Recording.2026-11-04.at.18.31.23.mov
| <View> | ||
| {/* Invisible copy of the widest label this counter can show. It reserves a fixed width so the label doesn't | ||
| shift sideways as the user pages, and the real label is drawn over it, right-aligned against the arrows. */} | ||
| <Text |
There was a problem hiding this comment.
This is to prevent the UI shifting issue
Screen.Recording.2026-11-04.at.18.31.23.mov
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bc9a5cb04
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <View> | ||
| {/* Invisible copy of the widest label this counter can show. It reserves a fixed width so the label doesn't | ||
| shift sideways as the user pages, and the real label is drawn over it, right-aligned against the arrows. */} | ||
| <Text |
There was a problem hiding this comment.
Extract the repeated counter layout
This new invisible-measurement/absolutely-positioned label block is structurally duplicated in MoneyRequestReportTransactionsNavigation.tsx:477-491, with only the current and total expressions changed. Both counters have the same layout and accessibility requirements, so future fixes to the width reservation or hidden-text semantics can easily reach only one path; extract a shared counter component that accepts current and total instead of maintaining both copies.
AGENTS.md reference: AGENTS.md:L7-L10
Useful? React with 👍 / 👎.
|
@ShridharGoel can you review this one please |
|
@thelullabyy There are few bot comments that need to be addressed |
ab5b519
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
|
@MelvinBot review |
|
No product review required. @joekaufmanexpensify already approved this for Product at the latest commit. |
| ); | ||
| } | ||
|
|
||
| export default MoneyRequestReportNavigationCounter; |
There was a problem hiding this comment.
Nit: Please add MoneyRequestReportNavigationCounter.displayName = 'MoneyRequestReportNavigationCounter';.
There was a problem hiding this comment.
I think per STYLE.md, we shouldn't add displayName if it matches the component name
|
Visuals look right to me 👍 |
|
@ShridharGoel I addressed & replied your comments, could you please take another look? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb Safari |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.36-0 🚀
|
|
No help site update needed — this PR only fixes the appearance of digits in report and expense navigation counters, without changing workflows or making existing article instructions incorrect. |
|
No FullStory changes needed — this PR only fixes navigation-counter typography and prevents layout shifts, without adding new interactions, screens, user properties, or sensitive content. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
Fixed Issues
$ #90366
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-11-04.at.18.34.12.mov