You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Workspace chat - Unable to split a reverted split transaction after deleting the unreported split transaction #91105
Version Number: 9.3.77-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@dmkt9 Slack conversation (hyperlinked to channel name): #expensify_open_source
When a split transaction child is unreported (its reportID becomes '0') and then deleted from self-DM, the delete goes through deleteTrackExpense, which has zero split awareness. It simply removes the transaction without ever calling the RevertSplitTransaction API.
This leaves the system in an inconsistent state:
The original parent transaction remains stranded with reportID: '-2' (SPLIT_REPORT_ID) — effectively hidden.
The remaining child still has comment.originalTransactionID and comment.source = 'split' set.
When checking if the remaining child can be split, isExpenseSplit returns true because those comment fields persist.
The split-aware delete path exists in useDeleteTransactions, which correctly groups split children and calls updateSplitTransactions (triggering revert when only 1 child remains). But the self-DM delete of an unreported child bypasses this entirely.
What changes do you think we should make in order to solve the problem?
The self-DM delete path (deleteTrackExpense) should detect when the transaction being deleted is a split child (by checking comment.originalTransactionID and comment.source === 'split') and, when it is, route the deletion through the split-aware logic in updateSplitTransactions / useDeleteTransactions so that RevertSplitTransaction is properly invoked. This would restore the original parent transaction (moving it from reportID: '-2' back to its original report) and clear split metadata on the remaining child.
What alternative solutions did you explore?
An alternative would be to modify isExpenseSplit to return false when the parent transaction no longer has any comment.splits (i.e., after the child is deleted). However, this would only mask the UI symptom without fixing the underlying data inconsistency — the parent transaction would remain stranded at reportID: '-2' forever. The proper fix is to ensure the revert path is always triggered.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Workspace chat - Unable to split a reverted split transaction after deleting the unreported split transaction[/-][+][$250] Workspace chat - Unable to split a reverted split transaction after deleting the unreported split transaction[/+]on May 19, 2026
changed the title [-][$250] Workspace chat - Unable to split a reverted split transaction after deleting the unreported split transaction[/-][+][Due for payment 2026-06-01] [$250] Workspace chat - Unable to split a reverted split transaction after deleting the unreported split transaction[/+]on May 25, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.81-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@dmkt9 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
⚠️@KJ21-ENG Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
changed the title [-][Due for payment 2026-06-01] [$250] Workspace chat - Unable to split a reverted split transaction after deleting the unreported split transaction[/-][+][$250] Workspace chat - Unable to split a reverted split transaction after deleting the unreported split transaction[/+]on May 28, 2026
Activity
MelvinBot commentedon May 19, 2026
Proposal
What is the root cause of that problem?
When a split transaction child is unreported (its
reportIDbecomes'0') and then deleted from self-DM, the delete goes throughdeleteTrackExpense, which has zero split awareness. It simply removes the transaction without ever calling theRevertSplitTransactionAPI.This leaves the system in an inconsistent state:
reportID: '-2'(SPLIT_REPORT_ID) — effectively hidden.comment.originalTransactionIDandcomment.source = 'split'set.isExpenseSplitreturnstruebecause those comment fields persist.useSelectedTransactionsActionsanduseSearchBulkActionsexplicitly block splitting whenisExpenseSplitistrue.The split-aware delete path exists in
useDeleteTransactions, which correctly groups split children and callsupdateSplitTransactions(triggering revert when only 1 child remains). But the self-DM delete of an unreported child bypasses this entirely.What changes do you think we should make in order to solve the problem?
The self-DM delete path (
deleteTrackExpense) should detect when the transaction being deleted is a split child (by checkingcomment.originalTransactionIDandcomment.source === 'split') and, when it is, route the deletion through the split-aware logic inupdateSplitTransactions/useDeleteTransactionsso thatRevertSplitTransactionis properly invoked. This would restore the original parent transaction (moving it fromreportID: '-2'back to its original report) and clear split metadata on the remaining child.What alternative solutions did you explore?
An alternative would be to modify
isExpenseSplitto returnfalsewhen the parent transaction no longer has anycomment.splits(i.e., after the child is deleted). However, this would only mask the UI symptom without fixing the underlying data inconsistency — the parent transaction would remain stranded atreportID: '-2'forever. The proper fix is to ensure the revert path is always triggered.Related issues
Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.melvin-bot commentedon May 19, 2026
Current assignee @dmkt9 is eligible for the External assigner, not assigning anyone new.
[-]Workspace chat - Unable to split a reverted split transaction after deleting the unreported split transaction[/-][+][$250] Workspace chat - Unable to split a reverted split transaction after deleting the unreported split transaction[/+]19 remaining items
[-][$250] Workspace chat - Unable to split a reverted split transaction after deleting the unreported split transaction[/-][+][Due for payment 2026-06-01] [$250] Workspace chat - Unable to split a reverted split transaction after deleting the unreported split transaction[/+]melvin-bot commentedon May 25, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 25, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.81-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-01. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 25, 2026
@dmkt9 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
github-actions commentedon May 25, 2026
melvin-bot commentedon May 26, 2026
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
melvin-bot commentedon May 27, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
lakchote commentedon May 28, 2026
Closing this one. Will be handled once the unreported expenses feature (frontend) is live and stable.
[-][Due for payment 2026-06-01] [$250] Workspace chat - Unable to split a reverted split transaction after deleting the unreported split transaction[/-][+][$250] Workspace chat - Unable to split a reverted split transaction after deleting the unreported split transaction[/+]