You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-07] Expense - Unreported split is not reverted after submitting it to IOU report and deleting it #91907
Version Number: 9.3.84-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#84382 Email or phone of affected tester (no customers):sdjsodnjiodsjsoinj1@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to self DM.
Create a manual expense.
Open the expense.
Click More > Split > Save.
Open any split.
Click on the header.
Click Submit it to someone.
Enter email and select user.
On confirm page, click Create expense.
Delete the expense from Step 10.
Go to self DM.
Open the remaining split
Click Amount.
Expected Result:
The remaining split will be reverted. Regular amount editor page will open.
Actual Result:
The remaining split is not reverted. Amount field opens split page after the other split in IOU report is deleted.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
When a user splits an unreported expense in their self DM, submits one split to an IOU report ("Submit it to someone"), and then deletes that submitted split, the remaining split is not reverted back to a regular expense. It stays as a split with the "Split" label on the amount field.
What is the root cause of that problem?
The root cause is in isExpenseSplit(). When a split child transaction is on a report, this function checks if the report type is 'expense':
When a split child is submitted to an individual person, it creates an IOU report (type 'iou'). Since 'iou' !== 'expense', isExpenseSplit() returns false. This causes useDeleteTransactions to classify the transaction as a non-split transaction and route it to deleteMoneyRequest (which has no split-revert awareness) instead of through updateSplitTransactions → REVERT_SPLIT_TRANSACTION.
What changes do you think we should make in order to fix the problem?
Modify the report type check in isExpenseSplit() to also accept IOU reports. Change:
This ensures that when a split child lives on an IOU report, it's still recognized as an expense split, so the delete flow correctly enters the split revert path via updateSplitTransactions → REVERT_SPLIT_TRANSACTION.
Investigation details
Data flow of the bug:
User splits expense in self DM → creates original + 2 child transactions (each with comment.originalTransactionID and comment.source='split')
User submits one split child to a person → child's reportID changes to the IOU report (type 'iou')
User deletes the submitted split → useDeleteTransactions calls isExpenseSplit() → returns false because report type is 'iou'
Transaction classified as non-split → deleteMoneyRequest() called directly → no revert
Remaining split child in self DM is orphaned
The revert logic itself is correct — in SplitTransactionUpdate.ts:202-204, isReverseSplitOperation correctly detects when only 1 split child remains and triggers REVERT_SPLIT_TRANSACTION. The issue is purely that the transaction never reaches this code path due to the isExpenseSplit gate.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Expense - Unreported split is not reverted after submitting it to IOU report and deleting it[/-][+][Due for payment 2026-08-07] Expense - Unreported split is not reverted after submitting it to IOU report and deleting it[/+]on Jul 31, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.46-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon May 27, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/562059fdb179d0d78b62e20428fbb554b83e074143a4547b4749eacb36802b2b
melvin-bot commentedon May 27, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #84382
melvin-bot commentedon May 27, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 27, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user splits an unreported expense in their self DM, submits one split to an IOU report ("Submit it to someone"), and then deletes that submitted split, the remaining split is not reverted back to a regular expense. It stays as a split with the "Split" label on the amount field.
What is the root cause of that problem?
The root cause is in
isExpenseSplit(). When a split child transaction is on a report, this function checks if the report type is'expense':When a split child is submitted to an individual person, it creates an IOU report (type
'iou'). Since'iou' !== 'expense',isExpenseSplit()returnsfalse. This causesuseDeleteTransactionsto classify the transaction as a non-split transaction and route it todeleteMoneyRequest(which has no split-revert awareness) instead of throughupdateSplitTransactions→REVERT_SPLIT_TRANSACTION.What changes do you think we should make in order to fix the problem?
Modify the report type check in
isExpenseSplit()to also accept IOU reports. Change:to:
This ensures that when a split child lives on an IOU report, it's still recognized as an expense split, so the delete flow correctly enters the split revert path via
updateSplitTransactions→REVERT_SPLIT_TRANSACTION.Investigation details
Data flow of the bug:
comment.originalTransactionIDandcomment.source='split')reportIDchanges to the IOU report (type'iou')useDeleteTransactionscallsisExpenseSplit()→ returnsfalsebecause report type is'iou'deleteMoneyRequest()called directly → no revertThe revert logic itself is correct — in
SplitTransactionUpdate.ts:202-204,isReverseSplitOperationcorrectly detects when only 1 split child remains and triggersREVERT_SPLIT_TRANSACTION. The issue is purely that the transaction never reaches this code path due to theisExpenseSplitgate.Related issues:
Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.lakchote commentedon May 28, 2026
Since we've added the guard to hide the selfDM splits feature in production in the PR #91932, I'm going to remove the deploy blocker label @mountiny
29 remaining items
mitarachim commentedon Jul 29, 2026
Deploy Blocker #97403 was identified to be related to the PR #92055 that attempted to fix this issue.
melvin-bot commentedon Jul 30, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
jponikarchuk commentedon Jul 30, 2026
Deploy Blocker #97424 was identified to be related to the PR #92055 that attempted to fix this issue.
melvin-bot commentedon Jul 30, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
lakchote commentedon Jul 30, 2026
Original issue is not reproducible by QA anymore, see https://expensify.slack.com/archives/C09V78U42D8/p1785396519081229?thread_ts=1785394378.160169&cid=C09V78U42D8
melvin-bot commentedon Jul 30, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mitarachim commentedon Jul 30, 2026
Deploy Blocker #97436 was identified to be related to the PR #92055 that attempted to fix this issue.
[-]Expense - Unreported split is not reverted after submitting it to IOU report and deleting it[/-][+][Due for payment 2026-08-07] Expense - Unreported split is not reverted after submitting it to IOU report and deleting it[/+]melvin-bot commentedon Jul 31, 2026
@ZhenjaHorbach
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.46-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Aug 19, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.