Skip to content

Expense - "Submit to a friend" option is not displayed for unreported split expense. #98934

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.56-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #97475
Email or phone of affected tester (no customers): ibellicotest+2766@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Sign up with new account and select "Track expenses for my business" during onboarding.

  1. Open the Expensify app.
  2. Navigate to Self DM.
  3. Create a manual expense.
  4. Open the just created expense.
  5. Tap on header to navigate to details page.
  6. Note that "Submit to my employer" and "Submit to a friend" options are available.
  7. Return to report.
  8. Tap on "More" > "Split" > Save splits.
  9. Open one of the splits.
  10. Click on header to navigate to details page.
  11. Note that "Submit to my employer" option is visible but "Submit to a friend" option is not displayed.

Expected Result:

"Submit to my employer" and "Submit to a friend" options should be visible on details page of unreported split.

Actual Result:

"Submit to a friend" is not visible on details page of an unreported split.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7236779_1787098047497.Friend.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7236779

Activity

  1. applause-bot commented on Aug 19, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/7a847ba818d67d27940a5c0d4da987b4d3555003fc8bc86f25e1e9396de33f47

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 19, 2026
  3. melvin-bot commented on Aug 19, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #97475

  4. melvin-bot commented on Aug 19, 2026

    @melvin-bot

    @mountiny @dmkt9 you have been assigned to this deploy blocker because you reviewed the offending PR: #97475

  5. melvin-bot commented on Aug 19, 2026

    @melvin-bot

    @ZhenjaHorbach you have been assigned to this deploy blocker because you authored the offending PR: #97475

  6. melvin-bot commented on Aug 19, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Aug 19, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Aug 19, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    The flagged PR #97475 is NOT the cause — reverting it will not fix this. Melvin auto-attributed it only because it's a split-related PR on the current checklist, but its diff never touches the submit-options code (zero matches for submitToFriend / DynamicReportDetailsPage in its 14 changed files).

    Root cause: The "Submit to a friend" option is intentionally filtered out for self-DM split expenses by an explicit guard in src/pages/DynamicReportDetailsPage.tsx:577, which pushes the friend item only if (!isSelfDMExpenseSplit). The comment there reads "Self-DM split expenses can only be submitted to a workspace, so the 'a friend' destination is omitted here." "Submit to my employer" has no such guard, so it always shows — which is exactly the reported asymmetry.

    A split child transaction has comment.source === 'split', so isExpenseSplit() returns true → isSelfDMExpenseSplit === true → friend item skipped. A regular manual expense is not a split, so both options render.

    Who actually introduced it:

    • The filter was added by #92055 ("Fix bugs for selfDM splits feature", ZhenjaHorbach) — but it was hidden behind the canUseSubmit2026 beta.
    • It became visible when #98656 ("Remove the submit2026 beta", iwiznia) removed that beta gate in 9.4.56, which is why it appears "new" and "doesn't exist in prod."

    Recommendation: Roll forward with a targeted fix — do not revert.

    Because the code comment says the omission is intentional, this needs a quick product call before a code change: is "Submit to a friend" supposed to be unavailable for self-DM splits, or should splits match a regular unreported expense?

    • If it's a real bug (parity expected): one-line fix — remove the if (!isSelfDMExpenseSplit) guard at DynamicReportDetailsPage.tsx:577, and re-check the outer guard at line 551 which also hides the entire submit block for splits when the user has no workspace.
    • If it's working as designed: this should be demoted rather than block the deploy — it's a single menu option on a not-yet-in-prod feature, with no impact on auth/payments/data.

    ZhenjaHorbach (feature author) is best placed to confirm intent.

    Investigation details
    • Grepped the full #97475 diff for submitToFriend, SUBMIT_TO_FRIEND, isSelfDMExpenseSplit, hasWorkspaceToSubmitTo, and DynamicReportDetailsPage → zero matches. Its changes are confined to useDeleteTransactions.ts, SplitExpenseItems.ts, SplitTransactionUpdate.ts, Transaction.ts, AddExistingExpense.tsx, SplitExpense*Page.tsx, params and tests.
    • The submit-options block: DynamicReportDetailsPage.tsx:548-609. Line 548 computes isSelfDMExpenseSplit via getOriginalTransactionWithSplitInfo; line 551 gates the whole block on !isSelfDMExpenseSplit || hasWorkspaceToSubmitTo; line 577 gates the friend item alone.
    • PR #96136 (the earlier "Submit to my employer" flow) added the two menu items with no split filter, confirming the filter was introduced later by Fix bugs for selfDM splits feature #92055.

    Correct assignees for the real causing PR (#92055): ZhenjaHorbach (author), dmkt9, lakchote (approvers).


    Next Steps: Reply with @MelvinBot implement this to open a draft PR with the one-line fix, or @MelvinBot <feedback> to refine.

  9. ZhenjaHorbach commented on Aug 19, 2026

    @ZhenjaHorbach
    Contributor

    It's not a bug
    Submit a friend is about moving expenses to 1:1 DM chats, which we can't do for split expenses
    So let's close this

  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions