Skip to content

[Payment due @abzokhattab] Remove the submit2026 beta - #98656

Merged
MonilBhavsar merged 3 commits into
mainfrom
ionatan_removesubmit2026beta
Aug 17, 2026
Merged

MonilBhavsar merged 3 commits into
mainfrom
ionatan_removesubmit2026beta

Conversation

@iwiznia

@iwiznia iwiznia commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

This removes the beta checks since we've opened the feature to everyone

Fixed Issues

$https://github.com/Expensify/Expensify/issues/671705
PROPOSAL:

Tests

  • Create a new account
  • Select submit to my employer
  • In the workspace chat, submit an expense via PDF
  • Submit another expense this time to a specific user
  • Check it all works properly

Offline tests

No

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@iwiznia iwiznia self-assigned this Aug 14, 2026
@codecov

codecov Bot commented Aug 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 94.85% <ø> (ø)
...nents/Navigation/QuickCreationActionsBar/index.tsx 86.04% <100.00%> (-0.17%) ⬇️
.../SearchPageHeader/SearchActionsBarCreateButton.tsx 96.10% <100.00%> (-0.05%) ⬇️
...rch/SearchRouter/useCreateNavigationSuggestions.ts 100.00% <100.00%> (ø)
src/hooks/useOnboardingStepCounter.ts 100.00% <100.00%> (ø)
...s/Navigation/guards/SubmitPlanWelcomeModalGuard.ts 97.14% <100.00%> (-0.18%) ⬇️
src/libs/OnboardingUtils.ts 100.00% <ø> (ø)
src/libs/PolicyUtils.ts 77.56% <100.00%> (-0.10%) ⬇️
src/libs/ReportPrimaryActionUtils.ts 92.91% <ø> (ø)
src/libs/actions/Policy/Member.ts 76.92% <ø> (ø)
... and 15 more
... and 13 files with indirect coverage changes

@iwiznia
iwiznia marked this pull request as ready for review August 14, 2026 16:02
@iwiznia
iwiznia requested review from a team as code owners August 14, 2026 16:02
@melvin-bot
melvin-bot Bot requested review from abzokhattab and trjExpensify and removed request for a team August 14, 2026 16:02
@melvin-bot

melvin-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 14, 2026 16:02

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yeah! 🙌

@abzokhattab

Copy link
Copy Markdown
Contributor

@codex @MelvinBot review the pr

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 7b6ec7aab0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Reviewed as a clean, complete removal of the SUBMIT_2026 beta gate. Every gated path is now unconditionally on, which matches the stated intent ("opened the feature to everyone"). No blocking issues found. Note that MelvinBot can't formally approve — a human reviewer still needs to do that.

What I verified

  • No dangling references to any removed symbol — CONST.BETAS.SUBMIT_2026, canAccessSubmitWorkspaceFeatures, getVisibleJoinablePoliciesCount, REPORT_DETAILS_MENU_ITEM.TRACK.SUBMIT, and the actionableMentionTrackExpense.submit translation key are all gone with zero leftover usages. (The remaining submit2026 hits are the plan name in comments, the SUBMIT_DESTINATION constant, and the plan's own language section — unrelated.)
  • No orphaned isBetaEnabled / usePermissions — files that dropped the import no longer use it; files that kept it still use it for other betas (ASAP_SUBMIT, DEFAULT_ROOMS, RULES_REVAMP, etc.).
  • Signature changes are consistent at every call site — getGroupPoliciesWhereReportCanBeCreated, getActivePoliciesWithExpenseChat, and createHasWorkspaceToSubmitToSelector all dropped the beta arg cleanly across src + tests.
  • Logic equivalence holds for the beta-was-true case:
    • getVisibleJoinablePoliciesCount(x, true) → Object.keys(x ?? {}).length ✅
    • canAccessSubmitWorkspaceFeatures(policy, beta) → isSubmitPolicy(policy) && beta; the WorkflowsPaymentsTab refactor of canAccessWalletConnectionStatusFeatures = isSubmitPolicyWorkspace && isWalletConnectionStatusBetaEnabled is correct ✅
    • The DynamicReportDetailsPage / ChatActionableButtons submit menus now always render the friend/employer split (the old single-button else branch is dropped) ✅
  • Tests updated appropriately and CI is green — typecheck, ESLint, knip, unused-styles, React Compiler, and all 8 unit/UI test shards pass. (The one failing checklist check is the PR-author checklist gate, not a code failure.)

Behavioral surfaces worth a QA spot-check

These are intended consequences of the launch, but they're the widest-reaching behavior changes, so worth eyeballing:

One small thing to confirm on your end (couldn't verify from the diff alone): since the backend previously gated this behind the beta too, make sure the server-side rollout is already fully open for all accounts — otherwise the client will offer the flow to users the API might still reject.

I reviewed this statically (no live functional run). Overall this looks safe to ship.

@abzokhattab

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot
melvin-bot Bot requested a review from MonilBhavsar August 14, 2026 23:29
@melvin-bot

melvin-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot changed the title Remove the submit2026 beta [Payment due @abzokhattab] Remove the submit2026 beta Aug 14, 2026
@melvin-bot

melvin-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

🎯 @abzokhattab, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/671705.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@MonilBhavsar
MonilBhavsar merged commit 2cb1f4c into main Aug 17, 2026
53 of 55 checks passed
@MonilBhavsar
MonilBhavsar deleted the ionatan_removesubmit2026beta branch August 17, 2026 07:28
@github-actions

Copy link
Copy Markdown
Contributor

🚧 MonilBhavsar has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 18, 2026
86 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.4.55-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review — one doc update needed

This PR removes the submit2026 beta, making the Submit workspace feature set (including Submit via PDF) generally available. I reviewed docs/articles and found one stale file.

Change required — internal AgentZero reference:
docs/articles/Unlisted/Upcoming-Expense-And-Report-Management.md still lists Submit via PDF (Submit workspace) as an "upcoming / in-development" feature. Now that it's GA, AgentZero would incorrectly answer "coming soon." I removed that bullet.

No public-facing change needed: The public article Submit-Workspace.md already documents Submit workspaces as fully available and includes the complete How to submit an expense to an approver as a PDF section with the exact button labels (Submit / Submit via PDF). Removing the beta only widens access to an already-documented feature.

📝 Draft help site PR: #98822

@iwiznia, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.55-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

@melvin-bot

melvin-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #98922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants