You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-07] Expense - Add category button opens not here page when splitting expense in self DM #91879
Version Number: 9.3.84-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#84382 Email or phone of affected tester (no customers):sdjsodnjiodsjsoinj1@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Have a workspace.
Go to staging.new.expensify.com
Go to self DM.
Create an expense.
Open the expense.
Click More > Split.
Open any split.
Click Category.
Click Add category button.
Click back button on not here page.
Expected Result:
In Step 8, Add category button will open category creation page.
In Step 9, back button will return to category list.
Actual Result:
In Step 8, Add category button opens not here page when splitting expense in self DM.
In Step 9, back button on not here page closes RHP completely.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
IOURequestStepCategoryCreate.tsx is missing the policyForMovingExpenses fallback that IOURequestStepCategory.tsx already has for self-DM split edits.
When editing a split expense's category in a self-DM, the parent report has no policyID. IOURequestStepCategory.tsx:72-74 handles this correctly by falling back to policyForMovingExpenses when isEditingSplit && isSelfDM(report). But when the user clicks "Add category", navigation goes to IOURequestStepCategoryCreate, which resolves policy using only usePolicyForTransaction — no self-DM fallback. The resulting undefined policyID is passed to AccessOrNotFoundWrapper, which renders the "not found" page because isGroupPolicy(undefined) fails the PAID access check.
This was introduced by PR #84382 which added split support for unreported expenses but didn't propagate the policyForMovingExpenses fallback to the category create page.
What changes do you think we should make in order to solve the problem?
Apply the same fallback pattern used in IOURequestStepCategory.tsx: when isEditingSplit && isSelfDM(report), fall back to policyForMovingExpenses if usePolicyForTransaction returns no policy.
Use the effective policy's ID for policyID so AccessOrNotFoundWrapper receives a valid value.
This mirrors the existing fix in the category list page and keeps both pages consistent.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Expense - Add category button opens not here page when splitting expense in self DM[/-][+][Due for payment 2026-08-07] Expense - Add category button opens not here page when splitting expense in self DM[/+]on Jul 31, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.46-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon May 27, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/bab053b7c89141cc845ceffec927da21b79d2b7aeee0809fd424cc1ba4781800
melvin-bot commentedon May 27, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #84382
melvin-bot commentedon May 27, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 27, 2026
Proposal
What is the root cause of that problem?
IOURequestStepCategoryCreate.tsxis missing thepolicyForMovingExpensesfallback thatIOURequestStepCategory.tsxalready has for self-DM split edits.When editing a split expense's category in a self-DM, the parent report has no
policyID.IOURequestStepCategory.tsx:72-74handles this correctly by falling back topolicyForMovingExpenseswhenisEditingSplit && isSelfDM(report). But when the user clicks "Add category", navigation goes toIOURequestStepCategoryCreate, which resolves policy using onlyusePolicyForTransaction— no self-DM fallback. The resultingundefinedpolicyID is passed toAccessOrNotFoundWrapper, which renders the "not found" page becauseisGroupPolicy(undefined)fails thePAIDaccess check.This was introduced by PR #84382 which added split support for unreported expenses but didn't propagate the
policyForMovingExpensesfallback to the category create page.What changes do you think we should make in order to solve the problem?
In
IOURequestStepCategoryCreate.tsx:usePolicyForMovingExpensesandisSelfDM.IOURequestStepCategory.tsx: whenisEditingSplit && isSelfDM(report), fall back topolicyForMovingExpensesifusePolicyForTransactionreturns no policy.policyIDsoAccessOrNotFoundWrapperreceives a valid value.This mirrors the existing fix in the category list page and keeps both pages consistent.
Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.29 remaining items
mitarachim commentedon Jul 29, 2026
Deploy Blocker #97395 was identified to be related to the PR #92055 that attempted to fix this issue.
melvin-bot commentedon Jul 30, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
jponikarchuk commentedon Jul 30, 2026
Deploy Blocker #97424 was identified to be related to the PR #92055 that attempted to fix this issue.
melvin-bot commentedon Jul 30, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
lakchote commentedon Jul 30, 2026
Original issue is not reproducible by QA anymore, see https://expensify.slack.com/archives/C09V78U42D8/p1785396519081229?thread_ts=1785394378.160169&cid=C09V78U42D8
mitarachim commentedon Jul 30, 2026
Deploy Blocker #97436 was identified to be related to the PR #92055 that attempted to fix this issue.
melvin-bot commentedon Jul 30, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]Expense - Add category button opens not here page when splitting expense in self DM[/-][+][Due for payment 2026-08-07] Expense - Add category button opens not here page when splitting expense in self DM[/+]melvin-bot commentedon Jul 31, 2026
@ZhenjaHorbach
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.46-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Aug 19, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.