Skip to content

[Due for payment 2026-08-07] Expense - Add category button opens not here page when splitting expense in self DM #91879

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.84-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #84382
Email or phone of affected tester (no customers): sdjsodnjiodsjsoinj1@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Have a workspace.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Create an expense.
  4. Open the expense.
  5. Click More > Split.
  6. Open any split.
  7. Click Category.
  8. Click Add category button.
  9. Click back button on not here page.

Expected Result:

In Step 8, Add category button will open category creation page.
In Step 9, back button will return to category list.

Actual Result:

In Step 8, Add category button opens not here page when splitting expense in self DM.
In Step 9, back button on not here page closes RHP completely.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7164513_1779905210808.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7164513

Issue OwnerCurrent Issue Owner: @ZhenjaHorbach

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 27, 2026
  2. applause-bot commented on May 27, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/bab053b7c89141cc845ceffec927da21b79d2b7aeee0809fd424cc1ba4781800

  3. melvin-bot commented on May 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #84382

  4. melvin-bot commented on May 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on May 27, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    IOURequestStepCategoryCreate.tsx is missing the policyForMovingExpenses fallback that IOURequestStepCategory.tsx already has for self-DM split edits.

    When editing a split expense's category in a self-DM, the parent report has no policyID. IOURequestStepCategory.tsx:72-74 handles this correctly by falling back to policyForMovingExpenses when isEditingSplit && isSelfDM(report). But when the user clicks "Add category", navigation goes to IOURequestStepCategoryCreate, which resolves policy using only usePolicyForTransaction — no self-DM fallback. The resulting undefined policyID is passed to AccessOrNotFoundWrapper, which renders the "not found" page because isGroupPolicy(undefined) fails the PAID access check.

    This was introduced by PR #84382 which added split support for unreported expenses but didn't propagate the policyForMovingExpenses fallback to the category create page.

    What changes do you think we should make in order to solve the problem?

    In IOURequestStepCategoryCreate.tsx:

    1. Import usePolicyForMovingExpenses and isSelfDM.
    2. Apply the same fallback pattern used in IOURequestStepCategory.tsx: when isEditingSplit && isSelfDM(report), fall back to policyForMovingExpenses if usePolicyForTransaction returns no policy.
    3. Use the effective policy's ID for policyID so AccessOrNotFoundWrapper receives a valid value.

    This mirrors the existing fix in the category list page and keeps both pages consistent.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on May 28, 2026
  8. 29 remaining items

  9. mitarachim commented on Jul 29, 2026

    @mitarachim

    Deploy Blocker #97395 was identified to be related to the PR #92055 that attempted to fix this issue.

  10. melvin-bot commented on Jul 30, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. jponikarchuk commented on Jul 30, 2026

    @jponikarchuk

    Deploy Blocker #97424 was identified to be related to the PR #92055 that attempted to fix this issue.

  12. melvin-bot commented on Jul 30, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  13. lakchote commented on Jul 30, 2026

    @lakchote
    Contributor
  14. mitarachim commented on Jul 30, 2026

    @mitarachim

    Deploy Blocker #97436 was identified to be related to the PR #92055 that attempted to fix this issue.

  15. melvin-bot commented on Jul 30, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  16. changed the title [-]Expense - Add category button opens not here page when splitting expense in self DM[/-] [+][Due for payment 2026-08-07] Expense - Add category button opens not here page when splitting expense in self DM[/+] on Jul 31, 2026
  17. melvin-bot commented on Jul 31, 2026

    @melvin-bot

    @ZhenjaHorbach

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.46-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-07. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  18. melvin-bot commented on Aug 19, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions