You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-07] Spend - Incorrect "Total Spend" amount displayed after splitting unreported expense. #91920
Version Number: 9.3.84-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#84382 Email or phone of affected tester (no customers):ibellicotest+2723@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome App Component: Search
Action Performed:
Prerequisite: Account has Self DM.
Open the staging.new.expensify.com website.
Navigate to Self DM.
Create a manual expense.
Navigate to "Spend" > "Expenses"
Select the just created expense.
Click on dropdown menu > "Split" > Save splits amount.
Select one of the splits.
Note that "Total Spend" on footer shows an amount bigger than the one on the split.
Expected Result:
After splitting an unreported expense and selecting a split on "Expenses" section, "Total Spend" should display the same amount as the selected split.
Actual Result:
After splitting an unreported expense and selecting a split on "Expenses" section on "Spend", "Total Spend" displays an amount bigger than the one on the split.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
When an unreported expense is split, the parent transaction's reportID is set to '-2' (SPLIT_REPORT_ID). However, the client-side UNREPORTED status filter in SearchUIUtils.ts:386 only excludes TRASH_REPORT_ID ('-1'), not SPLIT_REPORT_ID ('-2'):
This allows the parent transaction (which still carries the full original amount) to pass the filter and appear alongside its child split transactions in the "Unreported" search results. When items are selected, the footer's "Total Spend" aggregates both the parent's full amount and the child's split amount, producing an inflated total.
What changes do you think we should make in order to solve the problem?
Add SPLIT_REPORT_ID to the exclusion check in the UNREPORTED filter at SearchUIUtils.ts:386 so parent split transactions are filtered out of unreported expense results:
This ensures parent transactions that have been split are no longer visible in unreported search results, preventing the double-counting in "Total Spend".
The optimistic update removes the parent from the search snapshot (SplitTransactionUpdate.ts:1569-1575), but after the server refreshes search results, the parent can reappear because the server-side query doesn't exclude SPLIT_REPORT_ID either
The UNREPORTED filter at line 386 lets it through since !undefined && '-2' !== '-1' evaluates to true
The total calculation at SearchPage.tsx sums all selected transaction amounts, double-counting when both parent and child are present
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.46-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon May 28, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/a5bbb0554eca617813ecbc75fd5990fc3950eca06afdef7018923ae814dbe4c2
melvin-bot commentedon May 28, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #84382
melvin-bot commentedon May 28, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 28, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 28, 2026
Proposal
What is the root cause of that problem?
When an unreported expense is split, the parent transaction's
reportIDis set to'-2'(SPLIT_REPORT_ID). However, the client-sideUNREPORTEDstatus filter inSearchUIUtils.ts:386only excludesTRASH_REPORT_ID('-1'), notSPLIT_REPORT_ID('-2'):This allows the parent transaction (which still carries the full original amount) to pass the filter and appear alongside its child split transactions in the "Unreported" search results. When items are selected, the footer's "Total Spend" aggregates both the parent's full amount and the child's split amount, producing an inflated total.
What changes do you think we should make in order to solve the problem?
Add
SPLIT_REPORT_IDto the exclusion check in theUNREPORTEDfilter atSearchUIUtils.ts:386so parent split transactions are filtered out of unreported expense results:This ensures parent transactions that have been split are no longer visible in unreported search results, preventing the double-counting in "Total Spend".
Supporting evidence
reportID = SPLIT_REPORT_IDatSplitTransactionUpdate.ts:1452-1458SplitTransactionUpdate.ts:1569-1575), but after the server refreshes search results, the parent can reappear because the server-side query doesn't excludeSPLIT_REPORT_IDeitherUNREPORTEDfilter at line 386 lets it through since!undefined && '-2' !== '-1'evaluates totrueSearchPage.tsxsums all selected transaction amounts, double-counting when both parent and child are presentNext Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.lakchote commentedon May 28, 2026
Since we've added the guard to hide the selfDM splits feature in production in the PR #91932, I'm going to remove the deploy blocker label @mountiny
24 remaining items
lanitochka17 commentedon Jul 29, 2026
Deploy Blocker #97400 was identified to be related to the PR #92055 that attempted to fix this issue.
melvin-bot commentedon Jul 29, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Jul 29, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mitarachim commentedon Jul 29, 2026
Deploy Blocker #97403 was identified to be related to the PR #92055 that attempted to fix this issue.
mitarachim commentedon Jul 29, 2026
Deploy Blocker #97395 was identified to be related to the PR #92055 that attempted to fix this issue.
melvin-bot commentedon Jul 30, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
jponikarchuk commentedon Jul 30, 2026
Deploy Blocker #97424 was identified to be related to the PR #92055 that attempted to fix this issue.
melvin-bot commentedon Jul 30, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
lakchote commentedon Jul 30, 2026
Original issue is not reproducible by QA anymore, see https://expensify.slack.com/archives/C09V78U42D8/p1785396519081229?thread_ts=1785394378.160169&cid=C09V78U42D8
melvin-bot commentedon Jul 30, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mitarachim commentedon Jul 30, 2026
Deploy Blocker #97436 was identified to be related to the PR #92055 that attempted to fix this issue.
[-]Spend - Incorrect "Total Spend" amount displayed after splitting unreported expense.[/-][+][Due for payment 2026-08-07] Spend - Incorrect "Total Spend" amount displayed after splitting unreported expense.[/+]melvin-bot commentedon Jul 31, 2026
@ZhenjaHorbach
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.46-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Aug 19, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.