Skip to content

[Due for payment 2026-06-29] [$250] [Home] Getting Started: "Other" accounting selection should not link to Connect to accounting step #93289

Closed

Description

@MelvinBot

Problem

When a user selects Other as their accounting system during onboarding, we still add a Connect to accounting step to the Getting started section. Clicking that step takes the user back to the Connections page and shows the same supported integration options they already reviewed and explicitly chose not to connect.

By selecting Other, the user has indicated they don't intend to connect one of the supported accounting integrations, so sending them back to the Connections page is confusing and redundant.

Expected behavior

When a user selects Other, the Connect to accounting step should instead point to customize categories rather than the Connections page.

Proposed changes

  • When a user selects Other, replace the Connect to accounting step with the existing Customize accounting categories option.

  • Customize accounting categories - Show when any other accounting option is selected in onboarding. Clicking this row navigates to the /categories route in the workspace editor. This row is automatically checked when the workspace has at least one, non-default category.

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. changed the title [-]Onboarding: "Other" accounting selection should not link to Connect to accounting step[/-] [+][Home] Getting Started: "Other" accounting selection should not link to Connect to accounting step[/+] on Jun 17, 2026
  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 18, 2026
  3. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 18, 2026
  4. melvin-bot commented on Jun 18, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @gijoe0295 (External)

  5. KJ21-ENG commented on Jun 18, 2026

    @KJ21-ENG
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    In the Home page Getting started section, users who selected Other as their onboarding accounting system still get a Connect to accounting task. Opening that task routes them back to workspace Accounting/Connections, even though Other means they already reviewed the supported integrations and do not intend to connect one.

    What is the root cause of that problem?

    src/pages/home/GettingStartedSection/hooks/useGettingStartedItems.ts decides whether to render the accounting task mostly from workspace accounting feature state:

    const isAccountingEnabled = !!policy?.areConnectionsEnabled || hasAccountingFeatureConnection(policy);
    ...
    if (isAccountingEnabled) {
        items.push({
            key: 'connectAccounting',
            ...
            route: ROUTES.WORKSPACE_ACCOUNTING.getRoute(activePolicyID),
        });
    } else {
        items.push({
            key: 'customizeCategories',
            ...
            route: ROUTES.WORKSPACE_CATEGORIES.getRoute(activePolicyID),
        });
    }

    The hook already defines DIRECT_CONNECT_INTEGRATIONS, but isDirectConnect is only used to choose the label (Connect to QuickBooks Online vs generic Connect to accounting). It is not used to decide whether the row should route to Accounting at all. So when the workspace has accounting/connections enabled, an onboarding choice like other can still fall into the connectAccounting branch and route to ROUTES.WORKSPACE_ACCOUNTING.

    This also explains why the existing intent is visible in tests: tests/unit/hooks/useGettingStartedItems.test.ts expects non-direct choices (sap, oracle, microsoftDynamics, other, none) to show customizeCategories, but the current implementation can fail that expectation whenever the policy has areConnectionsEnabled or an accounting feature connection.

    What changes do you think we should make in order to solve the problem?

    In useGettingStartedItems, split the row decision into:

    1. Direct-connect selection or real existing accounting connection: show connectAccounting and route to ROUTES.WORKSPACE_ACCOUNTING.
    2. Non-direct/no-connect selection such as other: show customizeCategories and route to ROUTES.WORKSPACE_CATEGORIES.

    Concretely, introduce a boolean along these lines:

    const hasExistingAccountingConnection = hasAccountingFeatureConnection(policy) || !!getValidConnectedIntegration(policy) || Object.values(policy?.connections ?? {}).some((conn) => !!conn?.lastSync?.successfulDate);
    const shouldShowConnectAccounting = isAccountingEnabled && (isDirectConnect || hasExistingAccountingConnection);

    Then use shouldShowConnectAccounting for the branch that pushes connectAccounting. This preserves the cache-cleared/already-connected fallback where a user has a real connection but ONBOARDING_USER_REPORTED_INTEGRATION is missing, while preventing other from routing back to the unsupported integration list just because the connections feature is enabled.

    Add/adjust unit coverage in:

    • tests/unit/hooks/useGettingStartedItems.test.ts
    • tests/unit/pages/home/GettingStartedSection/GettingStartedSectionTest.tsx

    The key regression test should set ONBOARDING_USER_REPORTED_INTEGRATION to other with areConnectionsEnabled: true and assert:

    • the item key is customizeCategories
    • the route is ROUTES.WORKSPACE_CATEGORIES.getRoute(policyID)
    • no connectAccounting row is rendered

    As a follow-up check while implementing, verify whether the older guided-setup task generation in src/libs/ReportUtils.ts should use the same direct-connect/non-direct distinction. It currently treats any truthy userReportedIntegration as a reason to filter out setup-categories tasks and include accounting tasks, which may create the same mismatch for other in task/chat surfaces.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    • Manage-team onboarding with other and areConnectionsEnabled: true shows Customize accounting categories and routes to workspace categories.
    • Direct-connect onboarding choices such as QBO/Xero still show Connect to <system> and route to workspace accounting when connections are enabled.
    • A workspace with an existing successful accounting connection still shows the generic Connect to accounting row even when ONBOARDING_USER_REPORTED_INTEGRATION is unavailable.
  6. melvin-bot commented on Jun 18, 2026

    @melvin-bot
  7. 18 remaining items

  8. melvin-bot commented on Jun 22, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Jun 22, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-29. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Jun 22, 2026

    @melvin-bot

    @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  11. ZhenjaHorbach commented on Jun 23, 2026

    @ZhenjaHorbach
    Contributor

    Tests:

    1. Sign up / onboard via "Manage my team's expenses" and select Other as the accounting system (leave the Accounting feature enabled on the Interested Features step).
    2. Open the workspace home and find the "Getting started" section.
    3. Verify the accounting row readsCustomize accounting categoriesand clicking it navigates to the workspace/categoriespage (not the Connections page).
    4. Repeat with a direct-connect choice (e.g. QuickBooks Online) and verify the row still readsConnect to QuickBooks Onlineand navigates to the Connections page.
  12. ZhenjaHorbach commented on Jun 23, 2026

    @ZhenjaHorbach
    Contributor

    @JmillsExpensify
    Let's add tests and close this issue!
    Since payment will be centralized in any case

  13. flaviadefaria commented on Jun 23, 2026

    @flaviadefaria
    Contributor

    Ah, I think @mallenexpensify can help with this. Matt assigning you here.

  14. mallenexpensify commented on Jun 26, 2026

    @mallenexpensify
    Contributor

    Test created, closing!

  15. moved this from Backlog to Done in Home pageon Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions