You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-29] [$250] [Home] Getting Started: "Other" accounting selection should not link to Connect to accounting step #93289
When a user selects Other as their accounting system during onboarding, we still add a Connect to accounting step to the Getting started section. Clicking that step takes the user back to the Connections page and shows the same supported integration options they already reviewed and explicitly chose not to connect.
By selecting Other, the user has indicated they don't intend to connect one of the supported accounting integrations, so sending them back to the Connections page is confusing and redundant.
Expected behavior
When a user selects Other, the Connect to accounting step should instead point to customize categories rather than the Connections page.
Proposed changes
When a user selects Other, replace the Connect to accounting step with the existing Customize accounting categories option.
Customize accounting categories - Show when any other accounting option is selected in onboarding. Clicking this row navigates to the /categories route in the workspace editor. This row is automatically checked when the workspace has at least one, non-default category.
changed the title [-]Onboarding: "Other" accounting selection should not link to Connect to accounting step[/-][+][Home] Getting Started: "Other" accounting selection should not link to Connect to accounting step[/+]on Jun 17, 2026
Please re-state the problem that we are trying to solve in this issue.
In the Home page Getting started section, users who selected Other as their onboarding accounting system still get a Connect to accounting task. Opening that task routes them back to workspace Accounting/Connections, even though Other means they already reviewed the supported integrations and do not intend to connect one.
What is the root cause of that problem?
src/pages/home/GettingStartedSection/hooks/useGettingStartedItems.ts decides whether to render the accounting task mostly from workspace accounting feature state:
The hook already defines DIRECT_CONNECT_INTEGRATIONS, but isDirectConnect is only used to choose the label (Connect to QuickBooks Online vs generic Connect to accounting). It is not used to decide whether the row should route to Accounting at all. So when the workspace has accounting/connections enabled, an onboarding choice like other can still fall into the connectAccounting branch and route to ROUTES.WORKSPACE_ACCOUNTING.
This also explains why the existing intent is visible in tests: tests/unit/hooks/useGettingStartedItems.test.ts expects non-direct choices (sap, oracle, microsoftDynamics, other, none) to show customizeCategories, but the current implementation can fail that expectation whenever the policy has areConnectionsEnabled or an accounting feature connection.
What changes do you think we should make in order to solve the problem?
In useGettingStartedItems, split the row decision into:
Direct-connect selection or real existing accounting connection: show connectAccounting and route to ROUTES.WORKSPACE_ACCOUNTING.
Non-direct/no-connect selection such as other: show customizeCategories and route to ROUTES.WORKSPACE_CATEGORIES.
Concretely, introduce a boolean along these lines:
Then use shouldShowConnectAccounting for the branch that pushes connectAccounting. This preserves the cache-cleared/already-connected fallback where a user has a real connection but ONBOARDING_USER_REPORTED_INTEGRATION is missing, while preventing other from routing back to the unsupported integration list just because the connections feature is enabled.
The key regression test should set ONBOARDING_USER_REPORTED_INTEGRATION to other with areConnectionsEnabled: true and assert:
the item key is customizeCategories
the route is ROUTES.WORKSPACE_CATEGORIES.getRoute(policyID)
no connectAccounting row is rendered
As a follow-up check while implementing, verify whether the older guided-setup task generation in src/libs/ReportUtils.ts should use the same direct-connect/non-direct distinction. It currently treats any truthy userReportedIntegration as a reason to filter out setup-categories tasks and include accounting tasks, which may create the same mismatch for other in task/chat surfaces.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Manage-team onboarding with other and areConnectionsEnabled: true shows Customize accounting categories and routes to workspace categories.
Direct-connect onboarding choices such as QBO/Xero still show Connect to <system> and route to workspace accounting when connections are enabled.
A workspace with an existing successful accounting connection still shows the generic Connect to accounting row even when ONBOARDING_USER_REPORTED_INTEGRATION is unavailable.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Sign up / onboard via "Manage my team's expenses" and select Other as the accounting system (leave the Accounting feature enabled on the Interested Features step).
Open the workspace home and find the "Getting started" section.
Verify the accounting row readsCustomize accounting categoriesand clicking it navigates to the workspace/categoriespage (not the Connections page).
Repeat with a direct-connect choice (e.g. QuickBooks Online) and verify the row still readsConnect to QuickBooks Onlineand navigates to the Connections page.
Activity
[-]Onboarding: "Other" accounting selection should not link to Connect to accounting step[/-][+][Home] Getting Started: "Other" accounting selection should not link to Connect to accounting step[/+]melvin-bot commentedon Jun 18, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @gijoe0295 (
External)KJ21-ENG commentedon Jun 18, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
In the Home page Getting started section, users who selected
Otheras their onboarding accounting system still get aConnect to accountingtask. Opening that task routes them back to workspace Accounting/Connections, even thoughOthermeans they already reviewed the supported integrations and do not intend to connect one.What is the root cause of that problem?
src/pages/home/GettingStartedSection/hooks/useGettingStartedItems.tsdecides whether to render the accounting task mostly from workspace accounting feature state:The hook already defines
DIRECT_CONNECT_INTEGRATIONS, butisDirectConnectis only used to choose the label (Connect to QuickBooks Onlinevs genericConnect to accounting). It is not used to decide whether the row should route to Accounting at all. So when the workspace has accounting/connections enabled, an onboarding choice likeothercan still fall into theconnectAccountingbranch and route toROUTES.WORKSPACE_ACCOUNTING.This also explains why the existing intent is visible in tests:
tests/unit/hooks/useGettingStartedItems.test.tsexpects non-direct choices (sap,oracle,microsoftDynamics,other,none) to showcustomizeCategories, but the current implementation can fail that expectation whenever the policy hasareConnectionsEnabledor an accounting feature connection.What changes do you think we should make in order to solve the problem?
In
useGettingStartedItems, split the row decision into:connectAccountingand route toROUTES.WORKSPACE_ACCOUNTING.other: showcustomizeCategoriesand route toROUTES.WORKSPACE_CATEGORIES.Concretely, introduce a boolean along these lines:
Then use
shouldShowConnectAccountingfor the branch that pushesconnectAccounting. This preserves the cache-cleared/already-connected fallback where a user has a real connection butONBOARDING_USER_REPORTED_INTEGRATIONis missing, while preventingotherfrom routing back to the unsupported integration list just because the connections feature is enabled.Add/adjust unit coverage in:
tests/unit/hooks/useGettingStartedItems.test.tstests/unit/pages/home/GettingStartedSection/GettingStartedSectionTest.tsxThe key regression test should set
ONBOARDING_USER_REPORTED_INTEGRATIONtootherwithareConnectionsEnabled: trueand assert:customizeCategoriesROUTES.WORKSPACE_CATEGORIES.getRoute(policyID)connectAccountingrow is renderedAs a follow-up check while implementing, verify whether the older guided-setup task generation in
src/libs/ReportUtils.tsshould use the same direct-connect/non-direct distinction. It currently treats any truthyuserReportedIntegrationas a reason to filter out setup-categories tasks and include accounting tasks, which may create the same mismatch forotherin task/chat surfaces.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
otherandareConnectionsEnabled: trueshowsCustomize accounting categoriesand routes to workspace categories.Connect to <system>and route to workspace accounting when connections are enabled.Connect to accountingrow even whenONBOARDING_USER_REPORTED_INTEGRATIONis unavailable.melvin-bot commentedon Jun 18, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022067567512690560679
18 remaining items
melvin-bot commentedon Jun 22, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 22, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-29. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 22, 2026
@ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
ZhenjaHorbach commentedon Jun 23, 2026
Tests:
ZhenjaHorbach commentedon Jun 23, 2026
@JmillsExpensify
Let's add tests and close this issue!
Since payment will be centralized in any case
flaviadefaria commentedon Jun 23, 2026
Ah, I think @mallenexpensify can help with this. Matt assigning you here.
mallenexpensify commentedon Jun 26, 2026
Test created, closing!