Repository navigation
Route Getting Started accounting row to categories for non-direct integrations - #93930
Conversation
…egrations Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
|
@MelvinBot |
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🤖 Completed the PR Author Checklist and marked this PR as ready for review. I checked off the code-quality and process attestations (linked issue, testing steps, code patterns, unit test added, plus the conditional "If…" items that don't apply here). All CI is green — the only previously-failing check was I intentionally left these boxes unchecked because they require manual verification I can't perform as a bot —
I also did not fill in the |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-06-18.17.15.23.movAndroid: mWeb Chrome2026-06-18.17.03.24.moviOS: HybridApp2026-06-18.17.15.23.moviOS: mWeb Safari2026-06-18.17.03.24.movMacOS: Chrome / Safari2026-06-18.16.43.41.mov |
|
@MelvinBot PR Author Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / Safari |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #93289 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.16-1 🚀
Bundle Size Analysis (Sentry): |
|
🤖 No help site changes required. I reviewed the changes in this PR against the help articles under What this PR changes: It's a bug fix to the internal logic in Why no docs update is needed: The only article that documents this area is Since no help site content is affected, I did not create a docs PR. If you'd like the article to start documenting the manage-my-team Getting started checklist items (including this accounting row behavior), let me know and I can draft that addition. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.16-5 🚀
|
Explanation of Change
When a user selected Other as their accounting system during onboarding, the "Getting started" section still showed a Connect to accounting step that routed back to the workspace Connections page — the same supported-integration list the user explicitly opted out of.
The root cause is in
useGettingStartedItems.ts: the row was chosen purely fromisAccountingEnabled(areConnectionsEnabled || hasAccountingFeatureConnection). Selecting Other stores a truthyuserReportedIntegration = 'other', which pre-checks the Accounting feature during onboarding and ends up settingareConnectionsEnabled: trueon the policy — so the "Connect to accounting" branch won even though no supported integration was chosen.This change gates the "Connect to accounting" row on
isDirectConnect || hasAccountingFeatureConnection(policy)instead ofareConnectionsEnabledalone:/categories.Added a regression unit test covering the
other+areConnectionsEnabled: truecase. All 80 tests in the suite pass.Fixed Issues
$ #93289
PROPOSAL: #93289 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
/categoriespage (not the Connections page).Offline tests
Same as Tests.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari