You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The local evidence matches this recurring failure shape: native callback assumes current policy/report still exists. Here, src/libs/actions/HybridApp/index.ts:36 and src/libs/actions/HybridApp/index.ts:46 do not agree on the same APP, HybridApp, getViewState value, so the user-visible path can show a missing or stale state even though nearby data already has the needed context.
What changes do you think we should make in order to solve the problem?
Update src/libs/actions/HybridApp/index.ts:36 to derive APP, HybridApp, getViewState from the matched app state path that owns this flow before the value is consumed.
Carry the same normalized value through src/libs/actions/HybridApp/index.ts:46; that follows the safer family move to add the guard at the ownership boundary, not only at render, so the write/optimistic/read paths agree instead of only changing the visible component.
Keep the change inside the Sentry Crash, Null/Undefined, Native Hybrid surface and avoid changing do not hide crashes with blanket catch, native platform differences.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Add or update a regression in tests/unit/**/*.ts for the exact issue flow: [$250] [Sentry: APP-3E3] HybridApp Android Fabric getViewState RetryableMountingLayerException.
Cover the counter-case near src/libs/actions/HybridApp/index.ts:36 so valid existing APP, HybridApp, getViewState behavior still works.
Manually repeat the issue steps after the patch and confirm the visible state/action is no longer stale.
What alternative solutions did you explore? (Optional)
I would not add a broad new condition outside these referenced paths; the safer fix is to keep APP, HybridApp, getViewState consistent at the first read/write boundary shown above.
removeClippedSubviews is a legacy ScrollView optimization that makes Android imperatively detach and re-attach child views from their parent ViewGroup as they cross the clipping rect — work done outside of Fabric's knowledge. At the same time, FlashList v2 (2.3.0) is recycling cells, and the expandable report-group rows mount/unmount their GroupChildrenContent subtree on every expand/collapse:
So the causal chain is: removeClippedSubviews strips a subview and disposes its ViewState behind Fabric's back → a queued IntBufferBatchMountItem (addViewAt) still references that view tag → SurfaceMountingManager.getViewState can't find the state → RetryableMountingLayerException, surfaced through UncaughtExceptionHandler. This is Android/Fabric-only, which is why the web variant — same prop, no Fabric — doesn't crash. On the new architecture FlashList already does its own windowing/recycling, so removeClippedSubviews is both redundant and the trigger (it's the only added knob the native variant doesn't strictly need).
What changes do you think we should make in order to solve the problem?
Drop the removeClippedSubviews prop from the native Search FlashList here:
FlashList v2 virtualizes off-screen rows itself, so removing the prop keeps the memory/scroll behavior while eliminating the imperative view detaching that races with Fabric's mount items. The web variant keeps the prop (harmless without Fabric), or it can be removed there too for consistency:
The same null-ViewState guard could be extended to the addViewAt path. That stops the crash but only masks the symptom — it leaves the imperative-clipping/Fabric race in place (views may still mount in the wrong place), so it's a fallback rather than the fix.
⚠️ Note for reviewer: the existing proposal above (pointing at src/libs/actions/HybridApp/index.ts) is not related to this crash. That file has nothing to do with Fabric view mounting — the crash is in React Native's native Android mounting layer, not in any Onyx connection.
Please re-state the problem that we are trying to solve in this issue.
Android HybridApp crashes with RetryableMountingLayerException: Unable to find viewState for tag X originating in React Native's Fabric mounting layer (SurfaceMountingManager.getViewState ← addViewAt), most often on the /search view.
What is the root cause of that problem?
This is a known React Native Fabric mounting race — not an App business-logic bug. When transactions are merged and reordered within a single mount cycle, a CREATE/INSERT mount item can end up referencing a parentTag whose ViewState was already deleted in the reordered batch. addViewAt then calls the throwing variant getViewState(parentTag), which raises RetryableMountingLayerException and crashes the app.
The throw site: SurfaceMountingManager.getViewState raises RetryableMountingLayerException when mTagToViewState.get(tag) is null.
The unguarded caller: addViewAt(...) calls getViewState(parentTag) (and getViewState(tag)) directly, with no null-safety — this exactly matches the reported stack (getViewState ← addViewAt ← IntBufferBatchMountItem.execute).
This is the same crash family as the prior fixes:
Expensify/App#50482 / #50463 → patched on RN 0.75.2 via PR #53313 (a C++ transaction-reordering fix that no longer exists; App is now on RN 0.83.1).
// getViewState — the throw siteprivate@NonNullViewStategetViewState(inttag) {
ViewStateviewState = mTagToViewState.get(tag);
if (viewState == null) {
thrownewRetryableMountingLayerException(
"Unable to find viewState for tag " + tag + ". Surface stopped: " + isStopped());
}
returnviewState;
}
Upstream RN already uses the safe getNullableViewState + ReactSoftExceptionLogger.logSoftException pattern in many sibling methods in this same file (e.g. removeViewAt, deleteView, updateLayout, and the App-patched updateProps). addViewAt was simply never converted.
What changes do you think we should make in order to solve the problem?
Extend the existing patch-package patch (in the App repo, so this is actionable here) to make addViewAt defensive, mirroring the already-accepted approach used for updateProps in patch #027:
In addViewAt, replace getViewState(parentTag) / getViewState(tag) with getNullableViewState(...).
If either is null, call ReactSoftExceptionLogger.logSoftException(...) with the existing SURFACE_MOUNTING_MANAGER_MISSING_VIEWSTATE category and return early instead of throwing — the dropped mount item is recoverable, and the next consistent transaction re-renders the view.
Add the new patch under patches/react-native/ and document it in patches/react-native/details.md, referencing this issue and the upstream RN discussion.
This converts a hard crash into a soft-logged, recoverable no-op, exactly as the team already chose to do for the updateProps variant.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
This is a native-layer (Java) patch, so JS unit tests can't exercise it directly. Verification should be:
Confirm the patch applies cleanly and the app builds for Android HybridApp.
Manual/QA smoke of the /search view with rapid navigation and offline→online transitions to confirm no crash.
Monitor Sentry APP-3E3 for a drop in events and a corresponding rise in the soft-exception log category after release.
What alternative solutions did you explore? (Optional)
Next Steps for Contributor+ team: To accept:@MelvinBot implement this to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
RetryableMountingLayerException thrown from SurfaceMountingManager.getViewState ← addViewAt is a New-Architecture (Fabric) mounting crash: a queued IntBufferBatchMountItem (addViewAt) references a view tag whose ViewState was already removed from mTagToViewState, so the throwing getViewState variant blows up. The trigger is one App-side prop: removeClippedSubviews enabled on the lists rendered on /search.
removeClippedSubviews is a legacy ScrollView optimization that makes Android imperatively detach / re-attach child views from their parent ViewGroup as they cross the clipping rect — mutations done outside Fabric's mounting transaction. When that imperative detach disposes a view's ViewState behind Fabric's back, the next batched addViewAt mount item still points at that tag → getViewState returns null → throw. It is Android/Fabric-only, which is exactly the platform in the Sentry report (the web variant has the same prop but no Fabric mounting layer, so it never crashes).
On /search this prop is set in two places, and the second one is the stronger suspect because it is a core React Native FlatList (where removeClippedSubviews is the textbook cause of this crash), not a FlashList:
The static results list shown during submit-and-navigate — a core FlatList with removeClippedSubviews:
Note that FlashListProps extends Omit<ScrollViewProps, "maintainVisibleContentPosition">, so removeClippedSubviews (inherited from ScrollViewProps/ViewProps) is simply forwarded onto the underlying native ScrollView — FlashList v2 (2.3.0) does its own windowing/recycling, so the prop adds zero benefit and only layers a second, Fabric-invisible view-detaching mechanism on top of FlashList's recycling. Same redundant-but-harmful situation on the web variant:
So: removeClippedSubviews imperatively strips a /search row and disposes its ViewState → a queued addViewAt still references that tag → SurfaceMountingManager.getViewState finds no state → RetryableMountingLayerException via UncaughtExceptionHandler, on Android HybridApp only.
This is already an established crash class in this repo, and the codebase's own fix is to not use the prop — not to patch RN:
The Search lists are the outliers that re-introduced it.
What changes do you think we should make in order to solve the problem?
Remove removeClippedSubviews from every list rendered on /search, matching the pattern the repo already settled on for the report view in #66988 (removeClippedSubviews={false} / omit it) and the canonical SelectionList FlashLists (which never set it):
SearchStaticList.tsx:372 — drop removeClippedSubviews from the core FlatList (this is the highest-risk instance: core FlatList + Fabric is the classic addViewAt/getViewState race).
BaseSearchList/index.native.tsx:44 — drop removeClippedSubviews from the FlashList; FlashList v2 already virtualizes off-screen rows, so scroll/memory behavior is unchanged.
BaseSearchList/index.tsx:187 — remove it on web too for consistency (harmless there, no Fabric).
This is the reuse-first fix: it converges the Search lists onto the exact convention already proven on MoneyRequestReportActionsList (#66988) and the SelectionList components, eliminating the imperative, Fabric-invisible view detaching that races with mount items. No new code, no RN patch, no behavior change. Minor changes/improvements can be discussed in the PR phase.
What alternative solutions did you explore? (Optional)
Patch RN's native SurfaceMountingManager.addViewAt to call getNullableViewState + ReactSoftExceptionLogger.logSoftException and early-return (mirroring the existing react-native+0.83.1+027+log-soft-exception-if-viewState-not-found.patch that already does this for the updateProps path). That only masks the symptom — the view still fails to mount in the right place, and it leaves the imperative-clipping/Fabric race in every other list that passes removeClippedSubviews. Removing the prop on /search fixes the actual trigger and aligns with the team's existing in-repo decision (#66988), so it's preferable; the patch is a reasonable defense-in-depth fallback but not the fix.
⚠️@yusufdeveloper2903 Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
@mallenexpensify I agree the reference should be addressed, but #94402 was not a regression caused by my work here.
#94402 was opened on June 24, before my PRs #97010 and #98869 were created or merged. It reproduced the already-existing APP-3E3 crash and linked to #93833 as the underlying issue. The deploy blocker was handled by reverting #93403 through #94470.
Therefore, #94402 is related historical evidence, not a regression introduced by either of my PRs and should not reduce the payment. @eVoloshchak, could you please confirm this for the checklist?
The earlier payment summary covers another contributor’s work. My work included PR #97010 for the confirmed updateOverflowInset crash, followed by a separately approved investigation and PR #98869 after Sentry identified a crash through updateState. Could you confirm the payment covering my contributions?
This event occurred through updateState, which #97010 had not changed. It therefore did not demonstrate a failure of the updateOverflowInset guard. Both paths belong to the same underlying missing-ViewState problem; the initial patch covered the confirmed caller at that time, rather than the entire failure class.
The restoration of updateOverflowInset on RN 0.86 was already covered by #98604; my follow-up added the two remaining methods within the approved scope.
@eVoloshchak also confirmed that the historical regression discussed above originated in #93403 and was not caused by my PRs.
I understand that multiple PRs do not automatically increase the job price. I’m providing this context so you can confirm the payment for my contributions and determine whether the separately approved follow-up work warrants any adjustment.
Activity
melvin-bot commentedon Jun 17, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)melvin-bot commentedon Jun 17, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022067265956277613779
godzillaxbox19982014-lgtm commentedon Jun 17, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
[$250] [Sentry: APP-3E3] HybridApp Android Fabric getViewState RetryableMountingLayerException
What is the root cause of that problem?
I traced this to the path that handles
APP, HybridApp, getViewState:connectWithoutView):Onyx.connectWithoutView({connectWithoutView):Onyx.connectWithoutView({connectWithoutView):Onyx.connectWithoutView({src/libs/actions/HybridApp/index.ts:36andsrc/libs/actions/HybridApp/index.ts:46do not agree on the sameAPP, HybridApp, getViewStatevalue, so the user-visible path can show a missing or stale state even though nearby data already has the needed context.What changes do you think we should make in order to solve the problem?
src/libs/actions/HybridApp/index.ts:36to deriveAPP, HybridApp, getViewStatefrom the matched app state path that owns this flow before the value is consumed.src/libs/actions/HybridApp/index.ts:46; that follows the safer family move to add the guard at the ownership boundary, not only at render, so the write/optimistic/read paths agree instead of only changing the visible component.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
tests/unit/**/*.tsfor the exact issue flow: [$250] [Sentry: APP-3E3] HybridApp Android Fabric getViewState RetryableMountingLayerException.src/libs/actions/HybridApp/index.ts:36so valid existingAPP, HybridApp, getViewStatebehavior still works.What alternative solutions did you explore? (Optional)
APP, HybridApp, getViewStateconsistent at the first read/write boundary shown above.lorretheboy commentedon Jun 17, 2026
Proposal
What is the root cause of that problem?
The native Search list renders inside a FlashList that is given
removeClippedSubviews:App/src/components/Search/SearchList/BaseSearchList/index.native.tsx
Line 44 in 6513211
removeClippedSubviewsis a legacy ScrollView optimization that makes Android imperatively detach and re-attach child views from their parentViewGroupas they cross the clipping rect — work done outside of Fabric's knowledge. At the same time, FlashList v2 (2.3.0) is recycling cells, and the expandable report-group rows mount/unmount theirGroupChildrenContentsubtree on every expand/collapse:App/src/components/Search/SearchList/ListItem/GroupChildrenContainer.tsx
Lines 50 to 88 in 6513211
So the causal chain is:
removeClippedSubviewsstrips a subview and disposes itsViewStatebehind Fabric's back → a queuedIntBufferBatchMountItem(addViewAt) still references that view tag →SurfaceMountingManager.getViewStatecan't find the state →RetryableMountingLayerException, surfaced throughUncaughtExceptionHandler. This is Android/Fabric-only, which is why the web variant — same prop, no Fabric — doesn't crash. On the new architecture FlashList already does its own windowing/recycling, soremoveClippedSubviewsis both redundant and the trigger (it's the only added knob the native variant doesn't strictly need).What changes do you think we should make in order to solve the problem?
Drop the
removeClippedSubviewsprop from the native Search FlashList here:App/src/components/Search/SearchList/BaseSearchList/index.native.tsx
Line 44 in 6513211
FlashList v2 virtualizes off-screen rows itself, so removing the prop keeps the memory/scroll behavior while eliminating the imperative view detaching that races with Fabric's mount items. The web variant keeps the prop (harmless without Fabric), or it can be removed there too for consistency:
App/src/components/Search/SearchList/BaseSearchList/index.tsx
Line 187 in 6513211
After the change, regression-test scrolling and rapidly expanding/collapsing groups on the
/searchreport view on an Android HybridApp build.What alternative solutions did you explore? (Optional)
The repo already soft-logs (instead of crashing) the sibling
updatePropscase via a RN patch:https://github.com/Expensify/App/blob/6513211aec3c051f53cffd8e3f42074dd383ce28/patches/react-native/react-native+0.83.1+027+log-soft-exception-if-viewState-not-found.patch
The same null-
ViewStateguard could be extended to theaddViewAtpath. That stops the crash but only masks the symptom — it leaves the imperative-clipping/Fabric race in place (views may still mount in the wrong place), so it's a fallback rather than the fix.MelvinBot commentedon Jun 17, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Android HybridApp crashes with
RetryableMountingLayerException: Unable to find viewState for tag Xoriginating in React Native's Fabric mounting layer (SurfaceMountingManager.getViewState←addViewAt), most often on the/searchview.What is the root cause of that problem?
This is a known React Native Fabric mounting race — not an App business-logic bug. When transactions are merged and reordered within a single mount cycle, a
CREATE/INSERTmount item can end up referencing aparentTagwhoseViewStatewas already deleted in the reordered batch.addViewAtthen calls the throwing variantgetViewState(parentTag), which raisesRetryableMountingLayerExceptionand crashes the app.SurfaceMountingManager.getViewStateraisesRetryableMountingLayerExceptionwhenmTagToViewState.get(tag)isnull.addViewAt(...)callsgetViewState(parentTag)(andgetViewState(tag)) directly, with no null-safety — this exactly matches the reported stack (getViewState←addViewAt←IntBufferBatchMountItem.execute).This is the same crash family as the prior fixes:
Expensify/App#50482/#50463→ patched on RN 0.75.2 via PR #53313 (a C++ transaction-reordering fix that no longer exists; App is now on RN 0.83.1).Expensify/App#82611→ patched via PR #84303, which added the current patchreact-native+0.83.1+027+log-soft-exception-if-viewState-not-found.patch. That patch converts theupdatePropspath to usegetNullableViewState+ a soft exception — but it does not cover theaddViewAtpath, which is the one crashing here.Code evidence (RN 0.83.1, node_modules)
ReactAndroid/.../fabric/mounting/SurfaceMountingManager.java:Upstream RN already uses the safe
getNullableViewState+ReactSoftExceptionLogger.logSoftExceptionpattern in many sibling methods in this same file (e.g.removeViewAt,deleteView,updateLayout, and the App-patchedupdateProps).addViewAtwas simply never converted.What changes do you think we should make in order to solve the problem?
Extend the existing patch-package patch (in the App repo, so this is actionable here) to make
addViewAtdefensive, mirroring the already-accepted approach used forupdatePropsin patch#027:addViewAt, replacegetViewState(parentTag)/getViewState(tag)withgetNullableViewState(...).null, callReactSoftExceptionLogger.logSoftException(...)with the existingSURFACE_MOUNTING_MANAGER_MISSING_VIEWSTATEcategory andreturnearly instead of throwing — the dropped mount item is recoverable, and the next consistent transaction re-renders the view.patches/react-native/and document it inpatches/react-native/details.md, referencing this issue and the upstream RN discussion.This converts a hard crash into a soft-logged, recoverable no-op, exactly as the team already chose to do for the
updatePropsvariant.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
This is a native-layer (Java) patch, so JS unit tests can't exercise it directly. Verification should be:
/searchview with rapid navigation and offline→online transitions to confirm no crash.APP-3E3for a drop in events and a corresponding rise in the soft-exception log category after release.What alternative solutions did you explore? (Optional)
CREATEmutations being dropped by merging transactions #53313) to RN 0.83.1 — addresses the true root cause but is a much larger, riskier C++ change and may already be partially upstreamed.The soft-exception patch matches the team's existing precedent (
#027) and is the lowest-risk stop-gap.Related issues
Expensify/App#82611— sameRetryableMountingLayerExceptionfamily; fixed for theupdatePropspath via PR fix(react-native): log soft exception for missing viewState #84303.Expensify/App#50482/Expensify/App#50463— same family on RN 0.75.2; fixed via PR [No QA] FixCREATEmutations being dropped by merging transactions #53313.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement thisto create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
yusufdeveloper2903 commentedon Jun 17, 2026
Proposal
What is the root cause of that problem?
RetryableMountingLayerExceptionthrown fromSurfaceMountingManager.getViewState←addViewAtis a New-Architecture (Fabric) mounting crash: a queuedIntBufferBatchMountItem(addViewAt) references a view tag whoseViewStatewas already removed frommTagToViewState, so the throwinggetViewStatevariant blows up. The trigger is one App-side prop:removeClippedSubviewsenabled on the lists rendered on/search.removeClippedSubviewsis a legacy ScrollView optimization that makes Android imperatively detach / re-attach child views from their parentViewGroupas they cross the clipping rect — mutations done outside Fabric's mounting transaction. When that imperative detach disposes a view'sViewStatebehind Fabric's back, the next batchedaddViewAtmount item still points at that tag →getViewStatereturns null → throw. It is Android/Fabric-only, which is exactly the platform in the Sentry report (the web variant has the same prop but no Fabric mounting layer, so it never crashes).On
/searchthis prop is set in two places, and the second one is the stronger suspect because it is a core React NativeFlatList(whereremoveClippedSubviewsis the textbook cause of this crash), not a FlashList:The static results list shown during submit-and-navigate — a core
FlatListwithremoveClippedSubviews:App/src/components/Search/SearchStaticList.tsx
Lines 366 to 372 in 968eccd
The main results list — a FlashList v2 wrapped in
Animated.createAnimatedComponent, withremoveClippedSubviews:App/src/components/Search/SearchList/BaseSearchList/index.native.tsx
Lines 32 to 51 in 968eccd
Note that
FlashListPropsextendsOmit<ScrollViewProps, "maintainVisibleContentPosition">, soremoveClippedSubviews(inherited fromScrollViewProps/ViewProps) is simply forwarded onto the underlying native ScrollView — FlashList v2 (2.3.0) does its own windowing/recycling, so the prop adds zero benefit and only layers a second, Fabric-invisible view-detaching mechanism on top of FlashList's recycling. Same redundant-but-harmful situation on the web variant:App/src/components/Search/SearchList/BaseSearchList/index.tsx
Line 187 in 968eccd
So:
removeClippedSubviewsimperatively strips a/searchrow and disposes itsViewState→ a queuedaddViewAtstill references that tag →SurfaceMountingManager.getViewStatefinds no state →RetryableMountingLayerExceptionviaUncaughtExceptionHandler, on Android HybridApp only.This is already an established crash class in this repo, and the codebase's own fix is to not use the prop — not to patch RN:
MoneyRequestReportView→MoneyRequestReportActionsList, i.e. the report opened from/search) explicitly setsremoveClippedSubviews={false}"to keep elements in virtual tree", added for the same crash family in [Due for payment 2025-08-13] [$250] Composer - Edit compose box is not auto-focused when editing a message in report page #66988:App/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx
Line 755 in 968eccd
BaseSelectionList,BaseSelectionListWithSections) deliberately do not passremoveClippedSubviews:App/src/components/SelectionList/BaseSelectionList.tsx
Lines 622 to 642 in 968eccd
App/src/components/SelectionList/SelectionListWithSections/BaseSelectionListWithSections.tsx
Lines 435 to 460 in 968eccd
The Search lists are the outliers that re-introduced it.
What changes do you think we should make in order to solve the problem?
Remove
removeClippedSubviewsfrom every list rendered on/search, matching the pattern the repo already settled on for the report view in #66988 (removeClippedSubviews={false}/ omit it) and the canonical SelectionList FlashLists (which never set it):SearchStaticList.tsx:372— dropremoveClippedSubviewsfrom the coreFlatList(this is the highest-risk instance: coreFlatList+ Fabric is the classicaddViewAt/getViewStaterace).BaseSearchList/index.native.tsx:44— dropremoveClippedSubviewsfrom the FlashList; FlashList v2 already virtualizes off-screen rows, so scroll/memory behavior is unchanged.BaseSearchList/index.tsx:187— remove it on web too for consistency (harmless there, no Fabric).This is the reuse-first fix: it converges the Search lists onto the exact convention already proven on
MoneyRequestReportActionsList(#66988) and the SelectionList components, eliminating the imperative, Fabric-invisible view detaching that races with mount items. No new code, no RN patch, no behavior change. Minor changes/improvements can be discussed in the PR phase.What alternative solutions did you explore? (Optional)
Patch RN's native
SurfaceMountingManager.addViewAtto callgetNullableViewState+ReactSoftExceptionLogger.logSoftExceptionand early-return (mirroring the existingreact-native+0.83.1+027+log-soft-exception-if-viewState-not-found.patchthat already does this for theupdatePropspath). That only masks the symptom — the view still fails to mount in the right place, and it leaves the imperative-clipping/Fabric race in every other list that passesremoveClippedSubviews. Removing the prop on/searchfixes the actual trigger and aligns with the team's existing in-repo decision (#66988), so it's preferable; the patch is a reasonable defense-in-depth fallback but not the fix.github-actions commentedon Jun 17, 2026
128 remaining items
KJ21-ENG commentedon Sep 3, 2026
@mallenexpensify I agree the reference should be addressed, but #94402 was not a regression caused by my work here.
#94402 was opened on June 24, before my PRs #97010 and #98869 were created or merged. It reproduced the already-existing APP-3E3 crash and linked to #93833 as the underlying issue. The deploy blocker was handled by reverting #93403 through #94470.
Therefore, #94402 is related historical evidence, not a regression introduced by either of my PRs and should not reduce the payment. @eVoloshchak, could you please confirm this for the checklist?
eVoloshchak commentedon Sep 7, 2026
Yes, the regression wasn't caused by this PR, it was caused by #93403, not related to our issue
melvin-bot commentedon Sep 8, 2026
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
mallenexpensify commentedon Sep 8, 2026
There's a payment summary above, are more/other payments due? Guessing so cuz there's a separate PR that @KJ21-ENG authored. cc @mountiny
KJ21-ENG commentedon Sep 9, 2026
The earlier payment summary covers another contributor’s work. My work included PR #97010 for the confirmed
updateOverflowInsetcrash, followed by a separately approved investigation and PR #98869 after Sentry identified a crash throughupdateState. Could you confirm the payment covering my contributions?cc: @eVoloshchak @mountiny @mallenexpensify
Detailed Context
Earlier payment summary
The existing payment summary lists @lorretheboy’s implementation payment and @eVoloshchak’s review payment. It does not include my contributions below.
Initial approved fix: PR #97010
@mountiny shared a Sentry stack identifying the crashing path as:
getViewState → updateOverflowInset → IntBufferBatchMountItemI proposed a narrow backport of React Native’s upstream guard for
updateOverflowInset. Following approval and assignment, I delivered #97010.Subsequent investigation and follow-up: PR #98869
After deployment, APP-3E3 continued receiving events. The subsequent Sentry stack confirmed a different crashing method:
getViewState → updateState → IntBufferBatchMountItemThis event occurred through
updateState, which #97010 had not changed. It therefore did not demonstrate a failure of theupdateOverflowInsetguard. Both paths belong to the same underlying missing-ViewStateproblem; the initial patch covered the confirmed caller at that time, rather than the entire failure class.I investigated the recurrence and proposed the follow-up scope. After technical review and authorization to proceed, I delivered #98869, backporting the upstream guards for
updateStateandupdatePaddingto React Native 0.86.The restoration of
updateOverflowInseton RN 0.86 was already covered by #98604; my follow-up added the two remaining methods within the approved scope.After deployment, @eVoloshchak reported that the error was last seen in a version preceding the follow-up fix.
Regression clarification and payment
@eVoloshchak also confirmed that the historical regression discussed above originated in #93403 and was not caused by my PRs.
I understand that multiple PRs do not automatically increase the job price. I’m providing this context so you can confirm the payment for my contributions and determine whether the separately approved follow-up work warrants any adjustment.
Thanks, @mallenexpensify @mountiny @eVoloshchak.
mallenexpensify commentedon Sep 9, 2026
Payment Summary
Contributor: @KJ21-ENG paid $250 via Upwork
Contributor+: @eVoloshchak due $250 via NewDot
@KJ21-ENG https://www.upwork.com/jobs/~022097726163994355293
From Claude tool I'm building for issue reviews.
Payment Summary (round 2)
Upwork Job
Round 1 is already settled: @lorretheboy paid $250 and @eVoloshchak owed $250 for #94095, per #93833 (comment)
Reasoning:
updateOverflowInset. The recurrence crashed throughupdateState, which Backport missing ViewState guard for updateOverflowInset #97010 did not change.KJ21-ENG commentedon Sep 9, 2026
@mallenexpensify Offer accepted, Thanks!
JmillsExpensify commentedon Sep 30, 2026
$250 approved for @eVoloshchak
mallenexpensify commentedon Oct 1, 2026
@KJ21-ENG was paid, just seeing I didn't confirm they were in Upwork