You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-06] [Due for payment 2026-07-02] [Due for payment 2026-07-01] Android - IOU - App crashes after mark as paid and view IOU offline #94402
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
⚠️Preliminary analysis — the user-flow and regression window are confirmed, but the exact crashing frame still needs the Android stack trace. Treat the root-cause section as the leading lead, not a settled conclusion.
Issue Analysis
What we know for sure: This is a render crash, not a navigation crash. On an Android phone (small screen), tapping View on the money-request preview calls openReportFromPreview, which navigates to the full IOU report via ROUTES.REPORT_WITH_ID — MoneyRequestReportPreviewContent.tsx. On wide layouts it instead opens the lighter EXPENSE_REPORT_RHP, which is why this reproduces on Android app but not desktop/mWeb. The crash happens while rendering that IOU report, which now contains the freshly-added optimistic PAY action and an optimistically-settled (REIMBURSED) report from the offline mark-as-paid.
Regression window: Reproducible in staging v9.4.18-0 but not production v9.4.17-3, so it was introduced this release cycle.
Leading suspect already ruled out:Expensify/App#94204 (DEW approval, reworks AnimatedSettlementButton) is the most obvious pay-button change in the delta, but it does not explain this crash: its new logic is gated on isDEWApproval && isApprovedAnimationRunning — both false in a 1:1 DM pay flow (no policy, paid ≠ approved) — and its one new unconditional code path, the getMostRecentActiveDEWApproveFailedAction selector, is fully null-safe (ReportActionsUtils.ts:371-393). So the culprit is most likely another v9.4.18 change on the IOU-report render path.
Recommended next step (deploy blocker): Pull the Android crash group for build 9.4.18-0 from Crashlytics/Sentry (App project, Android, react-native) and read the top JS frame — that will pin the introducing PR in minutes. I couldn't query Sentry from this run (no credentials / OAuth in this environment).
Candidate render-path files changed between 9.4.17-3 and 9.4.18-0-staging
Diff scope: gh api repos/Expensify/App/compare/9.4.17-3...9.4.18-0-staging. Files on the opened-IOU-report render path worth bisecting against the stack trace:
src/components/ReportActionItem/MoneyRequestView.tsx (+38/-6) — renders the transaction inside the opened report; new useSplitEffectivePolicy / useRestrictedActionPolicyID hooks and a changed transaction derivation.
Opened report resolves a one-transaction thread to CONST.FAKE_REPORT_ID when no real thread exists (an unverified-but-plausible crash locus): ReportActionsUtils.ts:1957-1963
Next Steps for Contributor+ team: To pin & fix: grab the Android 9.4.18-0 stack trace, then reply @MelvinBot implement [this] once the introducing PR/line is confirmed. To refine:@MelvinBot <your feedback> (e.g. paste the Crashlytics/Sentry stack trace and I'll pinpoint the line). To reject: Explain why you are rejecting this analysis.
@aimane-chnaif The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Below is evidence showing that the DB issue (#94758) is reproducible in PR #94470. The issue is also reproducible in the subsequent PRs included in the deployment list #94730.
changed the title [-][Due for payment 2026-07-02] [Due for payment 2026-07-01] Android - IOU - App crashes after mark as paid and view IOU offline[/-][+][Due for payment 2026-07-06] [Due for payment 2026-07-02] [Due for payment 2026-07-01] Android - IOU - App crashes after mark as paid and view IOU offline[/+]on Jun 29, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.21-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@aimane-chnaif The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jun 24, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/6afbaba81ab0f8535197a868441a745d33e02d9063821bf321dc91a0ae49c1e0
https://platform.applause.com/services/links/v1/external/1086377157d01694ba5c675b571cc277e624fef2e925f5538b032147aa206072
melvin-bot commentedon Jun 24, 2026
Triggered auto assignment to @puneetlath (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 24, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 24, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
mitarachim commentedon Jun 24, 2026
Issue not reproduce while
Use Staging Serveris disable/OFF2026-06-24.11.44.51.AM.mp4
MelvinBot commentedon Jun 24, 2026
Issue Analysis
What we know for sure: This is a render crash, not a navigation crash. On an Android phone (small screen), tapping View on the money-request preview calls
openReportFromPreview, which navigates to the full IOU report viaROUTES.REPORT_WITH_ID—MoneyRequestReportPreviewContent.tsx. On wide layouts it instead opens the lighterEXPENSE_REPORT_RHP, which is why this reproduces on Android app but not desktop/mWeb. The crash happens while rendering that IOU report, which now contains the freshly-added optimisticPAYaction and an optimistically-settled (REIMBURSED) report from the offline mark-as-paid.Regression window: Reproducible in staging
v9.4.18-0but not productionv9.4.17-3, so it was introduced this release cycle.Leading suspect already ruled out:
Expensify/App#94204(DEW approval, reworksAnimatedSettlementButton) is the most obvious pay-button change in the delta, but it does not explain this crash: its new logic is gated onisDEWApproval && isApprovedAnimationRunning— both false in a 1:1 DM pay flow (no policy, paid ≠ approved) — and its one new unconditional code path, thegetMostRecentActiveDEWApproveFailedActionselector, is fully null-safe (ReportActionsUtils.ts:371-393). So the culprit is most likely anotherv9.4.18change on the IOU-report render path.Recommended next step (deploy blocker): Pull the Android crash group for build
9.4.18-0from Crashlytics/Sentry (App project, Android, react-native) and read the top JS frame — that will pin the introducing PR in minutes. I couldn't query Sentry from this run (no credentials / OAuth in this environment).Candidate render-path files changed between
9.4.17-3and9.4.18-0-stagingDiff scope:
gh api repos/Expensify/App/compare/9.4.17-3...9.4.18-0-staging. Files on the opened-IOU-report render path worth bisecting against the stack trace:src/components/ReportActionItem/MoneyRequestView.tsx(+38/-6) — renders the transaction inside the opened report; newuseSplitEffectivePolicy/useRestrictedActionPolicyIDhooks and a changedtransactionderivation.src/pages/inbox/report/ReportActionItem.tsx(+9/-4)src/components/SettlementButton/AnimatedSettlementButton.tsx(+53/-2) — Fix - Blocked DEW Report Approval Briefly Shows “Approved” State Before Reverting #94204 (ruled out above, but verify against the trace).src/components/MoneyReportHeaderPrimaryAction/PayPrimaryAction.tsx,.../PayActionButton.tsx— Fix - Blocked DEW Report Approval Briefly Shows “Approved” State Before Reverting #94204.Confirmed flow evidence:
openReportFromPreview:ReportPreviewActionButton.tsx:232-238REPORT_WITH_ID:MoneyRequestReportPreviewContent.tsx:516-536chatReport.iouReportID, adds PAY action, setsREIMBURSED):PayMoneyRequest.ts:292-342CONST.FAKE_REPORT_IDwhen no real thread exists (an unverified-but-plausible crash locus):ReportActionsUtils.ts:1957-1963Next Steps for Contributor+ team:
To pin & fix: grab the Android
9.4.18-0stack trace, then reply@MelvinBot implement [this]once the introducing PR/line is confirmed.To refine:
@MelvinBot <your feedback>(e.g. paste the Crashlytics/Sentry stack trace and I'll pinpoint the line).To reject: Explain why you are rejecting this analysis.
VickyStash commentedon Jun 24, 2026
Checking, as it was mentioned to be related to my PR
VickyStash commentedon Jun 24, 2026
I was able to reproduce it once on main, for me it crashed with the similar logs that are shared in the file above in this issue:
We have Sentry issue: https://expensify.sentry.io/issues/APP-3E3
And even open app issue: #93833
cc @eVoloshchak WDYT?
VickyStash commentedon Jun 24, 2026
But it also looks like reverting of #93403 helps to escape the crash in the scenario described in issue!
Maybe https://github.com/Expensify/App/pull/94095/changes will help here
21 remaining items
melvin-bot commentedon Jun 25, 2026
@aimane-chnaif The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
mitarachim commentedon Jun 27, 2026
Deploy Blocker #94758 was identified to be related to the PR #94470 that attempted to fix this issue.
VickyStash commentedon Jun 29, 2026
@mitarachim That PR is just a revert, and the DB you linked has a very different flow from this issue. Are you sure there is no mistake?
mitarachim commentedon Jun 29, 2026
Hello @VickyStash ,The reverted PR is #93403.
PR #94470 fixed issue #94402 is included in the deployment list #94730.
Below is evidence showing that the DB issue (#94758) is reproducible in PR #94470. The issue is also reproducible in the subsequent PRs included in the deployment list #94730.
2026-06-29.2.35.56.PM.mp4
melvin-bot commentedon Jun 29, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".[-][Due for payment 2026-07-02] [Due for payment 2026-07-01] Android - IOU - App crashes after mark as paid and view IOU offline[/-][+][Due for payment 2026-07-06] [Due for payment 2026-07-02] [Due for payment 2026-07-01] Android - IOU - App crashes after mark as paid and view IOU offline[/+]melvin-bot commentedon Jun 29, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.21-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-07-06. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 29, 2026
@aimane-chnaif The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]