Skip to content

[Due for payment 2026-07-06] [Due for payment 2026-07-02] [Due for payment 2026-07-01] Android - IOU - App crashes after mark as paid and view IOU offline #94402

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.4.18-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-48123/folder/13176679/41237858/1512014884?sort=%2Bidentifier
Email or phone of affected tester (no customers): leungbratt6+2406@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Pixel 7 Pro/Android 17
App Component: Chat Report View

Action Performed:

Precondition: Another user creates an IOU to the main device

  1. Open the Android app
  2. Navigate to the 1:1 DM
  3. Go offline
  4. Locate the IOU -> Mark as paid on the preview
  5. Tap on the View button on the preview

Expected Result:

App not crash

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7189236_1782266464643!log.txt

Bug7189236_1782266464644.crash.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7189236

Issue OwnerCurrent Issue Owner: @aimane-chnaif

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 24, 2026
  2. melvin-bot commented on Jun 24, 2026

    @melvin-bot

    Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jun 24, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Jun 24, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. mitarachim commented on Jun 24, 2026

    @mitarachim

    Issue not reproduce while Use Staging Server is disable/OFF

    2026-06-24.11.44.51.AM.mp4
  6. MelvinBot commented on Jun 24, 2026

    @MelvinBot
    Contributor

    ⚠️ Preliminary analysis — the user-flow and regression window are confirmed, but the exact crashing frame still needs the Android stack trace. Treat the root-cause section as the leading lead, not a settled conclusion.

    Issue Analysis

    What we know for sure: This is a render crash, not a navigation crash. On an Android phone (small screen), tapping View on the money-request preview calls openReportFromPreview, which navigates to the full IOU report via ROUTES.REPORT_WITH_ID — MoneyRequestReportPreviewContent.tsx. On wide layouts it instead opens the lighter EXPENSE_REPORT_RHP, which is why this reproduces on Android app but not desktop/mWeb. The crash happens while rendering that IOU report, which now contains the freshly-added optimistic PAY action and an optimistically-settled (REIMBURSED) report from the offline mark-as-paid.

    Regression window: Reproducible in staging v9.4.18-0 but not production v9.4.17-3, so it was introduced this release cycle.

    Leading suspect already ruled out: Expensify/App#94204 (DEW approval, reworks AnimatedSettlementButton) is the most obvious pay-button change in the delta, but it does not explain this crash: its new logic is gated on isDEWApproval && isApprovedAnimationRunning — both false in a 1:1 DM pay flow (no policy, paid ≠ approved) — and its one new unconditional code path, the getMostRecentActiveDEWApproveFailedAction selector, is fully null-safe (ReportActionsUtils.ts:371-393). So the culprit is most likely another v9.4.18 change on the IOU-report render path.

    Recommended next step (deploy blocker): Pull the Android crash group for build 9.4.18-0 from Crashlytics/Sentry (App project, Android, react-native) and read the top JS frame — that will pin the introducing PR in minutes. I couldn't query Sentry from this run (no credentials / OAuth in this environment).

    Candidate render-path files changed between 9.4.17-3 and 9.4.18-0-staging

    Diff scope: gh api repos/Expensify/App/compare/9.4.17-3...9.4.18-0-staging. Files on the opened-IOU-report render path worth bisecting against the stack trace:

    Confirmed flow evidence:


    Next Steps for Contributor+ team:
    To pin & fix: grab the Android 9.4.18-0 stack trace, then reply @MelvinBot implement [this] once the introducing PR/line is confirmed.
    To refine: @MelvinBot <your feedback> (e.g. paste the Crashlytics/Sentry stack trace and I'll pinpoint the line).
    To reject: Explain why you are rejecting this analysis.

  7. VickyStash commented on Jun 24, 2026

    @VickyStash
    Contributor

    Checking, as it was mentioned to be related to my PR

  8. VickyStash commented on Jun 24, 2026

    @VickyStash
    Contributor

    I was able to reproduce it once on main, for me it crashed with the similar logs that are shared in the file above in this issue:

    06-24 08:54:09.097 E/AndroidRuntime( 8522): FATAL EXCEPTION: main
    06-24 08:54:09.097 E/AndroidRuntime( 8522): Process: org.me.mobiexpensifyg, PID: 8522
    06-24 08:54:09.097 E/AndroidRuntime( 8522): com.facebook.react.bridge.RetryableMountingLayerException: Unable to find viewState for tag 6104. Surface stopped: false

    We have Sentry issue: https://expensify.sentry.io/issues/APP-3E3
    And even open app issue: #93833
    cc @eVoloshchak WDYT?

  9. VickyStash commented on Jun 24, 2026

    @VickyStash
    Contributor

    But it also looks like reverting of #93403 helps to escape the crash in the scenario described in issue!
    Maybe https://github.com/Expensify/App/pull/94095/changes will help here

  10. 21 remaining items

  11. melvin-bot commented on Jun 25, 2026

    @melvin-bot

    @aimane-chnaif The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  12. mitarachim commented on Jun 27, 2026

    @mitarachim

    Deploy Blocker #94758 was identified to be related to the PR #94470 that attempted to fix this issue.

  13. VickyStash commented on Jun 29, 2026

    @VickyStash
    Contributor

    @mitarachim That PR is just a revert, and the DB you linked has a very different flow from this issue. Are you sure there is no mistake?

  14. mitarachim commented on Jun 29, 2026

    @mitarachim

    Hello @VickyStash ,The reverted PR is #93403.

    PR #94470 fixed issue #94402 is included in the deployment list #94730.

    Below is evidence showing that the DB issue (#94758) is reproducible in PR #94470. The issue is also reproducible in the subsequent PRs included in the deployment list #94730.

    2026-06-29.2.35.56.PM.mp4
    Image
  15. melvin-bot commented on Jun 29, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. changed the title [-][Due for payment 2026-07-02] [Due for payment 2026-07-01] Android - IOU - App crashes after mark as paid and view IOU offline[/-] [+][Due for payment 2026-07-06] [Due for payment 2026-07-02] [Due for payment 2026-07-01] Android - IOU - App crashes after mark as paid and view IOU offline[/+] on Jun 29, 2026
  17. melvin-bot commented on Jun 29, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.21-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-06. 🎊

    For reference, here are some details about the assignees on this issue:

  18. melvin-bot commented on Jun 29, 2026

    @melvin-bot

    @aimane-chnaif The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions