Repository navigation
Fix - Blocked DEW Report Approval Briefly Shows “Approved” State Before Reverting - #94204
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0063a2a16d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Reviewing ASAP. |
|
@mountiny and @FitseTLT, just to confirm: what is supposed to happen when trying to approve while offline? In my tests, the button stays in the "loading" state indefinitely; however, when I leave the expense view and return, the button disappears. Is this intentional? Thank you. Screen.Recording.2026-06-23.at.11.55.53.mov |
yes expected and same as submit case too. |
|
Great, thanks for clarifying, @FitseTLT. One more detail: when we try to submit, an alert message appears in the preview itself, but it doesn't show up when we try to approve. Screen.Recording.2026-06-23.at.12.42.42.movIs that also expected? Thanks. |
This is out of scope @brunovjk |
|
Great, thanks for clarifying; moving on with the checklist. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp94204_android_native.movAndroid: mWeb Chrome94204_android_web.moviOS: HybridApp94204_ios_web.moviOS: mWeb Safari94204_ios_web.movMacOS: Chrome / Safari94204_web_chrome.mov |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.18-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review — no changes required I reviewed the changes in this PR against the help site articles under Why: This is a transient UI/animation bug fix. It makes the Approve button show a loading spinner while the backend validates a DEW (delayed/dynamic external workflow) approval, instead of briefly flashing the "Approved" state before reverting when the approval is blocked. The change is entirely contained to the settlement button's loading/animation behavior ( No documented behavior changes:
Since no help site changes are warranted, I did not open a draft docs PR. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.18-2 🚀
|
Explanation of Change
Fixed Issues
$ #90067
PROPOSAL: #90067 (comment)
Tests
Precondition: Have a DEW-enabled Workspace
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2026-06-22.19-33-47.mp4
Android: mWeb Chrome
2026-06-22.19-13-03.mp4
iOS: Native
2026-06-22.20-16-22.mp4
iOS: mWeb Safari
2026-06-22.19-16-18.mp4
MacOS: Chrome / Safari
2026-06-22.19-02-30.mp4