Skip to content

[Due for payment 2026-07-01] [No QA] perf: Search S4 useSearchSnapshot data layer #93940

Closed

Description

@mountiny

Problem

The Search screen was running parallel data pipelines across variants (notably the flat-expense path), duplicating the two-phase optimistic-row merge and the getSections projection. That double-pipeline meant redundant heavy work on every render and blocked the broader Search decomposition effort tracked in #92079.

Solution

Introduced useSearchSnapshot, a single data layer hook that <Search> consumes for every variant and feeds into the existing SearchList. The hook owns the full projection (both getSections stages, group sub-snapshots, sort, columns, defer gating, highlight stamping) and absorbs the two-phase optimistic-row resilience, so the screen runs the live merge and optimistic lifecycle exactly once. This is a behavior-preserving hydrated facade — identities-only projection is deferred to S5/S6.

PR

#93805

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    ReviewingHas a PR in review
    InternalRequires API changes or must be handled by Expensify staff
    on Jun 18, 2026
  2. changed the title [-][No QA] perf: Search S4 useSearchSnapshot data layer[/-] [+][Due for payment 2026-07-01] [No QA] perf: Search S4 useSearchSnapshot data layer[/+] on Jun 24, 2026
  3. melvin-bot commented on Jun 24, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  4. melvin-bot commented on Jun 24, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.18-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-01. 🎊

    For reference, here are some details about the assignees on this issue:

  5. melvin-bot commented on Jun 29, 2026

    @melvin-bot

    @FitseTLT Huh... This is 4 days overdue. Who can take care of this?

  6. melvin-bot commented on Jun 30, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  7. melvin-bot commented on Jun 30, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  8. mallenexpensify commented on Jul 2, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @FitseTLT due $250 via NewDot

  9. flaviadefaria commented on Jul 31, 2026

    @flaviadefaria
    Contributor

    Approved: @FitseTLT due $250 via NewDot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2InternalRequires API changes or must be handled by Expensify staffTask

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions