Repository navigation
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@FitseTLT Can you review? Thanks! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-06-22.19-44-25.mp4Android: mWeb Chrome2026-06-22.17-04-11.mp4iOS: HybridApp2026-06-22.20-22-38.mp4iOS: mWeb Safari2026-06-22.17-06-44.mp4MacOS: Chrome / Safari2026-06-22.16-59-32.mp4 |
2026-06-19.16-13-26.mp4 |
|
just updated the docs fyi, the bug you mean you can't create track distance? @FitseTLT |
It is crasing when u create an expense while on spend page. It is not happening on main. |
|
Thanks I could reproduce that, looking into that |
|
PR doesn’t need product input as a perf PR. Unassigning and unsubscribing myself. |
|
@FitseTLT I resolved the problem, can be rerevied Screen.Recording.2026-06-22.at.11.14.33.mov |
| allDataLength: number; | ||
| hasDeletedTransaction: boolean; | ||
| }>(() => { | ||
| if (!shouldComputeSections || !searchDataWithOptimisticTransaction) { |
There was a problem hiding this comment.
searchDataWithOptimisticTransaction is redundant
There was a problem hiding this comment.
Good catch, removed — shouldComputeSections already includes the !!searchDataWithOptimisticTransaction check.
| const groupByTransactionSnapshots = useMultipleSnapshots(groupByTransactionHashes); | ||
|
|
||
| const filteredData = useMemo<SearchData>(() => { | ||
| if (!validGroupBy || isExpenseReportType) { |
There was a problem hiding this comment.
It would be better to add shouldDeferHeavySearchWork to be clear though I know in that case baseFilteredData is already empty. WDYT
There was a problem hiding this comment.
shouldComputeSections already includes !shouldDeferHeavySearchWork (it's the first term in its definition), so this guard already short-circuits while deferring — adding it explicitly would just duplicate that. Happy to add the explicit form if you'd still prefer it for readability.
… useSearchSnapshot
|
@FitseTLT updated |
|
Conflicts @BartekObudzinski |
…t-data-layer # Conflicts: # src/components/Search/index.tsx
|
@FitseTLT done |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.18-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 No help site changes required. I reviewed the changes in this PR against the help site content under Why no docs update is needed: This is a purely internal, behavior-preserving performance refactor of the Search screen's data layer. The diff:
There are no user-facing changes — no new or renamed features, tabs, settings labels, or buttons, and no change in product behavior (the PR is labeled No draft PR was created since no |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.18-2 🚀
|
Explanation of Change
`` now consumes a single
useSearchSnapshot(...)for every variant and feeds the existing `SearchList`. The hook owns the entire projection (both `getSections` stages, group sub-snapshots, sort, columns, defer gating, highlight stamping) and absorbs the two-phase optimistic-row resilience, so the screen runs the live merge and the optimistic lifecycle exactly once. This removes the parallel double-pipeline (and the duplicated optimistic lifecycle on the flat-expense path) that the earlier S4+S5 draft carried.Behavior-preserving.
useSearchSnapshotis a hydrated facade for now:datais the fully sorted + joined rows thatSearchListstill reads display fields off. Identities-only is deferred to S5/S6, once the rows self-hydrate.searchResultsand the highlight keys are passed in transitionally (the snapshot subscription moves into the hook in S6).Fixed Issues
$ #93940
PROPOSAL:
Tests
Offline tests
QA Steps
No QA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari