Skip to content

[CDA] Add intl' deposit account collection #96081

Closed
2 of 2 issues completed
Closed

Description

@arosiclair

Part of Collect Deposit Accounts in NewDot

Main issue: https://github.com/Expensify/Expensify/issues/594776
Doc section: https://docs.google.com/document/d/1qmjliYT6Ce2lASacicvFqlvyFkihLd1wdYs5tGOmylE/edit?tab=t.0#heading=h.eyfekrfbf6c2

Feature Description

When a policy has a set of reimbursement countries configured and an employee sets up a bank account for a country outside of their policy’s list of countries, admins need international bank account details so they can process transfers.

In NewDot, the PBA setup flow uses Corpay’s Beneficiary Rules API to determine which bank account details are needed to connect a bank in the user’s selected country. This means the bank account fields we request in the PBA flow are dynamic and may be a combination of local account number, IBAN, routing or SWIFT/BIC codes.

We’ll create a new InternationalBankAccountDetails page that displays after ManualBankAccountDetailsStep in the USD PBA flow and after BankAccountDetails in the international PBA flow

  • Two inputs for IBAN and Swift code
    • IBAN regex: ^[a-zA-Z]{2}[0-9]{2}[a-zA-Z0-9]{4}[0-9]{7}([a-zA-Z0-9]?){0,16}$
    • Swift code regex: ^.{1,12}$
    • Error message: Please enter a valid Swift code/IBAN
    • For testing purposes, we should allow these hardcoded values
      • IBAN: ${countryCode}123456789012345678
      • Swift code: XXXX${countryCode}XX
  • Displays only when the following conditions are true otherwise it will be skipped
    • Selected country is not in one of the policy’s reimbursement countries (policy.reimbursement.countries)
    • Draft account number is not an IBAN OR draft SWIFT/BIC code is not set
      • Draft values are in Onyx keys PERSONAL_BANK_ACCOUNT_FORM_DRAFT or INTERNATIONAL_BANK_ACCOUNT_FORM_DRAFT
  • When the flow is completed, we’ll pass iban and swiftCode parameters to the appropriate API command

Manual Test Steps

USD - Manual - International details step shown

  1. As an admin, enable Payments and do NOT setup a bank account
  2. Enable Collect employee bank details
  3. Add Austria as a business bank account country
  4. As the member, go to Settings > Wallet > Add bank account
  5. Select United States
  6. Select Connect manually
  7. Enter local US bank account details
  8. Verify
    1. A new International bank account details step is shown after the initial details step
    2. The step has two required inputs: IBAN and SWIFT/BIC code
  9. Enter a valid IBAN and SWIFT/BIC code and continue
    1. IBAN: US123456789012345678
    2. Swift code: XXXXUSXX
  10. Verify the rest of the flow can be completed successfully

USD - Plaid - International details step shown

  1. As an admin, enable Payments and do NOT setup a bank account
  2. Enable Collect employee bank details
  3. Add Austria as a business bank account country
  4. As the member, go to Settings > Wallet > Add bank account
  5. Select United States
  6. Select Log into your bank
  7. Log into Regions bank
    1. Username: user_good
    2. Password: pass_good
  8. Select the savings account
  9. Verify
    1. A new International bank account details step is shown after selecting the savings account
    2. The step has two required inputs: IBAN and SWIFT/BIC code
  10. Enter a valid IBAN and SWIFT/BIC code and continue
    1. IBAN: US123456789012345678
    2. Swift code: XXXXUSXX
  11. Verify the rest of the flow can be completed successfully

Intl’ - Manual - International details step shown

  1. As an admin, enable Payments and do NOT setup a bank account
  2. Enable Collect employee bank details
  3. Add Belgium as a business bank account country
  4. As the member, go to Settings > Wallet > Add bank account
  5. Select Austria
  6. Enter details:
    • IBAN: AT123456789012345678
    • Leave others empty
  7. Continue
  8. Verify
    • The International bank account details step is shown
    • The IBAN field is pre-filled with the value entered in the initial step
    • The SWIFT/BIC code field is empty
  9. Enter XXXXATXX for Swift code
  10. Continue
  11. Verify the rest of the flow can be completed successfully

Intl’ - Manual - International details step skipped

  1. As an admin, enable Payments and do NOT setup a bank account
  2. Enable Collect employee bank details
  3. Add Austria as a business bank account country
  4. As the member, go to Settings > Wallet > Add bank account
  5. Select Austria
  6. Enter details:
    • IBAN: AT123456789012345678
    • Leave others empty
  7. Continue
  8. Verify
    • The International bank account details step is NOT shown
    • The rest of the flow can be completed successfully and the personal bank account is added

Automated Tests

We’ll add tests for the Collect employee bank details toggle to verify it’s enabled when extra reimbursement countries are present.

Issue OwnerCurrent Issue Owner: @bernhardoj

Activity

  1. self-assigned this
    on Jul 14, 2026
  2. dukenv0307 commented on Jul 24, 2026

    @dukenv0307
    Contributor

    Hi @arosiclair @trjExpensify @bernhardoj, while working on the FE PR, I realized something redundant

    1. For some countries, the accountNumber is IBAN (most of Europe)

    We have a SWIFT code input in What are your account details? page

    Image

    In Intl’ - Manual - International details step shown section, if we leave the SWIFT code empty (optional), we'll show the International bank account details page -> IBAN + SWIFT code (required) are shown again

    Do you think we should mitigate the duplication here? And make the SWIFT code optional?

    We can do that by removing International bank account details page if the SWIFT code and IBAN are already in the previous page

    1. For some countries, the accountNumber and IBAN are separate

    The SWIFT code is duplicated in 2 screens -> I think we also need to fix?

  3. dukenv0307 commented on Jul 27, 2026

    @dukenv0307
    Contributor

    Still waiting for @arosiclair confirmation

  4. arosiclair commented on Jul 27, 2026

    @arosiclair
    ContributorAuthor

    Yeah the IBAN and Swift entry should be handled like we described in the doc. We can skip the step if the necessary info was already entered.

  5. arosiclair commented on Jul 27, 2026

    @arosiclair
    ContributorAuthor

    Not overdue

  6. dukenv0307 commented on Jul 28, 2026

    @dukenv0307
    Contributor

    @arosiclair yep but if users leave the SWIFT code empty in

    Image

    Should we still show iban + swift code in the International bank account details page (we already show iban + swift code in the account details page)?

    Intl’ - Manual - International details step shown
    As an admin, enable Payments and do NOT setup a bank account
    Enable Collect employee bank details
    Add Belgium as a business bank account country
    As the member, go to Settings > Wallet > Add bank account
    Select Austria
    Enter details:
    IBAN: AT123456789012345678
    Leave others empty
    Continue
    Verify
    The International bank account details step is shown
    The IBAN field is pre-filled with the value entered in the initial step
    The SWIFT/BIC code field is empty
    Enter XXXXATXX for Swift code
    Continue
    Verify the rest of the flow can be completed successfully

  7. arosiclair commented on Jul 28, 2026

    @arosiclair
    ContributorAuthor

    Yup we would still show the international details page in that case (with the IBAN they entered pre-filled) since they haven't entered the swift code yet.

  8. 76 remaining items

  9. dukenv0307 commented on Oct 12, 2026

    @dukenv0307
    Contributor

    Not overdue

  10. arosiclair commented on Oct 12, 2026

    @arosiclair
    ContributorAuthor

    We're working on cleanup in #103423

  11. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    @bernhardoj Eep! 4 days overdue now. Issues have feelings too...

  12. melvin-bot commented on Oct 15, 2026

    @melvin-bot

    @bernhardoj 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  13. arosiclair commented on Oct 16, 2026

    @arosiclair
    ContributorAuthor

    We need a review from @bernhardoj on #103902

  14. melvin-bot commented on Oct 19, 2026

    @melvin-bot

    @bernhardoj 10 days overdue. Is anyone even seeing these? Hello?

  15. arosiclair commented on Oct 20, 2026

    @arosiclair
    ContributorAuthor

    Just merged #103902

  16. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    @bernhardoj

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.15-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

  17. arosiclair commented on Oct 21, 2026

    @arosiclair
    ContributorAuthor

    All done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions