Repository navigation
Description
Part of Collect Deposit Accounts in NewDot
Main issue: https://github.com/Expensify/Expensify/issues/594776
Doc section: https://docs.google.com/document/d/1qmjliYT6Ce2lASacicvFqlvyFkihLd1wdYs5tGOmylE/edit?tab=t.0#heading=h.eyfekrfbf6c2
Feature Description
When a policy has a set of reimbursement countries configured and an employee sets up a bank account for a country outside of their policy’s list of countries, admins need international bank account details so they can process transfers.
In NewDot, the PBA setup flow uses Corpay’s Beneficiary Rules API to determine which bank account details are needed to connect a bank in the user’s selected country. This means the bank account fields we request in the PBA flow are dynamic and may be a combination of local account number, IBAN, routing or SWIFT/BIC codes.
We’ll create a new InternationalBankAccountDetails page that displays after ManualBankAccountDetailsStep in the USD PBA flow and after BankAccountDetails in the international PBA flow
- Two inputs for IBAN and Swift code
- IBAN regex:
^[a-zA-Z]{2}[0-9]{2}[a-zA-Z0-9]{4}[0-9]{7}([a-zA-Z0-9]?){0,16}$ - Swift code regex:
^.{1,12}$ - Error message: Please enter a valid Swift code/IBAN
- For testing purposes, we should allow these hardcoded values
- IBAN: ${countryCode}123456789012345678
- Swift code: XXXX${countryCode}XX
- IBAN regex:
- Displays only when the following conditions are true otherwise it will be skipped
- Selected country is not in one of the policy’s reimbursement countries (
policy.reimbursement.countries) - Draft account number is not an IBAN OR draft SWIFT/BIC code is not set
- Draft values are in Onyx keys
PERSONAL_BANK_ACCOUNT_FORM_DRAFTorINTERNATIONAL_BANK_ACCOUNT_FORM_DRAFT
- Draft values are in Onyx keys
- Selected country is not in one of the policy’s reimbursement countries (
- When the flow is completed, we’ll pass iban and swiftCode parameters to the appropriate API command
- USD flow:
addPersonalBankAccountaction - Intl’ flow:
createCorpayBankAccountForWalletFlowaction
- USD flow:
Manual Test Steps
USD - Manual - International details step shown
- As an admin, enable Payments and do NOT setup a bank account
- Enable Collect employee bank details
- Add Austria as a business bank account country
- As the member, go to Settings > Wallet > Add bank account
- Select United States
- Select Connect manually
- Enter local US bank account details
- Verify
- A new International bank account details step is shown after the initial details step
- The step has two required inputs: IBAN and SWIFT/BIC code
- Enter a valid IBAN and SWIFT/BIC code and continue
- IBAN: US123456789012345678
- Swift code: XXXXUSXX
- Verify the rest of the flow can be completed successfully
USD - Plaid - International details step shown
- As an admin, enable Payments and do NOT setup a bank account
- Enable Collect employee bank details
- Add Austria as a business bank account country
- As the member, go to Settings > Wallet > Add bank account
- Select United States
- Select Log into your bank
- Log into Regions bank
- Username: user_good
- Password: pass_good
- Select the savings account
- Verify
- A new International bank account details step is shown after selecting the savings account
- The step has two required inputs: IBAN and SWIFT/BIC code
- Enter a valid IBAN and SWIFT/BIC code and continue
- IBAN: US123456789012345678
- Swift code: XXXXUSXX
- Verify the rest of the flow can be completed successfully
Intl’ - Manual - International details step shown
- As an admin, enable Payments and do NOT setup a bank account
- Enable Collect employee bank details
- Add Belgium as a business bank account country
- As the member, go to Settings > Wallet > Add bank account
- Select Austria
- Enter details:
- IBAN: AT123456789012345678
- Leave others empty
- Continue
- Verify
- The International bank account details step is shown
- The IBAN field is pre-filled with the value entered in the initial step
- The SWIFT/BIC code field is empty
- Enter XXXXATXX for Swift code
- Continue
- Verify the rest of the flow can be completed successfully
Intl’ - Manual - International details step skipped
- As an admin, enable Payments and do NOT setup a bank account
- Enable Collect employee bank details
- Add Austria as a business bank account country
- As the member, go to Settings > Wallet > Add bank account
- Select Austria
- Enter details:
- IBAN: AT123456789012345678
- Leave others empty
- Continue
- Verify
- The International bank account details step is NOT shown
- The rest of the flow can be completed successfully and the personal bank account is added
Automated Tests
We’ll add tests for the Collect employee bank details toggle to verify it’s enabled when extra reimbursement countries are present.
Issue Owner
Current Issue Owner: @bernhardojMetadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
dukenv0307 commentedon Jul 24, 2026
Hi @arosiclair @trjExpensify @bernhardoj, while working on the FE PR, I realized something redundant
We have a SWIFT code input in
What are your account details?pageIn
Intl’ - Manual - International details step shownsection, if we leave the SWIFT code empty (optional), we'll show theInternational bank account detailspage -> IBAN + SWIFT code (required) are shown againDo you think we should mitigate the duplication here? And make the SWIFT code optional?
We can do that by removing
International bank account detailspage if the SWIFT code and IBAN are already in the previous pageThe SWIFT code is duplicated in 2 screens -> I think we also need to fix?
dukenv0307 commentedon Jul 27, 2026
Still waiting for @arosiclair confirmation
arosiclair commentedon Jul 27, 2026
Yeah the IBAN and Swift entry should be handled like we described in the doc. We can skip the step if the necessary info was already entered.
arosiclair commentedon Jul 27, 2026
Not overdue
dukenv0307 commentedon Jul 28, 2026
@arosiclair yep but if users leave the SWIFT code empty in
Should we still show iban + swift code in the
International bank account detailspage (we already show iban + swift code in the account details page)?arosiclair commentedon Jul 28, 2026
Yup we would still show the international details page in that case (with the IBAN they entered pre-filled) since they haven't entered the swift code yet.
76 remaining items
dukenv0307 commentedon Oct 12, 2026
Not overdue
arosiclair commentedon Oct 12, 2026
We're working on cleanup in #103423
melvin-bot commentedon Oct 13, 2026
@bernhardoj Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Oct 15, 2026
@bernhardoj 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
arosiclair commentedon Oct 16, 2026
We need a review from @bernhardoj on #103902
melvin-bot commentedon Oct 19, 2026
@bernhardoj 10 days overdue. Is anyone even seeing these? Hello?
arosiclair commentedon Oct 20, 2026
Just merged #103902
melvin-bot commentedon Oct 21, 2026
@bernhardoj
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.15-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
arosiclair commentedon Oct 21, 2026
All done