Repository navigation
Surface verification error in Collect Deposit Account flow - #103902
arosiclair merged 7 commits into
Conversation
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
garrettmknight
left a comment
There was a problem hiding this comment.
Looks good from a product perspective.
|
@bernhardoj all yours! |
|
@bernhardoj could you please take a look? It's pretty simple |
|
@dukenv0307 Sorry, I was travelling. I'm back now. I get this error instead.
|
| key: ONYXKEYS.PERSONAL_BANK_ACCOUNT, | ||
| value: {errors: getMicroSecondOnyxErrorWithTranslationKey('walletPage.addBankAccountFailure')}, | ||
| // Key at 0 so a verification error from the API (keyed by timestamp) sorts above it and getLatestError shows that instead. | ||
| value: {errors: getMicroSecondOnyxErrorWithTranslationKey('walletPage.addBankAccountFailure', 0)}, |
There was a problem hiding this comment.
Also, we don't need to hardcode this to 0. We use the current timestamp as the key and the failure data will always have a smaller key than the one from the BE.
|
@bernhardoj can you share the whole screen? I can't reproduce Screen.Recording.2026-10-19.at.08.52.36.mov |
|
@dukenv0307 here is the video a.mp4 |
|
@bernhardoj I still can't reproduce it on staging. ANW, I think we're good to change the expectation to Screen.Recording.2026-10-19.at.17.03.01.mov |
|
Yes, sounds good |
|
@bernhardoj checklist |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safaria.mp4 |
|
@arosiclair posted the checklist above |
|
🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.5.15-1 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
Surface GIACT verification error in Collect Deposit Account flow to avoid duplication
Fixed Issues
$ #103423
$ #96081
PROPOSAL:
Tests
Preconditions:
Admin invite a member to workspace. Member should not be admin of any ws
Admin go to OD: Workspace > Workflows > Enable 'Collect bank account details' and select United States only
Log in as member to test
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-10-13.at.21.16.54.mov