Repository navigation
Show the server bank verification error over the generic fallback in Collect deposit account - #105122
Conversation
…the Collect deposit account flow Key the generic addBankAccountFailure error in createCollectOnlyDepositAccount failureData at 0, so a server-sent error always sorts newer even when the device clock runs ahead of the server. Co-authored-by: huult <huult@users.noreply.github.com>
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
|
🤖 Android test steps verification results: ❌ fail The PR has no written test steps, so I ran the repro steps from the linked issue with the fix applied. The test user reached Home, but both bank account entry points stopped at a "Validate your account" screen that needs a code emailed to the test inbox, so the "Check your info" warning was never reached.
|
|
@MelvinBot Please update the test steps and QA steps to match the format used in #104723. |
|
I updated the Tests and QA Steps sections in the PR description. They now use the same format as [$175] Android - Unexpected error text appears instead of Review text when connect BA: a "Precondition:" list followed by a "Steps:" list.
I kept the "Verify that no errors appear in the JS console" checkbox in both sections and removed the TODO placeholders. Please check the steps match what you ran before you mark the PR ready for review. |
|
@MelvinBot ready for review |
|
🤖 I marked this PR as ready for review. Before a reviewer picks it up, please fill out the |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-10-27.at.21.52.19.movAndroid: mWeb ChromeScreen.Recording.2026-10-27.at.21.54.42.moviOS: HybridAppScreen.Recording.2026-10-27.at.21.59.47.moviOS: mWeb SafariScreen.Recording.2026-10-27.at.22.01.45.movMacOS: Chrome / SafariScreen.Recording.2026-10-27.at.21.45.22.mov |
|
@MelvinBot I verified the PR: #105122 (comment). Please check off all the boxes in the author checklist. |
|
🤖 I checked off all 36 boxes in the PR Author Checklist. I didn't change anything else in the PR body. The "Verify that no errors appear in the JS console" boxes under Tests and QA Steps are still unchecked, and the Screenshots/Videos sections are still empty. |
|
I think the project team should have eyes on this as it's in active development. @arosiclair @dukenv0307 @bernhardoj. |
|
@huult Actually, we decided to remove it in #103902 (comment). Why does this issue only occur on Android? |
@dukenv0307 This isn't Android-specific. It happens whenever the device clock is ahead of the server clock. There are two ways to get there:
In both cases the device-stamped fallback key outranks the BE key, since getLatestError takes the highest key. So keying the fallback at 0 makes sense here, and it's the same pattern addPersonalBankAccount and PayMoneyRequest already use. |
trjExpensify
left a comment
There was a problem hiding this comment.
Team happy, I'm happy.
|
🚧 madmax330 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.5.25-0 🚀
|
|
No help site update is needed. This bug fix only changes which in-app error message appears when a bank account check fails, so no help article sentence becomes incorrect. |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.25-2 🚀
Bundle Size Analysis (Sentry): |







Explanation of Change
When the bank check fails on the Collect deposit account "Check your info" page,
PERSONAL_BANK_ACCOUNT.errorsgets two entries: the server's specific "Please review your account number…" error (keyed by the server clock) and the genericwalletPage.addBankAccountFailurefallback fromfailureData(keyed by the device clock). The Confirm page shows onlygetLatestError(...), so when the device clock runs ahead of the server, the generic error wins.This PR keys the generic fallback in
createCollectOnlyDepositAccountat0, matching whataddPersonalBankAccountalready does in the same file. A server-sent error now always sorts newer. The generic text still shows when the server sends no error.It also adds a unit test that applies a server error, then the
failureDatastamped with a device clock far ahead of the server, and checks that the server message still wins. The test fails without the fix.Fixed Issues
$ #104723
PROPOSAL: #104723 (comment)
Tests
Precondition:
Steps:
Offline tests
QA Steps
Precondition:
Steps:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari