Skip to content

[Due for payment 2026-07-29] [$250] Explain inline link missing on integration sync failure (INTEGRATION_SYNC_FAILED) messages #96422

Closed

Description

@melvin-bot

Problem

Export/sync failure system messages (e.g. failed to export this report to NetSuite ("NS0196 Sync Error: …")) show the right-click "Explain" option but not the inline "Explain" link on hover. Since most users discover Explain via the inline link rather than the context menu, this affordance is effectively hidden for these messages even though the reasoning payload is present.

Root cause

The two affordances are gated differently:

  • Right-click "Explain" — ContextMenuActions.tsx gates the entry solely on hasReasoning(reportAction) with no per-type whitelist, so it fires for any action carrying a reasoning payload.
  • Inline "Explain" link — only renders when the action's render component explicitly wraps its message in <ReportActionItemMessageWithExplain> (e.g. ExportIntegration for the success path EXPORTED_TO_INTEGRATION).

The failure path routes to IntegrationSyncFailedMessage.tsx, which renders plain muted text via ReportActionItemBasicMessage + RenderHTML with no ReportActionItemMessageWithExplain wrapper and no hasReasoning check:

return (
    <ReportActionItemBasicMessage message="">
        <RenderHTML html={`<comment><muted-text>${getIntegrationSyncFailedMessage(translate, action, policyID, isTryNewDotNVPDismissed)}</muted-text></comment>`} />
    </ReportActionItemBasicMessage>
);

This is not a regression — the failure/sync path was never whitelisted for the inline affordance. The 2026-04-29 auto-export commit (281da4f7) only wired the inline Explain into ExportIntegration (the success path).

Proposed fix

In IntegrationSyncFailedMessage.tsx, wrap the message in ReportActionItemMessageWithExplain when hasReasoning(action) is true (mirroring ExportIntegration.tsx), falling back to the current ReportActionItemBasicMessage / RenderHTML rendering when there's no reasoning. This turns on the inline Explain link for NetSuite/QBO sync-failure messages so users get it as a first-class hover action.

Relevant files

Reported in Slack.

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. marcaaron commented on Jul 17, 2026

    @marcaaron
    Contributor

    @MelvinBot please implement this.

  2. MelvinBot commented on Jul 17, 2026

    @MelvinBot
    Contributor

    🤖 Draft PR created: #96424

    What it does: Makes IntegrationSyncFailedMessage.tsx mirror ExportIntegration.tsx — when hasReasoning(action) is true it wraps the message in ReportActionItemMessageWithExplain (which renders the inline "Explain" link and wires up the explain handler), and otherwise falls back to the existing muted-text rendering. ActionContentRouter.tsx now passes originalReport through so the handler has the report context it needs.

    Validation
    • npm run lint-changed — passed
    • npm run typecheck-tsgo — passed
    • npm run react-compiler-compliance-check check <changed files> — passed
    • Jest could not be run in this environment. The existing INTEGRATION_SYNC_FAILED UI test in tests/ui/ReportActionItemTest.tsx exercises the no-reasoning path, which is unchanged (still renders via ReportActionItemBasicMessage), so it remains valid.

    Please add manual Tests/QA steps and mark it Ready for review when it's ready — PullerBear will then assign the reviewer.

  3. changed the title [-]Explain inline link missing on integration sync failure (`INTEGRATION_SYNC_FAILED`) messages[/-] [+][$250] Explain inline link missing on integration sync failure (`INTEGRATION_SYNC_FAILED`) messages[/+] on Jul 19, 2026
  4. melvin-bot commented on Jul 19, 2026

    @melvin-bot
    Author
  5. marcaaron commented on Jul 20, 2026

    @marcaaron
    Contributor

    PR is in review now.

  6. 12 remaining items

  7. melvin-bot commented on Jul 28, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  8. melvin-bot commented on Jul 28, 2026

    @melvin-bot
    Author

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/2078800561878973179/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  9. mallenexpensify commented on Jul 30, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @mkhutornyi due $250 via NewDot

    ^ Test case created. Thx

  10. trjExpensify commented on Aug 3, 2026

    @trjExpensify
    Contributor

    approved $250 for @mkhutornyi

  11. added and removed on Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions