Skip to content

Show inline Explain link on integration sync failure messages - #96424

Merged
yuwenmemon merged 2 commits into
mainfrom
claude-explainInlineOnSyncFailed
Jul 20, 2026
Merged

yuwenmemon merged 2 commits into
mainfrom
claude-explainInlineOnSyncFailed

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Export/sync failure system messages (e.g. failed to export this report to NetSuite ("NS0196 Sync Error: …")) exposed the right-click "Explain" option but not the inline "Explain" link on hover. The right-click entry is gated on hasReasoning(reportAction), while the inline link only renders when the action's render component wraps its message in ReportActionItemMessageWithExplain. The INTEGRATION_SYNC_FAILED failure path routed through IntegrationSyncFailedMessage.tsx, which rendered plain muted text via ReportActionItemBasicMessage + RenderHTML and was never wired up for the inline affordance (only the success path ExportIntegration was, in commit 281da4f7).

This change makes IntegrationSyncFailedMessage mirror ExportIntegration: when hasReasoning(action) is true it wraps the message in ReportActionItemMessageWithExplain (which appends the inline "Explain" link and wires up the explain handler), and otherwise falls back to the existing ReportActionItemBasicMessage / RenderHTML rendering. ActionContentRouter now passes originalReport through so the explain handler has the report context it needs. Net effect: NetSuite/QBO sync-failure messages that carry a reasoning payload now show the inline "Explain" link on hover as a first-class action, matching the export success path.

Fixed Issues

$ #96422
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

No QA

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Marc Glasser <marcaaron@users.noreply.github.com>
@codecov

codecov Bot commented Jul 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...nbox/report/actionContents/ActionContentRouter.tsx 93.63% <ø> (ø)
...rt/actionContents/IntegrationSyncFailedMessage.tsx 91.66% <85.71%> (-8.34%) ⬇️
... and 21 files with indirect coverage changes

@MelvinBot

Copy link
Copy Markdown
Contributor Author

All of the code checks are now green — no code fix was needed, so I didn't push anything.

When you filed this request, the JS checks (ESLint, typecheck, tests, perf) were still queued/pending rather than failed. They've since all completed and passed:

  • ✅ ESLint check, typecheck, Oxfmt, React Compiler Compliance
  • ✅ test (jobs 1–8), Bun tests, Storybook tests
  • ✅ baseline/branch/validate perf-tests
  • ✅ all builds, spellcheck, knip, unused styles, codecov

The only remaining ❌ is checklist — the PR Author Checklist (You completed 0 out of 38 checklist items). That's not a code failure and I can't fix it by pushing: it just needs the author checklist boxes in the PR description ticked. Once you fill those out it'll go green.

@marcaaron
marcaaron marked this pull request as ready for review July 18, 2026 01:50
@marcaaron
marcaaron requested a review from a team as a code owner July 18, 2026 01:50
@melvin-bot
melvin-bot Bot requested review from mkhutornyi and trjExpensify and removed request for a team July 18, 2026 01:50
@melvin-bot

melvin-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed request for a team and trjExpensify July 18, 2026 01:50
@mkhutornyi

mkhutornyi commented Jul 18, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android.mov
Android: mWeb Chrome
iOS: HybridApp
ios.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
before.mov
web.mov

Test data:

            const mockSyncFailedAction = {
                reportActionID: '1234567890123456789',
                actionName: CONST.REPORT.ACTIONS.TYPE.INTEGRATION_SYNC_FAILED,
                actorAccountID: CONST.ACCOUNT_ID.CONCIERGE,
                created: '2026-07-19 12:00:00.000',
                childReportID: '9876543210987654321', // drives the childReport useOnyx subscription
                message: [
                    {
                        type: 'COMMENT',
                        html: '<muted-text>failed to export this report to NetSuite ("NS0196 Sync Error: ...")</muted-text>',
                        text: 'failed to export this report to NetSuite ("NS0196 Sync Error: ...")',
                    },
                ],
                originalMessage: {
                    label: 'NetSuite',
                    source: 'newExpensify',
                    errorMessage: 'NS0196 Sync Error: Invalid subsidiary reference key.',
                    recurrenceCount: 1,
                    // hasReasoning() checks: `'reasoning' in originalMessage && !!originalMessage.reasoning`
                    reasoning: 'The export failed because the NetSuite subsidiary mapping is missing for this workspace.',
                },
            };

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Review

Looks good. The change faithfully mirrors the export-success path (ExportIntegration.tsx:38-48) onto the sync-failure path: gate on hasReasoning(action), wrap in ReportActionItemMessageWithExplain when true, else fall back to the existing ReportActionItemBasicMessage / RenderHTML rendering. The premise checks out — the right-click "Explain" entry is gated on the same generic hasReasoning(reportAction), so any sync-failure action carrying a reasoning payload previously got the right-click option but not the inline link.

Details I verified
  • originalReport is in scope in ActionContentRouter — it's already threaded into ExportIntegration a few lines above the INTEGRATION_SYNC_FAILED branch, so passing it through is safe.
  • message wrapping is consistent. getIntegrationSyncFailedMessage returns the inner content (unwrapped); ReportActionItemMessageWithExplain wraps it in <comment><muted-text>…</muted-text></comment> itself (ReportActionItemMessageWithExplain.tsx:59-88), matching the original fallback wrapping. No double-wrapping.
  • Hoisting message to a single const removes the duplicated getIntegrationSyncFailedMessage(...) call — good cleanup.
  • hasReasoning typechecks fine — it's a runtime 'reasoning' in originalMessage check, so it works even though OriginalMessageIntegrationSyncFailed doesn't declare a reasoning field.

Two small things worth confirming before merge:

  1. Runtime reasoning payload. OriginalMessageIntegrationSyncFailed (OriginalMessage.ts:1461) has no reasoning field, so the new branch only ever executes if the backend actually sets reasoning on these actions. Since right-click "Explain" already relies on the same condition, this should hold — but the inline link is a no-op unless a real sync-failure action with reasoning is used to test it. Please capture a screenshot of the inline "Explain" link on hover for such a message rather than only the JS-console check.

  2. Tests. No unit test was added and the Tests/QA sections are still the placeholder TODO. Since the behavior branches on hasReasoning, a small test asserting the ReportActionItemMessageWithExplain path renders when the action carries reasoning (and the basic path otherwise) would lock in the fix and match the checklist item on adding regression tests.

No blocking concerns on the code itself.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 972b02d80c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

if (hasReasoning(action)) {
return (
<ReportActionItemMessageWithExplain
message={message}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Badge Strip the sync failure period before appending Explain

When an INTEGRATION_SYNC_FAILED action includes reasoning, this passes the sync-failure HTML directly into ReportActionItemMessageWithExplain. That translation already ends with a period (...workspace settings</a>., and recurrence adds another sentence), while iou.AskToExplain begins with . , so the rendered message becomes settings.. Explain or (Repeated 2 times.). Explain; strip the trailing period in this branch before appending the Explain link, as the receipt-scan-failed path does.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — done in 5a57f32.

The integrationSyncFailed translation ends with workspace settings</a>. and iou.AskToExplain begins with . , so the combined string rendered settings.. Explain. I now strip the trailing period in the hasReasoning branch, mirroring the receipt-scan-failed path:

message={message.replace(/\.\s*$/, '')}

See IntegrationSyncFailedMessage.tsx:34-41.

typecheck, lint-changed, and the React Compiler compliance check all pass.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The only failing checks are PR Author Checklist and PR Reviewer Checklist — there's no code fix to push here. Every real CI check (tests, typecheck, ESLint, Oxfmt, build, perf, storybook, etc.) is passing.

Both checklist checks fail simply because their checkboxes aren't completed yet:

  • PR Author Checklist → the author checklist boxes in the PR description are unchecked. Complete them (and fill in the Tests/QA Steps sections, or add [No QA] to the title) to make it pass.
  • PR Reviewer Checklist → this only turns green once a reviewer runs through and completes the reviewer checklist.

Nothing to commit — these clear once the checklists are filled out.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Still nothing to push here — the only two failing checks are the PR Author Checklist and PR Reviewer Checklist. All real CI checks (tests, typecheck, ESLint, Oxfmt, builds, perf, storybook, etc.) are green.

These two aren't code failures, so there's no fix I can commit:

  • PR Author Checklist turns green once the author checklist boxes are ticked and the Tests/QA Steps sections are filled in (or [No QA] is added to the title).
  • PR Reviewer Checklist turns green once a reviewer completes the reviewer checklist.

No code change is required to clear these.

@MelvinBot
MelvinBot requested a review from a team as a code owner July 19, 2026 11:07
@melvin-bot
melvin-bot Bot requested review from marcaaron and thelullabyy and removed request for a team July 19, 2026 11:07
@melvin-bot

melvin-bot Bot commented Jul 19, 2026

Copy link
Copy Markdown

@thelullabyy @marcaaron One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Regression check

One concrete cosmetic regression, plus one interaction change worth verifying on device. No functional/navigation regressions found.

🐞 Double period before the inline "Explain" link

ReportActionItemMessageWithExplain builds the inline text as `${message}${translate('iou.AskToExplain')}` (ReportActionItemMessageWithExplain.tsx:59), and AskToExplain is `. <a …>Explain<sparkles-icon/></a>` — it prepends its own ". " (en.ts:1810).

That suffix was designed for the export messages, which do not end in a period (e.g. exported to NetSuite, failed to export this report to X (…)). But the sync-failed message already ends in a period: …Please fix the issue in <a>workspace settings</a>. (en.ts:9204).

So a reasoning-bearing sync-failure now renders:

…fix the issue in workspace settings**.. Explain**

i.e. a doubled period. The export path doesn't have this because its strings are period-less. This is new — before the PR these messages had no Explain suffix and ended with a single clean period.

Fix options
  • Trim a trailing . from message before wrapping (only in IntegrationSyncFailedMessage), or
  • Drop the period from the integrationSyncFailed string so AskToExplain supplies it (matches the export convention) — but that changes the non-reasoning fallback too, so verify it still reads correctly there.

The recurrence variant (…(Repeated N times.) → …(Repeated N times.). Explain) is also slightly awkward and worth eyeballing.

⚠️ Embedded "workspace settings" link rendering changes (verify on device)

When hasReasoning is true, the message routes through RenderHTML with an onLinkPress prop, which switches RenderHTML to a local RenderHTMLConfigProvider whose renderers map has no a entry (RenderHTML.tsx:79-99) — so the embedded workspace settings link renders via the library default anchor instead of the app's AnchorForCommentsOnly. Navigation itself is preserved (both the default AnchorRenderer and the new handleLinkPress ultimately call openLink(href, environmentURL), see AnchorRenderer.tsx:53-55), but right-click context-menu / hover styling on that link may differ. This is the same tradeoff already shipped for ExportIntegration, so it's consistent rather than a new pattern — just worth a quick visual check that the workspace settings link still looks/behaves right in the reasoning case.

✅ Checked and clear

  • Non-reasoning path (the common case) is byte-for-byte unchanged.
  • No content is lost — the full message incl. the accounting link still renders in the reasoning branch.
  • originalReport is in scope in the router (already threaded to ExportIntegration), and the double-period stays confined to the inline report view — it is not added inside getIntegrationSyncFailedMessage, so LHN previews / notifications are unaffected.

@mkhutornyi

Copy link
Copy Markdown
Contributor

🐞 Double period before the inline "Explain" link

@MelvinBot Looks like you reviewd stale branch. Isn't this fixed in 5a57f32 already?

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a57f32c98

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

// from the sync-failure message so the rendered string reads "…settings. Explain" not "…settings.. Explain".
return (
<ReportActionItemMessageWithExplain
message={message.replace(/\.\s*$/, '')}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Badge Strip punctuation after repeated sync failures

When an integration sync failure has both reasoning and recurrenceCount > 1, getIntegrationSyncFailedMessage() appends the recurrence suffix, e.g. (Repeated 2 times.), so the string ends with ) and this regex leaves the period inside the suffix intact. ReportActionItemMessageWithExplain then appends AskToExplain, whose translations start with sentence punctuation, yielding user-visible copy like ...(Repeated 2 times.). Explain; handle the recurrence suffix or append the Explain link before it so repeated failures do not render the extra terminator.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is nab

@MelvinBot

Copy link
Copy Markdown
Contributor Author

You're right, and thanks for the catch — the double period is already fixed in 5a57f32, and my regression check was run against the pre-fix commit 972b02d (all its permalinks point there), so that finding was stale. Apologies for the noise.

The fix at IntegrationSyncFailedMessage.tsx:34-43 strips the trailing . before AskToExplain supplies its own, so the base sync-failure message correctly renders …workspace settings. Explain. ✅

One small leftover, only for the recurrence variant (separate from the double period, and the same thing the automated reviewer flagged on the new commit): when recurrenceCount > 1, the message ends in (Repeated N times.) (en.ts:9205), so it ends with ) rather than .. The \.\s*$ strip doesn't match, and it renders …(Repeated N times.). Explain. Purely cosmetic and your call whether it's worth handling.

@mkhutornyi

Copy link
Copy Markdown
Contributor

@marcaaron please help complete author checklist with QA Steps. I don't have permission to request Melvin.

@thelullabyy

Copy link
Copy Markdown
Contributor

@MelvinBot Please un-assign me from this PR

@MelvinBot
MelvinBot removed the request for review from thelullabyy July 19, 2026 19:50
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Done — I removed you from this PR. You were listed as a requested reviewer (not an assignee), so I removed your review request. marcaaron remains as the assignee and reviewer.

@marcaaron

Copy link
Copy Markdown
Contributor

I'm not sure this can easily be QA'd we need a failing export which is not so easy to produce.

@marcaaron
marcaaron requested a review from a team July 20, 2026 22:57
@melvin-bot
melvin-bot Bot requested review from mkhutornyi and removed request for a team July 20, 2026 22:57
@melvin-bot

melvin-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@yuwenmemon
yuwenmemon merged commit b511cb8 into main Jul 20, 2026
47 of 48 checks passed
@yuwenmemon
yuwenmemon deleted the claude-explainInlineOnSyncFailed branch July 20, 2026 23:00
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Help site review: no changes required

I reviewed the changes in this PR against Expensify's help site files under docs/articles and no documentation updates are needed.

Why: This is an internal UI-parity bug fix. It makes the inline Explain link appear on hover for integration sync‑failure messages (NetSuite/QBO), matching the behavior already present on the export‑success path — the right‑click "Explain" entry was already available for these messages. It does not add a new user-facing feature or change any documented workflow, setting, integration behavior, pricing, or label.

What I checked
  • The diff only touches two render components (ActionContentRouter.tsx, IntegrationSyncFailedMessage.tsx) to route sync-failure messages through ReportActionItemMessageWithExplain when hasReasoning(action) is true.
  • The inline "Explain" affordance itself is not documented anywhere in docs/articles (no "Explain" link/button is described in the Concierge/AI or connections articles), so there is no existing content that becomes inaccurate as a result of this change.
  • The NetSuite/QuickBooks/Sage sync-error troubleshooting articles document the error codes and resolutions — none of that content is affected by adding a hover affordance.

@marcaaron, no help site PR was created since no documentation changes are needed here. If you believe the Explain affordance itself should be documented as a standalone help article (separate from this fix), let me know and I can draft one.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.41-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@quinthar quinthar added the #ai label Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants