Skip to content

[Due for payment 2026-09-09] [Verify account] International deposit account US flow skips the Plaid or manual choice after verification #98067

Closed

Description

@mountiny

Follow-up to the audit in issue 72980.

Problem

In the international deposit account flow, picking a US bank country sends a validated user to the account flow entry point — CountrySelection.tsx:24-28:

if (COUNTRIES_US_BANK_FLOW.includes(selectedCountry)) {
    if (isUserValidated) {
        Navigation.navigate(ROUTES.SETTINGS_ADD_US_BANK_ACCOUNT_ENTRY_POINT);
    } else {
        Navigation.navigate(ROUTES.SETTINGS_ADD_BANK_ACCOUNT_SELECT_COUNTRY_VERIFY_ACCOUNT);
    }
    return;
}

But CountrySelectionVerifyAccountPage.tsx:11 forwards to the flow root with no subPage:

navigateForwardTo={ROUTES.SETTINGS_ADD_US_BANK_ACCOUNT.getRoute()}

That skips AccountFlowEntryPoint. With no setupType in the draft, the user drops straight into the Plaid substep instead of getting the Plaid or manual choice. The entry point route was added after this page and the page was never updated to match.

Solution

Forward to the same route the validated branch uses.

Action Items

  1. Update the forward route: in CountrySelectionVerifyAccountPage.tsx, change navigateForwardTo to ROUTES.SETTINGS_ADD_US_BANK_ACCOUNT_ENTRY_POINT.
  2. Verify: as an unvalidated user, go to Wallet, add a deposit account, pick United States, enter the magic code, and confirm you get the Plaid or manual choice rather than landing inside Plaid.
  3. Check the non-US path: selecting a non-US country goes through fetchCorpayFields and onMove, which does not touch verification. Confirm it is unaffected.

Specific Component to Migrate

CountrySelectionVerifyAccountPage

  • Current files: src/pages/settings/Wallet/InternationalDepositAccount/CountrySelectionVerifyAccountPage.tsx, src/pages/settings/Wallet/InternationalDepositAccount/subPages/CountrySelection.tsx

This is a one-line change and the smallest item in the audit, so it is a good first pick.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added and removed
    ReviewingHas a PR in review
    on Sep 2, 2026
  2. changed the title [-][Verify account] International deposit account US flow skips the Plaid or manual choice after verification[/-] [+][Due for payment 2026-09-09] [Verify account] International deposit account US flow skips the Plaid or manual choice after verification[/+] on Sep 2, 2026
  3. melvin-bot commented on Sep 2, 2026

    @melvin-bot

    @aimane-chnaif

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.65-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-09-09. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  4. aimane-chnaif commented on Sep 2, 2026

    @aimane-chnaif

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/680735

    Regression Test Proposal

    Test:

    1. Open app, sign in as user with unvalidated account (fresh account works).
    2. Open URL /settings/wallet/add-bank-account directly (deep link - bypasses the wallet-button verification gate).
    3. On country step pick United States, press Next.
    4. Verify magic code page opens andURL ends with /settings/wallet/add-bank-account/country/verify-account.
    5. Enter magic code.
    6. Verify landing on Plaid or manual choice page (/settings/wallet/add-us-bank-account/entry-point).
    7. Navigate back from entry point.
    8. Verify it returns to country selection.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-28df-a315-ee8a-0e20bcce9a54
  5. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 2, 2026
  6. melvin-bot commented on Sep 8, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  7. melvin-bot commented on Sep 8, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  8. mallenexpensify commented on Sep 10, 2026

    @mallenexpensify

    Payment Summary

    Contributor+: @aimane-chnaif due $250 via NewDot

  9. garrettmknight commented on Sep 28, 2026

    @garrettmknight

    $250 approved for @aimane-chnaif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions