Skip to content

[Due for payment 2026-11-02] [Exploratory] Chat - Doc file border and download icon missing after edit comment. #98743

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: V9.4.54-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #97935
Email or phone of affected tester (no customers): dreamnitethedragon+vegst@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redmi note 10s android 13
App Component: Chat Report View

Action Performed:

  1. Launch app
  2. Open a chat
  3. Upload a doc file
  4. Long press and edit comment
  5. At top, enter a message without affecting doc url and save

Expected Result:

Doc file border and download icon must be shown after edit comment.

Actual Result:

Doc file border and download icon missing after edit comment.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7234868_1786861970874.Screenrecorder-2026-08-16-11-57-56-828.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7234868

Issue OwnerCurrent Issue Owner: @chuckdries

Activity

  1. applause-bot commented on Aug 17, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/ae212c637dc3e0d5a6b37c98de30fd2304d628cf99dee18d200f69c2628b7a63

  2. changed the title [-][Exploratory] chat-Doc file border and download icon missing after edit comment.[/-] [+][Exploratory] Chat - Doc file border and download icon missing after edit comment.[/+] on Aug 17, 2026
  3. melvin-bot commented on Aug 17, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  4. mukhrr commented on Aug 17, 2026

    @mukhrr
    Contributor

    While Applause doesn't embed attachments for this bug, here are the links for quick view: https://platform.applause.com/services/links/v1/external/ae212c637dc3e0d5a6b37c98de30fd2304d628cf99dee18d200f69c2628b7a63

    false alarm. cc @Beamanator

  5. mukhrr commented on Aug 18, 2026

    @mukhrr
    Contributor

    @youssef-lr coming from #98696. mind assigming me here as a follow up?

  6. brunovjk commented on Aug 18, 2026

    @brunovjk
    Contributor

    @youssef-lr coming from #98696. mind assigming me here as a follow up?

    Me as well. Thank you very much.

  7. mukhrr commented on Aug 25, 2026

    @mukhrr
    Contributor

    @youssef-lr I found a related bug on production:

    When editing a file (csv in my case) and downloading, edited name is not kept. it generates random text for donloaded csv. Do we want to fix it here or as a follow up? cc @brunovjk

    REC-20260825064136.mp4
  8. brunovjk commented on Sep 2, 2026

    @brunovjk
    Contributor

    Friendly bump @youssef-lr

  9. youssef-lr commented on Sep 10, 2026

    @youssef-lr
    Contributor

    Let's fix it here @mukhrr. Sorry for the delay was out sick.

  10. 51 remaining items

  11. mukhrr commented on Nov 3, 2026

    @mukhrr
    Contributor

    Not sure how much should be paid here 🤷‍♂️

    just fyi..

    We fixed 4 extra bugs + original issue in original PR;
    Original PR caused 3 issues (2 regressions + 1 pre-existing bug);
    So in the end, we fixed 5 pre-existing bugs and one original issue [$250] in regression PR which turned into +1,695 and -26 line changes in total 36 files. cc @brunovjk @youssef-lr

    I see @youssef-lr is deactivated on slack cc @mallenexpensify

  12. brunovjk commented on Nov 3, 2026

    @brunovjk
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: No introducing PR confirmed.
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Signed in with access to a chat and .doc/.csv files, including a non-English filename.

    Test:

    1. Upload a .doc file to the chat and wait for the upload to finish.
    2. Select Edit comment, add text above and below the attachment link without changing its URL, and save.
    3. Verify the attachment retains its border, filename, and download icon, without overlapping the text.
    4. Edit and save again, then reopen the chat. Verify the attachment card remains intact and downloads successfully.
    5. Send two CSV files, edit the second, and verify both cards remain correctly aligned.
    6. Send text with the non-English filename attachment. While uploading, edit the text and save. Verify both the text and attachment survive upload completion.
    7. Go offline, send text with an attachment, edit its text and filename, then restart the app and reconnect. Verify the edit and attachment survive synchronization.
    8. Download the renamed attachment using both its card and the context menu. Verify the filename and extension are preserved.

    Do we agree 👍 or 👎

  13. brunovjk commented on Nov 3, 2026

    @brunovjk
    Contributor

    Summary payment

    Fix: Preserve attachment cards, filenames, and downloads after editing comments in #101717.

    People involved: @mukhrr — author; @brunovjk — C+ reviewer.

    Production deployment: Deployed on 2026-10-26, confirmed here. Deployment checklist.

    Regressions and follow-ups: The initial correction, #99385, introduced two confirmed regressions: #101689 and #101692. It was reverted by #101745. The replacement, #101717, fixed the original issue and both 'regressions', alongside pre-existing #101744. The pre-existing LHN issue #101693 was addressed separately in #102746, deployed on 2026-10-27.

    The automated payment summary records $175 for each participant. The author’s scope review request references a $250 original issue and reports five additional pre-existing bugs addressed. These records are provided for management to assess the appropriate compensation and any applicable adjustments.

    Suggested payment: To be determined by management after reviewing the scope, payment records, and regression history.

    cc: @mallenexpensify

  14. mallenexpensify commented on Nov 5, 2026

    @mallenexpensify
    Contributor

    Claude posting on behalf of Matt:

    @tgolen @chuckdries can you review? I propose $175 each to @mukhrr (Contributor) and @brunovjk (Contributor+), ie. 100% of the $175 job price. That is 200% for the extra fixes, with a 50% cut on the job price for #101689 and a 50% cut on the increase for #101692.

    Evidence

    PAYRUBRICTEST v2

  15. mukhrr commented on Nov 5, 2026

    @mukhrr
    Contributor

    $175 each to @mukhrr (Contributor) and @brunovjk (Contributor+), ie. 100% of the $175 job price.

    well, to be clear original price was $250 (not $175, we were assigned before 19.09.2026).

    Extra fixes: #98743 (comment) (approved), #101744

    Claude (on behalf of Matt) says 2 extra issues. That's not correct as well. In the end, we fixed original issue and 5 pre-existing bugs; got 2 regressions as I clearly mentioned here

    So in the end, we fixed 5 pre-existing bugs and #98743 in #101717 which turned into +1,695 and -26 line

    cc @brunovjk @chuckdries

  16. mallenexpensify commented on Nov 5, 2026

    @mallenexpensify
    Contributor

    well, to be clear original price was $250

    Correct, Claude/Matt missed that cuz the auto-post says $175 above

    Claude (on behalf of Matt) says 2 extra issues.

    This wasn't clear, the rule is supposed to state that the number of additional fixes doesn't increase the price (cuz, for now, that should be decided by the assigned engineer)

    @chuckdries , 👀 plz when you have a min

  17. chuckdries commented on Nov 9, 2026

    @chuckdries
    Contributor

    This one's a doozy. We had regressions, but we also expanded the scope beyond the original styling bug. I think $250 is fair

  18. mallenexpensify commented on Nov 9, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @mukhrr due $250 via NewDot
    Contributor+: @brunovjk due $250 via NewDot

  19. laurenreidexpensify commented on Nov 11, 2026

    @laurenreidexpensify
    Contributor

    approved $250 for @brunovjk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions