You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-02] [Exploratory] Chat - Doc file border and download icon missing after edit comment. #98743
Version Number: V9.4.54-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#97935 Email or phone of affected tester (no customers):dreamnitethedragon+vegst@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Redmi note 10s android 13 App Component: Chat Report View
Action Performed:
Launch app
Open a chat
Upload a doc file
Long press and edit comment
At top, enter a message without affecting doc url and save
Expected Result:
Doc file border and download icon must be shown after edit comment.
Actual Result:
Doc file border and download icon missing after edit comment.
changed the title [-][Exploratory] chat-Doc file border and download icon missing after edit comment.[/-][+][Exploratory] Chat - Doc file border and download icon missing after edit comment.[/+]on Aug 17, 2026
When editing a file (csv in my case) and downloading, edited name is not kept. it generates random text for donloaded csv. Do we want to fix it here or as a follow up? cc @brunovjk
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: No introducing PR confirmed.
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Signed in with access to a chat and .doc/.csv files, including a non-English filename.
Test:
Upload a .doc file to the chat and wait for the upload to finish.
Select Edit comment, add text above and below the attachment link without changing its URL, and save.
Verify the attachment retains its border, filename, and download icon, without overlapping the text.
Edit and save again, then reopen the chat. Verify the attachment card remains intact and downloads successfully.
Send two CSV files, edit the second, and verify both cards remain correctly aligned.
Send text with the non-English filename attachment. While uploading, edit the text and save. Verify both the text and attachment survive upload completion.
Go offline, send text with an attachment, edit its text and filename, then restart the app and reconnect. Verify the edit and attachment survive synchronization.
Download the renamed attachment using both its card and the context menu. Verify the filename and extension are preserved.
Regressions and follow-ups: The initial correction, #99385, introduced two confirmed regressions: #101689 and #101692. It was reverted by #101745. The replacement, #101717, fixed the original issue and both 'regressions', alongside pre-existing #101744. The pre-existing LHN issue #101693 was addressed separately in #102746, deployed on 2026-10-27.
The automated payment summary records $175 for each participant. The author’s scope review request references a $250 original issue and reports five additional pre-existing bugs addressed. These records are provided for management to assess the appropriate compensation and any applicable adjustments.
Suggested payment: To be determined by management after reviewing the scope, payment records, and regression history.
@tgolen@chuckdries can you review? I propose $175 each to @mukhrr (Contributor) and @brunovjk (Contributor+), ie. 100% of the $175 job price. That is 200% for the extra fixes, with a 50% cut on the job price for #101689 and a 50% cut on the increase for #101692.
Claude (on behalf of Matt) says 2 extra issues. That's not correct as well. In the end, we fixed original issue and 5 pre-existing bugs; got 2 regressions as I clearly mentioned here
So in the end, we fixed 5 pre-existing bugs and #98743 in #101717 which turned into +1,695 and -26 line
Correct, Claude/Matt missed that cuz the auto-post says $175 above
Claude (on behalf of Matt) says 2 extra issues.
This wasn't clear, the rule is supposed to state that the number of additional fixes doesn't increase the price (cuz, for now, that should be decided by the assigned engineer)
Activity
applause-bot commentedon Aug 17, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/ae212c637dc3e0d5a6b37c98de30fd2304d628cf99dee18d200f69c2628b7a63
[-][Exploratory] chat-Doc file border and download icon missing after edit comment.[/-][+][Exploratory] Chat - Doc file border and download icon missing after edit comment.[/+]melvin-bot commentedon Aug 17, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mukhrr commentedon Aug 17, 2026
false alarm. cc @Beamanator
mukhrr commentedon Aug 18, 2026
@youssef-lr coming from #98696. mind assigming me here as a follow up?
brunovjk commentedon Aug 18, 2026
Me as well. Thank you very much.
mukhrr commentedon Aug 25, 2026
@youssef-lr I found a related bug on production:
When editing a file (csv in my case) and downloading, edited name is not kept. it generates random text for donloaded csv. Do we want to fix it here or as a follow up? cc @brunovjk
REC-20260825064136.mp4
brunovjk commentedon Sep 2, 2026
Friendly bump @youssef-lr
youssef-lr commentedon Sep 10, 2026
Let's fix it here @mukhrr. Sorry for the delay was out sick.
51 remaining items
mukhrr commentedon Nov 3, 2026
I see @youssef-lr is deactivated on slack cc @mallenexpensify
brunovjk commentedon Nov 3, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: No introducing PR confirmed.
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Signed in with access to a chat and .doc/.csv files, including a non-English filename.
Test:
Do we agree 👍 or 👎
brunovjk commentedon Nov 3, 2026
Summary payment
Fix: Preserve attachment cards, filenames, and downloads after editing comments in #101717.
People involved: @mukhrr — author; @brunovjk — C+ reviewer.
Production deployment: Deployed on 2026-10-26, confirmed here. Deployment checklist.
Regressions and follow-ups: The initial correction, #99385, introduced two confirmed regressions: #101689 and #101692. It was reverted by #101745. The replacement, #101717, fixed the original issue and both 'regressions', alongside pre-existing #101744. The pre-existing LHN issue #101693 was addressed separately in #102746, deployed on 2026-10-27.
The automated payment summary records $175 for each participant. The author’s scope review request references a $250 original issue and reports five additional pre-existing bugs addressed. These records are provided for management to assess the appropriate compensation and any applicable adjustments.
Suggested payment: To be determined by management after reviewing the scope, payment records, and regression history.
cc: @mallenexpensify
mallenexpensify commentedon Nov 5, 2026
Claude posting on behalf of Matt:
@tgolen @chuckdries can you review? I propose $175 each to @mukhrr (Contributor) and @brunovjk (Contributor+), ie. 100% of the $175 job price. That is 200% for the extra fixes, with a 50% cut on the job price for #101689 and a 50% cut on the increase for #101692.
Evidence
PAYRUBRICTEST v2mukhrr commentedon Nov 5, 2026
well, to be clear original price was $250 (not $175, we were assigned before 19.09.2026).
Claude (on behalf of Matt) says 2 extra issues. That's not correct as well. In the end, we fixed original issue and 5 pre-existing bugs; got 2 regressions as I clearly mentioned here
cc @brunovjk @chuckdries
mallenexpensify commentedon Nov 5, 2026
Correct, Claude/Matt missed that cuz the auto-post says $175 above
This wasn't clear, the rule is supposed to state that the number of additional fixes doesn't increase the price (cuz, for now, that should be decided by the assigned engineer)
@chuckdries , 👀 plz when you have a min
chuckdries commentedon Nov 9, 2026
This one's a doozy. We had regressions, but we also expanded the scope beyond the original styling bug. I think $250 is fair
mallenexpensify commentedon Nov 9, 2026
Payment Summary
Contributor: @mukhrr due $250 via NewDot
Contributor+: @brunovjk due $250 via NewDot
laurenreidexpensify commentedon Nov 11, 2026
approved $250 for @brunovjk