Repository navigation
[CP Staging] Revert "Keep a file attachment intact when its comment is edited" - #101745
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
[CP Staging] Revert "Keep a file attachment intact when its comment is edited" (cherry picked from commit 54b6817) (cherry-picked to staging by lakchote)
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.4.90-2 🚀
|
|
🤖 No help site changes are required — I did not create a docs PR. Why: this PR reverts Keep a file attachment intact when its comment is edited, a bug fix for Web - Chat - Attachment is displayed as a link after editing the message. It restores the previous code, so it removes a defect fix rather than changing any documented, intended behavior. What I checked in
Because the help site never documented the behavior this PR reverts, there is nothing on the help site that is now wrong. Code changes reviewedEvery file in the revert is internal implementation with no user-facing label, setting, tab, or button change:
If you would rather the help site call out the current attachment-on-edit behavior explicitly, reply with @lakchote, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.90-2 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.4.91-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.91-3 🚀
Bundle Size Analysis (Sentry): |
Reverts #99385