You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
The system message does not appear when the expense is moved to another report #99733
Version Number: 9.4.63-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#98046 Email or phone of affected tester (no customers): n/a Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Mac 26.5.1 Safari, iPhone 13 iOS 26.6 App Component: Money Requests
Root Cause: The "moved this expense from …" system message is intentionally suppressed when the source report is still an Open / draft report. In the repro, report A is a freshly-created report with an unsubmitted expense (stateNum: 0, statusNum: 0), so the guard at Transaction.ts:1657 skips building the MOVED_TRANSACTION action entirely — no action is created, so no message renders. The "different workspace" detail is incidental: the guard checks only the source report's state, not the policy, so moving out of any draft report suppresses the message.
This is likely working as designed. The guard implements the product decision in #70485 ("Update system messages for expenses moved to different reports", still open, due 2026-08-31) to drop the moved message for draft-report moves, and it's locked in by unit tests. Recommend confirming with BugZero / the #70485 stakeholders whether a cross-workspace move out of a draft should be an exception before treating this as a code bug.
If the team decides it should show for cross-workspace moves: relax the guard so a MOVED_TRANSACTION action is still built when the source is Open and the target report's policy differs from the source's (oldReport.policyID !== newReport.policyID), rather than skipping on !isOpenReport(oldReport) alone.
Investigation details
Move flow: "Move to report" → changeTransactionsReport → getChangeTransactionsReportOnyxData. At step 7 it decides whether to add a moved/unreported action:
letmovedAction;if(reportID===CONST.REPORT.UNREPORTED_REPORT_ID){movedAction=buildOptimisticUnreportedTransactionAction(transactionThreadReportID,oldReportID);}elseif(!isOpenReport(oldReport)){// <-- report A is Open → skippedmovedAction=buildOptimisticMovedTransactionAction(transactionThreadReportID,oldReportID);}
reportID is the target (report B, a real report → first branch skipped); oldReport is the source (report A). isOpenReport returns true when stateNum === 0 && statusNum === 0. A manually-created, never-submitted expense report defaults to OPEN/OPEN (via getExpenseReportStateAndStatus, unless the policy has instant-submit), so !isOpenReport(oldReport) is false and movedAction stays undefined — the block that writes the action to the transaction thread never runs.
Not a rendering bug:getMovedTransactionMessage has a non-empty fallback (iou.movedTransactionFromAnotherReport), so even a blank report name would still render text. The message is absent because the action was never created — not because it rendered empty. (This rules out the recently-merged getMovedTransactionMessage refactor in #98046 as the cause.)
Confidence: high on the mechanism (code evidence + existing unit tests confirm the draft-report skip); the open question is purely the product decision on whether cross-workspace draft moves should be an exception. Runtime verification via the web tester couldn't complete this run — the pre-started browser session didn't render — so this rests on code evidence.
Next Steps for Contributor+ team: To accept the conditional fix:@MelvinBot implement [this](https://github.com/Expensify/App/issues/99733) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's analysis (e.g. confirmed working-as-designed per #70485).
Activity
applause-bot commentedon Aug 28, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/ba4cd55ce3531df4893ab541afbe140e1838e7a219c53ddb1ff6e219f82006b8
MelvinBot commentedon Aug 28, 2026
Issue Analysis
Root Cause: The "moved this expense from …" system message is intentionally suppressed when the source report is still an Open / draft report. In the repro, report A is a freshly-created report with an unsubmitted expense (
stateNum: 0, statusNum: 0), so the guard atTransaction.ts:1657skips building theMOVED_TRANSACTIONaction entirely — no action is created, so no message renders. The "different workspace" detail is incidental: the guard checks only the source report's state, not the policy, so moving out of any draft report suppresses the message.This is likely working as designed. The guard implements the product decision in #70485 ("Update system messages for expenses moved to different reports", still open, due 2026-08-31) to drop the moved message for draft-report moves, and it's locked in by unit tests. Recommend confirming with BugZero / the #70485 stakeholders whether a cross-workspace move out of a draft should be an exception before treating this as a code bug.
If the team decides it should show for cross-workspace moves: relax the guard so a
MOVED_TRANSACTIONaction is still built when the source is Open and the target report's policy differs from the source's (oldReport.policyID !== newReport.policyID), rather than skipping on!isOpenReport(oldReport)alone.Investigation details
Move flow: "Move to report" →
changeTransactionsReport→getChangeTransactionsReportOnyxData. At step 7 it decides whether to add a moved/unreported action:reportIDis the target (report B, a real report → first branch skipped);oldReportis the source (report A).isOpenReportreturnstruewhenstateNum === 0 && statusNum === 0. A manually-created, never-submitted expense report defaults toOPEN/OPEN(viagetExpenseReportStateAndStatus, unless the policy has instant-submit), so!isOpenReport(oldReport)isfalseandmovedActionstaysundefined— the block that writes the action to the transaction thread never runs.Not a rendering bug:
getMovedTransactionMessagehas a non-empty fallback (iou.movedTransactionFromAnotherReport), so even a blank report name would still render text. The message is absent because the action was never created — not because it rendered empty. (This rules out the recently-mergedgetMovedTransactionMessagerefactor in #98046 as the cause.)Confidence: high on the mechanism (code evidence + existing unit tests confirm the draft-report skip); the open question is purely the product decision on whether cross-workspace draft moves should be an exception. Runtime verification via the web tester couldn't complete this run — the pre-started browser session didn't render — so this rests on code evidence.
Next Steps for Contributor+ team:
To accept the conditional fix:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/99733)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's analysis (e.g. confirmed working-as-designed per #70485).
view run
melvin-bot commentedon Aug 28, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (
External)melvin-bot commentedon Aug 28, 2026
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.
melvin-bot commentedon Aug 31, 2026
@mkhutornyi Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Sep 2, 2026
@mkhutornyi Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Sep 3, 2026
@mkhutornyi Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Sep 3, 2026
@mkhutornyi Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Sep 4, 2026
@mkhutornyi Still overdue 6 days?! Let's take care of this!
31 remaining items
melvin-bot commentedon Oct 29, 2026
@mkhutornyi Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Nov 2, 2026
@mkhutornyi Still overdue 6 days?! Let's take care of this!
melvin-bot commentedon Nov 3, 2026
@mkhutornyi 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Nov 3, 2026
@mkhutornyi 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Nov 5, 2026
@mkhutornyi 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
melvin-bot commentedon Nov 5, 2026
@mkhutornyi 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
melvin-bot commentedon Nov 5, 2026
@mkhutornyi 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
melvin-bot commentedon Nov 6, 2026
@mkhutornyi 10 days overdue. Is anyone even seeing these? Hello?
jeffrey-graham commentedon Nov 7, 2026
melvin-bot commentedon Nov 7, 2026
mkhutornyi commentedon Nov 11, 2026
Same
expensify-chore-bot commentedon Nov 18, 2026
@mkhutornyi 6 days overdue. This is scarier than being forced to listen to Vogon poetry!