Skip to content

[Phase 2] Part 3 - Migrate deprecatedGetReportName -> getReportName in ReportUtils libs - #98046

Merged
marcochavezf merged 6 commits into
Expensify:mainfrom
hoangzinh:split/pr1a-transaction-message-name
Aug 27, 2026
Merged

marcochavezf merged 6 commits into
Expensify:mainfrom
hoangzinh:split/pr1a-transaction-message-name

Conversation

@hoangzinh

@hoangzinh hoangzinh commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

This part covers the two transaction-message getters:

  • getMovedTransactionMessage and getUnreportedTransactionMessage in ReportUtils

Follow-up PRs:

Fixed Issues

$ #66427
PROPOSAL:

Tests

Same as QA

  • Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Test 1 — Moved-transaction system message

  1. Open an expense in report A.
  2. From the expense header, open the three-dot menu → Move to report → move it to report B in a different workspace.
  3. Open report B and locate the moved expense's thread.
  4. Verify the system message display moved this expense from <report A name>, and the link opens report A.

Test 2 — Unreported-transaction system message (UnreportedTransactionAction)

  1. Open an expense that sits in a report.
  2. Move it out of the report to the self-DM / Unreported.
  3. Open the resulting thread.
  4. Verify the moved this expense from <report name> message renders

Test 3 — Copy to clipboard (ContextMenuActions)

  1. Right-click (web) or long-press (mobile) a moved-transaction action.
  2. Choose Copy to clipboard.
  3. Paste into any text field.
  4. Verify the pasted text is the moved-transaction message with the correct report name. Repeat steps 1–4 for an unreported-transaction action.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screen.Recording.2026-08-08.110106.mp4

@codecov

codecov Bot commented Aug 7, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...onents/ReportActionItem/MovedTransactionAction.tsx 100.00% <100.00%> (ø)
...s/ReportActionItem/UnreportedTransactionAction.tsx 100.00% <100.00%> (ø)
src/libs/ReportUtils.ts 87.22% <93.75%> (+0.04%) ⬆️
src/libs/ReportNameUtils.ts 81.08% <50.00%> (-0.80%) ⬇️
src/libs/OptionsListUtils/index.ts 87.20% <55.55%> (-0.11%) ⬇️
src/libs/SidebarUtils.ts 79.65% <68.75%> (-0.68%) ⬇️
...es/inbox/report/ContextMenu/ContextMenuActions.tsx 40.42% <16.66%> (-0.19%) ⬇️
... and 500 files with indirect coverage changes

@hoangzinh hoangzinh changed the title [Phase 2] Part 3 Migrate deprecatedGetReportName to getReportName in libs [Phase 2] Part 3 Migrate deprecatedGetReportName to getReportName in ReportUtils libs Aug 7, 2026
@hoangzinh
hoangzinh marked this pull request as ready for review August 8, 2026 04:21
@hoangzinh
hoangzinh requested review from a team as code owners August 8, 2026 04:21
@melvin-bot
melvin-bot Bot requested review from DylanDylann and trjExpensify and removed request for a team and DylanDylann August 8, 2026 04:21
@melvin-bot

melvin-bot Bot commented Aug 8, 2026

Copy link
Copy Markdown

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Comment thread src/libs/ReportNameUtils.ts Resolved
@hoangzinh hoangzinh changed the title [Phase 2] Part 3 Migrate deprecatedGetReportName to getReportName in ReportUtils libs [Phase 2] Part 3 - Migrate deprecatedGetReportName -> getReportName in ReportUtils libs Aug 8, 2026
@trjExpensify
trjExpensify removed their request for review August 10, 2026 11:22
@trjExpensify

Copy link
Copy Markdown
Contributor

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.


const message = getMovedTransactionMessage(translate, action, reportAttributes);
const derivedReportName = useDerivedReportNameByReportID(fromReportID);
const message = getMovedTransactionMessage(translate, action, derivedReportName);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid duplication, let's pass fromReport and parseMovedTransactionReportIDs(action).fromReportID instead of action

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DylanDylann, can you elaborate on "duplication"? I thought what we did currently already avoids duplication on how we get fromReport or toReport

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's pass fromReport and parseMovedTransactionReportIDs(action).fromReportID instead of action

@hoangzinh We call parseMovedTransactionReportIDs twice

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I went with a slightly different shape — passing fromReport alone doesn't quite cover it:

  1. The original logic resolves the report as fromReport ?? toReport — when fromReportID is undefined, the name has to come from toReport. So fromReport on its own would break that case.
  2. Fixing that by also passing toReport means the fromReportID ?? toReportID selection gets repeated at every caller — more duplication, not less.
  3. And SidebarUtils / OptionsListUtils are plain lib files, so they can't read the report via useOnyx at all — their only option is getReportOrDraftReport / deprecatedAllReports, which read from the JS memory cache instead of Onyx and so don't re-render when the report updates.

Instead:

// callers with useOnyx pass movedReport; others pass IDs and the function falls back internally
getMovedTransactionMessage({translate, movedReport?, toReportID?, fromReportID?, derivedReportName?})

// resolved ID returned here, so the ?? logic lives in one place
parseMovedTransactionReportIDs(action) // => {toReportID, fromReportID, displayReportID}

Applied here: f82c430

…tring

Add parseMovedTransactionReportIDs, getMovedTransactionReportID and
getUnreportedTransactionReportID, and narrow getMovedTransactionMessage /
getUnreportedTransactionMessage to take a precomputed derivedReportName
string instead of the whole reportAttributes Record.

MovedTransactionAction and UnreportedTransactionAction now source that
single name via useDerivedReportNameByReportID, dropping their whole-Record
useReportAttributes() subscription. The remaining callers (OptionsListUtils,
SidebarUtils, ReportNameUtils, ContextMenuActions) extract the one report's
name before calling, and are otherwise unchanged.

getChatListItemReportName and getReportPreviewMessageForCopy keep their
deprecatedGetReportName path for now; they are narrowed in the follow-up PR.

Part of Expensify#66427 Phase 2.
…TransactionReportIDs

Remove getMovedTransactionReportID and getUnreportedTransactionReportID
wrappers. Callers now destructure parseMovedTransactionReportIDs
directly. Refactor getMovedTransactionMessage to accept an options
object with optional movedReport for component-level Onyx data.
@hoangzinh
hoangzinh requested review from a team, stephanieelliott and tgolen as code owners August 20, 2026 14:21
@melvin-bot

melvin-bot Bot commented Aug 20, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@github-actions

Copy link
Copy Markdown
Contributor

This PR adds a new Onyx.connectWithoutView call, so I've requested a review from the Onyx performance reviewers (@tgolen, @mountiny, @luacmartins) — a review from any one of them is enough. Please add a link in your PR description to the Slack discussion where the @frontend-performance team approved using connectWithoutView here.

@hoangzinh
hoangzinh force-pushed the split/pr1a-transaction-message-name branch from 6088de9 to f82c430 Compare August 20, 2026 14:23
@stephanieelliott
stephanieelliott removed their request for review August 21, 2026 01:32
const isPendingDelete = fromReport?.pendingFields?.preview === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;
const unreportedTransactionMessage = getUnreportedTransactionMessage(translate, action, reportAttributes);
const derivedReportName = useDerivedReportNameByReportID(fromReportID);
const unreportedTransactionMessage = getUnreportedTransactionMessage(translate, action, derivedReportName);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update getUnreportedTransactionMessage function to avoid duplication

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated here 831fe33

…ed params

- Replace positional args with named object params matching getMovedTransactionMessage pattern
- Add optional fromReport param so callers with useOnyx can pass report directly
- Use reportID derived from report or fromReportID for URL and unreported check
- Update all 5 callers and 3 tests
@stephanieelliott stephanieelliott removed the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 24, 2026
@DylanDylann

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 831fe337ba

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@DylanDylann

Copy link
Copy Markdown
Contributor

@MelvinBot Could you check if this comment has already been resolved?

@MelvinBot

Copy link
Copy Markdown
Contributor

✅ Yes, this comment has been addressed — in commit 04db63d (hoangzinh's reply on the thread). The Codex thread is still marked Unresolved on GitHub, but the code change it asked for is in place.

The Codex bot asked to pass fromReportID alongside fromReport so the sentinel CONST.REPORT.UNREPORTED_REPORT_ID case can render the "moved to your personal space" message. Both sides now do that:

The only thing left is to click Resolve conversation on the thread to reflect that.


view run

@DylanDylann

Copy link
Copy Markdown
Contributor

@hoangzinh regarding Codex's review, I notice that when fromReportID is CONST.REPORT.UNREPORTED_REPORT_ID, fromReport is undefined -> fromReportID ?? toReportID is different than fromReport ?? toReport

New behavior
fromReportID ?? toReportID = CONST.REPORT.UNREPORTED_REPORT_ID
displayReport will be undefined

Original behavior
fromReport ?? toReport = toReport

Could you check if this is actually an issue?

@hoangzinh

hoangzinh commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor Author

@hoangzinh regarding Codex's review, I notice that when fromReportID is CONST.REPORT.UNREPORTED_REPORT_ID, fromReport is undefined -> fromReportID ?? toReportID is different than fromReport ?? toReport

New behavior fromReportID ?? toReportID = CONST.REPORT.UNREPORTED_REPORT_ID displayReport will be undefined

Original behavior fromReport ?? toReport = toReport

Could you check if this is actually an issue?

If fromReportID is equal to CONST.REPORT.UNREPORTED_REPORT_ID, the report will not be shown. You can verify the logic here

if (fromReportID === CONST.REPORT.UNREPORTED_REPORT_ID) {
return false;
}

I also tested this and confirmed that these reports are not shown in the UI so this is not an issue

I suggest keeping the current implementation to keep the code clean.

@DylanDylann

Copy link
Copy Markdown
Contributor

@codex review

@DylanDylann

DylanDylann commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-08-26.at.15.21.37.mov

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bd063e0044

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@melvin-bot
melvin-bot Bot requested a review from marcochavezf August 26, 2026 08:26
@marcochavezf
marcochavezf merged commit 08035d0 into Expensify:main Aug 27, 2026
38 of 46 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 marcochavezf has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #98046.

Android 🤖 iOS 🍎
❌ FAILED ❌ https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-08035d0-9897810-ca7184f638a5c7299327aa1e88998c5acc3cf83b/index.html
The QR code can't be generated, because the Android build failed iOS
Web 🕸️
https://98046.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Aug 27, 2026
65 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.4.63-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes required

I reviewed this PR against the help site articles in App/docs/articles and no docs updates are needed. No draft PR was created.

This is an internal refactor with no user-facing behavior change. It migrates deprecatedGetReportName → getReportName in ReportUtils and restructures the two transaction-message getters (getMovedTransactionMessage, getUnreportedTransactionMessage) to take explicit params via parseMovedTransactionReportIDs instead of deriving them internally.

Why no docs are affected
  • The rendered system messages are unchanged — moved this expense from <report name>, moved this expense to <report name>, and the unreported-transaction variant all still resolve to the same copy (they read the same iou.movedTransactionFrom / iou.movedTransactionTo / iou.unreportedTransaction translation keys). Only the plumbing that supplies the report name changed.
  • No new UI, tabs, settings, buttons, or feature names were introduced or renamed — so there's nothing in the live UI to reconcile against the help site.
  • The changes are confined to name-resolution utils and their call sites (ReportUtils, ReportNameUtils, OptionsListUtils, SidebarUtils, ContextMenuActions, and the two *TransactionAction components) plus unit tests. Help site articles document customer-facing product behavior, none of which is altered here.

The keyword matches in docs/articles for "move expense" / "unreported" are unrelated general references to moving expenses between reports, not documentation of these system-message internals.

Since no help site change is required, there is no linked help site PR to review. If you believe a customer-facing behavior did change here and should be documented, let me know and I'll create the docs PR.


view run

@mitarachim

Copy link
Copy Markdown

@hoangzinh This PR in Test 1 step 4 is failing because of a regression issue #99733

Screenshot 2026-08-28 at 1 39 56 PM

The issue is reproducible in: Web, iOS, Android

Bug7244718_1787874338231.Recording__2867.mp4

@hoangzinh

hoangzinh commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor Author

Oops @mitarachim, sorry that I didn't say it more clearly. We need to submit the report before moving expenses

Test 1 — Moved-transaction system message

  1. Submit an expense in report A.
  2. From the expense header, open the three-dot menu → Move to report → move it to report B in a different workspace.
  3. Open report B and locate the moved expense's thread.
  4. Verify the system message display moved this expense from , and the link opens report A.
Screen.Recording.2026-08-28.at.16.38.41.mov

@m-natarajan

Copy link
Copy Markdown

Validated test 1, Pass in Chrome / v9.4.63-0 and Xiaomi Redmi Note 10 / Android 12, App 9.4.63-0

bandicam.2026-08-28.20-31-33-394.mp4
Screenrecorder-2026-08-28-20-41-31-894.mp4

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.63-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants