Skip to content

[Due for payment 2026-10-01] Remove Onyx.connect() for the key: ONYXKEYS.DERIVED.REPORT_ATTRIBUTES in src/libs/ReportUtils.ts #66427

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

  • Module: src/libs/ReportUtils.ts
  • Onyx Key: ONYXKEYS.DERIVED.REPORT_ATTRIBUTES
  • Reference: Line 1098: ONYXKEYS.DERIVED.REPORT_ATTRIBUTES

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. self-assigned this
    on Jul 16, 2025
  2. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  3. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  4. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added and removed on Jul 16, 2025
  6. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @tgolen @lydiabarclay this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  7. lydiabarclay commented on Aug 18, 2025

    @lydiabarclay
    Contributor

    Hey @tgolen is there any action that I need to take here? I see we do not have any contributors assigned yet.

  8. 145 remaining items

  9. DylanDylann commented on Sep 30, 2026

    @DylanDylann
    Contributor

    @MelvinBot Could you please list all PRs associated with this issue along with the suggested payment for each?

  10. MelvinBot commented on Sep 30, 2026

    @MelvinBot
    Contributor

    Seven merged PRs are linked to this issue. At the $250 rate in the payment summary, that suggests $1,750 for hoangzinh (contributor) and $1,750 for DylanDylann (C+ reviewer). I found no reverts or confirmed regressions.

    PR Merged hoangzinh DylanDylann
    Refactor issue 66427: Add reportAttributes parameter to getReportName and getParentNavigationSubtitle functions (Part 1/4) 2026-07-07 $250 $250
    [Payment due @DylanDylann] [NO QA] [Phase 2] Part 1 - Mark current getReportName to be deprecated method 2026-07-20 $250 $250*
    [Phase 2] Part 2 - Migrate deprecatedGetReportName → getReportName in component files 2026-08-03 $250 $250
    [Phase 2] Part 5 - Migrate deprecatedGetReportName → getReportName in pages + tests files 2026-08-18 $250 $250
    [Phase 2] Part 3 - Migrate deprecatedGetReportName -> getReportName in ReportUtils libs 2026-08-27 $250 $250
    [Phase 2] Part 4 - Migrate deprecatedGetReportName to getReportName in libs 2026-09-17 $250 $250
    [Phase 4] - Remove module-level reportAttributesDerivedValue in isEmptyReport() 2026-09-18 $250 $250
    Total $1,750 $1,750

    *Before paying, check this row so it isn't paid twice. The PR title says "Payment due @DylanDylann", and a bot comment said a separate C+ payment issue would be created. I couldn't find that issue.

    Notes

    view run

  11. DylanDylann commented on Sep 30, 2026

    @DylanDylann
    Contributor

    @hoangzinh Are we missing any PR in the above list?

  12. hoangzinh commented on Oct 1, 2026

    @hoangzinh
    Contributor

    @hoangzinh Are we missing any PR in the above list?

    @DylanDylann Nope, it included all our PRs

  13. DylanDylann commented on Oct 1, 2026

    @DylanDylann
    Contributor

    @tgolen Can you confirm the amount for each PR in this list?

  14. tgolen commented on Oct 1, 2026

    @tgolen
    ContributorAuthor

    I approve a total of $1,750

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Oct 1, 2026
  16. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.DERIVED.REPORT_ATTRIBUTES` in `src/libs/ReportUtils.ts`[/-] [+][Due for payment 2026-10-01] Remove `Onyx.connect()` for the key: `ONYXKEYS.DERIVED.REPORT_ATTRIBUTES` in `src/libs/ReportUtils.ts`[/+] on Oct 1, 2026
  17. melvin-bot commented on Oct 1, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  18. mallenexpensify commented on Oct 3, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @hoangzinh due $1,750 via NewDot
    Contributor+: @DylanDylann due $1,750 via NewDot

  19. laurenreidexpensify commented on Oct 12, 2026

    @laurenreidexpensify
    Contributor

    Approved $1750 @hoangzinh New Expensify

  20. quinthar commented on Oct 27, 2026

    @quinthar
    Contributor

    Approved $1750 to @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions