Repository navigation
[Phase 2] Part 5 - Migrate deprecatedGetReportName → getReportName in pages + tests files - #97111
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
77387bd to
7837fcf
Compare
Migrate pages and tests off deprecatedGetReportName to getReportName with the useDerivedReportNameByReportID hook. - Swap deprecatedGetReportName(report, reportAttributes) for getReportName(report, derivedName) across 16 page components - Drop local reportByIDsSelector/useOnyx REPORT_ATTRIBUTES wiring in favor of useDerivedReportNameByReportID - Pass reportAttributes?.[reportID]?.reportName directly in WorkspaceRoomsPage - Update ReportNameUtilsTest to the new signature Part of Expensify#66427 phase 2
- Replace multiple useDerivedReportNameByReportID calls with single useDerivedReportNamesByReportIDs batch call - HeaderView, QuickActionMenuItem, WorkspaceRoomsPage
7837fcf to
3285ec0
Compare
- Replace inline derivedNames[reportID] lookups with getReportNameFromNames - Drop redundant useMemo in WorkspaceRoomsPage (React Compiler handles it)
Consolidate two useDerivedReportNameByReportID calls into one useDerivedReportNamesByReportIDs call to reduce Onyx subscriptions.
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
No product review needed |
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-08-18.at.14.40.08.mov |
|
@hoangzinh Please resolve conflict |
Done. I've resolved the merge conflicts. |
|
🚧 marcochavezf has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.4.56-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR. This is a pure internal refactor — it migrates the deprecated Since nothing about the product's observable behavior or workflows changes, no articles under |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.56-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Part of #66427. Part 5 — migrate deprecatedGetReportName → getReportName per directory src/pages/** + tests.
Next step:
Fixed Issues
$ #66427
PROPOSAL: #66427 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
1. Chat header - all report types
2. Browser tab title
3. Report details - title and subtitle
4. Room members
5. Invite to room
6. Share code / QR
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Recording.2026-07-27.233205.mp4