Skip to content

[Due for payment 2026-09-25] [Performance] ReportActionAvatars — remove the noRightMarginOnSubscriptContainer prop from ReportAvatar #99941

Closed

Description

@MelvinBot

Follow-up to #99351. Parent: #94589.

Problem

ReportAvatar exposes noRightMarginOnSubscriptContainer?: boolean — a one-off style flag whose only effect is to set styles.mr0 on the subscript avatar's container (ReportActionAvatars/index.tsx:220, :233).

A boolean that hard-codes one style value doesn't belong in the new connected-avatar API — the component already takes container styles directly. The redundancy is visible at the call sites, which pass the flag and the equivalent style prop:

The prop should have been dropped rather than carried forward when #99351 built the ReportAvatar dispatcher.

Deliverables

  • Remove noRightMarginOnSubscriptContainer from ReportAvatar's props.
  • Update the WorkspaceRoomsTableRow call sites to express the margin override through the existing container-style props.
  • Decide whether the prop can also be removed from ReportActionAvatars, or must stay for the remaining legacy consumer ReportActionItemSingle.tsx:174.
  • Verify no visual regression at each call site: workspace rooms table in both narrow and wide layouts, and subscript avatars in report actions.
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. MelvinBot commented on Aug 31, 2026

    @MelvinBot
    ContributorAuthor

    C+ review of #99351 should be valued at $125 instead of $250, since this ideally would have been caught in the review of that PR.

  2. huult commented on Sep 8, 2026

    @huult
    Contributor

    @jmusial are you going to work on this ticket?

  3. jmusial commented on Sep 8, 2026

    @jmusial
    Contributor

    @huult missed that one, sorry - will do soon

  4. jmusial commented on Sep 8, 2026

    @jmusial
    Contributor

    got draft, one note - it wasn't possible to fol it into existing props due to how margins are setup on MenuItem. Reworked into style, non boolean prop instead.

    Let me know what you think

  5. huult commented on Sep 10, 2026

    @huult
    Contributor

    @jmusial Thanks, that makes sense. I don't see a better approach for now, but I'll take another look once the PR is ready.

  6. added
    ReviewingHas a PR in review
    and removed
    ReviewingHas a PR in review
    on Sep 15, 2026
  7. changed the title [-][Performance] ReportActionAvatars — remove the noRightMarginOnSubscriptContainer prop from ReportAvatar[/-] [+][Due for payment 2026-09-25] [Performance] ReportActionAvatars — remove the noRightMarginOnSubscriptContainer prop from ReportAvatar[/+] on Sep 18, 2026
  8. 2 remaining items

  9. huult commented on Sep 19, 2026

    @huult
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      This is just a refactor.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Test:

    1. Open app, sign in to an account with a workspace.
    2. Navigate to Workspaces > [workspace] > Rooms.
    3. Verify that room avatars in the table render with no extra right margin.

    Do we agree 👍 or 👎

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 19, 2026
  11. melvin-bot commented on Sep 24, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  12. melvin-bot commented on Sep 24, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  13. huult commented on Sep 25, 2026

    @huult
  14. huult commented on Sep 25, 2026

    @huult
    Contributor

    C+ review of #99351 should be valued at $125 instead of $250, since this ideally would have been caught in the review of that PR.

    FYI @mallenexpensify

  15. mallenexpensify commented on Sep 26, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @huult due $125 via NewDot

  16. JmillsExpensify commented on Oct 14, 2026

    @JmillsExpensify
    Contributor

    $125 approved for @huult

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions