You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-09-25] [Performance] ReportActionAvatars — remove the noRightMarginOnSubscriptContainer prop from ReportAvatar #99941
A boolean that hard-codes one style value doesn't belong in the new connected-avatar API — the component already takes container styles directly. The redundancy is visible at the call sites, which pass the flag and the equivalent style prop:
got draft, one note - it wasn't possible to fol it into existing props due to how margins are setup on MenuItem. Reworked into style, non boolean prop instead.
changed the title [-][Performance] ReportActionAvatars — remove the noRightMarginOnSubscriptContainer prop from ReportAvatar[/-][+][Due for payment 2026-09-25] [Performance] ReportActionAvatars — remove the noRightMarginOnSubscriptContainer prop from ReportAvatar[/+]on Sep 18, 2026
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
This is just a refactor.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Open app, sign in to an account with a workspace.
Navigate to Workspaces > [workspace] > Rooms.
Verify that room avatars in the table render with no extra right margin.
Activity
MelvinBot commentedon Aug 31, 2026
C+ review of #99351 should be valued at $125 instead of $250, since this ideally would have been caught in the review of that PR.
huult commentedon Sep 8, 2026
@jmusial are you going to work on this ticket?
jmusial commentedon Sep 8, 2026
@huult missed that one, sorry - will do soon
jmusial commentedon Sep 8, 2026
got draft, one note - it wasn't possible to fol it into existing props due to how margins are setup on
MenuItem. Reworked into style, non boolean prop instead.Let me know what you think
huult commentedon Sep 10, 2026
@jmusial Thanks, that makes sense. I don't see a better approach for now, but I'll take another look once the PR is ready.
[-][Performance] ReportActionAvatars — remove the noRightMarginOnSubscriptContainer prop from ReportAvatar[/-][+][Due for payment 2026-09-25] [Performance] ReportActionAvatars — remove the noRightMarginOnSubscriptContainer prop from ReportAvatar[/+]2 remaining items
huult commentedon Sep 19, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
This is just a refactor.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Sep 24, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Sep 24, 2026
Payment Summary
Resolving PRs:
Remove the noRightMarginOnSubscriptContainer prop from ReportAvatar #100575
Contributor: @jmusial does not require payment (Contractor)
Reviewer: @huult owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
huult commentedon Sep 25, 2026
huult commentedon Sep 25, 2026
FYI @mallenexpensify
mallenexpensify commentedon Sep 26, 2026
Payment Summary
Contributor+: @huult due $125 via NewDot
JmillsExpensify commentedon Oct 14, 2026
$125 approved for @huult