Repository navigation
Remove the noRightMarginOnSubscriptContainer prop from ReportAvatar - #100575
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
🤖 Code reviewLGTM on the refactor — this is a clean 1:1 swap with no behavior change, and all 4 call sites were converted with none missed. Three non-blocking notes below, plus the PR body needs filling in before merge. CorrectnessThe old Notes
Needed before mergeThe PR body is a bare template: no explanation of change, no Verification detailsReviewed at
Reply with |
|
No product review needed. |
|
@jmusial could you sync with main? |
Reviewer Checklist
Screenshots/Videos |
|
@jmusial Tag me once you’ve resolved the conflicts, and I’ll approve this PR. |
|
@huult all yours |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.82-0 🚀
|
|
No help site changes are required for this PR, so I did not create a draft docs PR. This is an internal API refactor with no user-visible change. It swaps the boolean What I checkedThe diff only touches component props and their call sites:
Nothing in the diff changes what a customer sees or does:
Help site articles under @jmusial, there is no help site PR to link because this change is not customer-facing. Please confirm you agree that no docs update is needed. If you think an article does need updating, reply with which one and what changed, and I will open the draft PR. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.86-0 🚀
|
|
🤖 No help site changes are required. I did not create a docs draft PR. This PR is an internal API refactor with no user-facing change. It swaps the boolean Why nothing in
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.89-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.89-0 🚀
Bundle Size Analysis (Sentry): |





Explanation of Change
Replaces the boolean
noRightMarginOnSubscriptContainerprop onReportActionAvatarsandReportAvatarwith a genericsubscriptAvatarContainerStylestyle prop.Fixed Issues
$ #99941
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari