Repository navigation
Align distance rates toggle switches with the page's right inset - #100143
Conversation
Remove styles.mr2 from the hand-rolled 'Auto-update government rate' and 'Track tax' switch rows so all three toggles on the Distance rates Settings page sit at the same 20px right inset as the ToggleSettingOptionRow switch and the menu item chevrons above them. Co-authored-by: Alberto Gonzalez-Cela <Gonals@users.noreply.github.com>
|
The failing check is unrelated to this PR, so I did not push a fix. Analysis: The only other failing check, Why the test fails todayThe test derives its expected value from a different helper than production uses, and the two disagree about whether "the next Nth of the month" includes today:
They only diverge when Per Expensify's flaky-test policy I'm leaving
Tell me which and I'll do it — I can take #100134 as a separate PR if you want it closed out before the next 2nd. |
|
I pushed the fix — but to a separate PR, #100145, not to this branch.
Once #100145 merges, merge What was wrong, and what #100145 changesThe test derived its expected value from a different helper than production uses, and the two disagreed about whether "the next Nth of the month" includes today:
They only diverge when The fix does three things: pins the clock in the test with Local checks on that branch all pass — The only other failing check here, |
|
Nothing new to fix here — the fix is already written and green, and it's now waiting on you.
The chain is blocked on a human, not on code:
If you'd rather not wait, this check also passes on its own from 2026-09-03 onward — the failure is confined to the 2nd of the month. I'm deliberately not pushing the test fix into this branch. It touches
|
|
Test error unrelated |
|
Nothing to push here — but one thing from your last comment needs correcting.
The correction: you closed #100145 with "already fixed in a different PR" — it isn't. If closing #100145 was based on that misreading, say the word and I'll reopen it — at the point you closed it, it was test-only ( |
|
Nothing has changed since my last comment 3 minutes ago, so there's still nothing for me to push. The re-run at 12:30 UTC failed on the same date-dependent test, Re-triggering me won't move this. There is no commit I can make to this branch that turns One decision, whenever you get to it: reopen #100145 (or say the word and I will), or leave #100134 open for someone else to own. Either is fine — but if neither happens, this blocks every open PR again on 2026-10-02.
|
|
@Gonals could you sync with main? |
Reviewer Checklist
Screenshots/Videos |
…oggleAlignment Co-authored-by: Alberto Gonzalez-Cela <Gonals@users.noreply.github.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
The failing check was unrelated to this PR, and it's now fixed — I merged What was failing: Why: that test was date-dependent and failed on the 2nd of the month. It derived its expected value from a different helper than production uses, and the two disagreed about whether "the next Nth of the month" includes today. CI happened to run on 2026-09-02. This PR only removes The fix: this was already tracked and fixed on The only remaining red check is Root cause detail
The two only diverge when One thing I could not do: I tried to re-verify your test steps on web, since merging 219 commits could in principle disturb the layout. The browser session broke before I got anywhere — the dev server restarted mid-run and left the tab blank, so I never reached the Distance rates page. That's a test-harness failure, not a signal about this PR; the toggle alignment is unverified by me, so please eyeball it once before merging. |
|
🚧 Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.4.73-0 🚀
|
|
No help site changes are required for this PR, so I didn't create a docs PR. This PR removes What I checkedThe full diff is 2 additions and 2 deletions, both dropping
I reviewed the help site articles that document this page:
Per HELP_AUTHORING_GUIDELINES.md, articles document steps, labels, and outcomes — not pixel spacing or component layout. Nothing in these articles describes the alignment this PR changes, so every existing step remains accurate. @Gonals, no help site PR was needed here — please confirm you agree that this change is visual-only and doesn't affect any documented step. If you think an article should be updated anyway, reply with what you'd like changed and I'll open the draft PR. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |








Explanation of Change
Minor style change
Fixed Issues
$ #99925
PROPOSAL: #99925 (comment)
Tests
Offline tests
None
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari