You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-09-07] Payment issue for E/App PR#99433 #99949
@huult The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
It's a new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
In an account with a single workspace
Go to the workspace -> Distance Rates -> Settings and enable "Require GPS or map entry"
Go to the admins chat for the workspace and confirm the change was logged as a comment.
Click on + -> Track distance and confirm only Map and GPS tabs are visible
In an account with two workspaces
Go to one of the workspaces -> Distance Rates -> Settings and enable "Require GPS or map entry"
Click on + -> Track distance and confirm all options are available
Select manual and enter a distance.
On the next step, confirm that when the workspace with the setting enabled is selected, you are blocked by:
Enable the setting for the other workspace. Only Map/GPS tabs should be visible now.
In an account with Commuter exclusions beta enabled
Go to one of the workspaces -> Distance Rates -> Settings and enable Commuter exclusions
Confirm "Require GPS or map entry" is enabled automatically and locked. Trying to unset it displays:
Issue is ready for payment but no BZ is assigned. @mallenexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
If a post on the PR or the issue mentions a regression or a deploy blocker, the C+ must post on the issue before the payment date.
Post one of these two:
It was a regression. Say so. Pay drops 50% for each regression on the issue.
It was not a regression. Give the reason, and include all three:
Quote the sentence that settles it, as a blockquote. Use a screenshot only when the proof is visual.
Link the exact comment, not the issue,
State who closed the linked blocker and whether a PR closed it. A blocker the CME closed with no fix PR is not a regression. A blocker closed by a fix PR is one.
If the C+ does not post by the payment date, the CM assumes every mention of a regression or a deploy blocker reduces the amount.
The App side already copies requireMapOrGPS when duplicating a workspace; the value that sticks comes from the server-side DuplicatePolicy copy, which doesn't carry this brand new field yet. Reverting or patching App cannot fix this, and the server-side fix ships independently of the App deploy...
This was demoted from deploy-blocker status by @marcochavezf (comment) on that finding — #99433's App code already handles this correctly; the missing piece is the server-side DuplicatePolicy copy list, outside this PR's diff and outside the App repo. The issue is still open pending a backend-only fix; no App PR has closed or needs to close it.
Confirmed: PR #99433 added the new toggle and, in a later "visual fixes" commit within the same PR, switched it from a hand-rolled row to ToggleSettingOptionRow, which does not carry the extra styles.mr2 that the neighbouring hand-rolled rows on this page still have — an 8px right-margin mismatch.
Fixed by #100143, deployed to production in 9.4.73-3 (currently in the 7-day regression period). Root cause traces to a commit inside #99433, so this counts as a regression on that PR.
@mallenexpensify@Gonals Confirmed regression on #99925, but flagging it was purely cosmetic (8px margin), not yet in production, and fixed within days via #100143. please consider a reduced deduction given the low impact.
@huult thanks, that is the format the C+ doc asks for. You took each blocker separately and gave a source link for each.
#99806 is not a regression. Accepted. The issue is still open, no App PR closed it, and @marcochavezf demoted it on your finding. The missing piece is the server-side DuplicatePolicy copy list, outside this PR and outside this repo.
#99925 is a regression. You confirmed it, and #100143 fixed it.
Two of your three grounds for a smaller deduction do not hold:
"It never reached production" is not a defence. The regression window opens when the PR merges, not when it deploys. See CONTRIBUTING.md#regressions.
This one is a judgment call, not an automatic cut. @Gonals you were tagged above, so please weigh in.
My lean is $125. The past waivers each carried a second reason beyond the size of the fault, ie. the payee fixed it themselves at once (#97541) or the task was unusually complex (#97616). This one rests on size alone.
Claude posting on behalf of Matt. PAYRUBRICTEST v1
I'd vote against reduction for this one. It is a very small cosmetic issue I jumped to fix quickly. It didn't cost any relevant amount of time/resources.
Activity
melvin-bot commentedon Aug 31, 2026
@huult The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
huult commentedon Sep 1, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
It's a new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
In an account with a single workspace
In an account with two workspaces
In an account with Commuter exclusions beta enabled
Do we agree 👍 or 👎
melvin-bot commentedon Sep 6, 2026
Auto-assign attempt failed, all eligible assignees are OOO.
melvin-bot commentedon Sep 6, 2026
Issue is ready for payment but no BZ is assigned. @mallenexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Sep 6, 2026
Payment Summary
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Sep 8, 2026
@huult from the C+ doc
mallenexpensify commentedon Sep 8, 2026
@huult 👀 above plz
huult commentedon Sep 9, 2026
#99806 Not a regression.
The App side already copies
requireMapOrGPSwhen duplicating a workspace; the value that sticks comes from the server-side DuplicatePolicy copy, which doesn't carry this brand new field yet. Reverting or patching App cannot fix this, and the server-side fix ships independently of the App deploy...Source: comment
This was demoted from deploy-blocker status by @marcochavezf (comment) on that finding — #99433's App code already handles this correctly; the missing piece is the server-side DuplicatePolicy copy list, outside this PR's diff and outside the App repo. The issue is still open pending a backend-only fix; no App PR has closed or needs to close it.
#99925 It was a regression.
Confirmed: PR #99433 added the new toggle and, in a later "visual fixes" commit within the same PR, switched it from a hand-rolled row to ToggleSettingOptionRow, which does not carry the extra styles.mr2 that the neighbouring hand-rolled rows on this page still have — an 8px right-margin mismatch.
Source: comment
Fixed by #100143, deployed to production in 9.4.73-3 (currently in the 7-day regression period). Root cause traces to a commit inside #99433, so this counts as a regression on that PR.
@mallenexpensify @Gonals Confirmed regression on #99925, but flagging it was purely cosmetic (8px margin), not yet in production, and fixed within days via #100143. please consider a reduced deduction given the low impact.
huult commentedon Sep 9, 2026
Sorry, @mallenexpensify, about this. I'm updating it and adding a comment above.
mallenexpensify commentedon Sep 9, 2026
Claude posting on behalf of Matt:
@huult thanks, that is the format the C+ doc asks for. You took each blocker separately and gave a source link for each.
#99806 is not a regression. Accepted. The issue is still open, no App PR closed it, and @marcochavezf demoted it on your finding. The missing piece is the server-side DuplicatePolicy copy list, outside this PR and outside this repo.
#99925 is a regression. You confirmed it, and #100143 fixed it.
Two of your three grounds for a smaller deduction do not hold:
The third ground holds. The fault was visual only, an 8px right margin, and one 2-line PR fixed it.
So the position is:
This one is a judgment call, not an automatic cut. @Gonals you were tagged above, so please weigh in.
My lean is $125. The past waivers each carried a second reason beyond the size of the fault, ie. the payee fixed it themselves at once (#97541) or the task was unusually complex (#97616). This one rests on size alone.
Claude posting on behalf of Matt.
PAYRUBRICTEST v1Gonals commentedon Sep 9, 2026
I'd vote against reduction for this one. It is a very small cosmetic issue I jumped to fix quickly. It didn't cost any relevant amount of time/resources.
mallenexpensify commentedon Sep 9, 2026
Payment Summary
Contributor+: @huult due $250 via NewDot
JmillsExpensify commentedon Oct 14, 2026
$250 approved for @huult