Skip to content

[Due for payment 2026-09-07] Payment issue for E/App PR#99433 #99949

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #99433
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/674995.
Contributor+ member who reviewed the PR - @huult.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Aug 31, 2026

    @melvin-bot
    Author

    @huult The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. huult commented on Sep 1, 2026

    @huult
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      It's a new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Test:

    In an account with a single workspace

    1. Go to the workspace -> Distance Rates -> Settings and enable "Require GPS or map entry"
    2. Go to the admins chat for the workspace and confirm the change was logged as a comment.
    3. Click on + -> Track distance and confirm only Map and GPS tabs are visible

    In an account with two workspaces

    1. Go to one of the workspaces -> Distance Rates -> Settings and enable "Require GPS or map entry"
    2. Click on + -> Track distance and confirm all options are available
    3. Select manual and enter a distance.
    4. On the next step, confirm that when the workspace with the setting enabled is selected, you are blocked by:
    Image
    1. Enable the setting for the other workspace. Only Map/GPS tabs should be visible now.

    In an account with Commuter exclusions beta enabled

    1. Go to one of the workspaces -> Distance Rates -> Settings and enable Commuter exclusions
    2. Confirm "Require GPS or map entry" is enabled automatically and locked. Trying to unset it displays:
    Image

    Do we agree 👍 or 👎

  3. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 1, 2026
  4. melvin-bot commented on Sep 6, 2026

    @melvin-bot
    Author

    Auto-assign attempt failed, all eligible assignees are OOO.

  5. melvin-bot commented on Sep 6, 2026

    @melvin-bot
    Author

    Issue is ready for payment but no BZ is assigned. @mallenexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  6. melvin-bot commented on Sep 6, 2026

    @melvin-bot
    Author

    Payment Summary

    • Reviewer: @huult owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  7. mallenexpensify commented on Sep 8, 2026

    @mallenexpensify
    Contributor

    Deploy Blocker #99806 was identified to be related to this PR.
    Deploy Blocker #99925 was identified to be related to this PR.

    @huult from the C+ doc

    If a post on the PR or the issue mentions a regression or a deploy blocker, the C+ must post on the issue before the payment date.

    Post one of these two:

    It was a regression. Say so. Pay drops 50% for each regression on the issue.

    It was not a regression. Give the reason, and include all three:

    • Quote the sentence that settles it, as a blockquote. Use a screenshot only when the proof is visual.
    • Link the exact comment, not the issue,
    • State who closed the linked blocker and whether a PR closed it. A blocker the CME closed with no fix PR is not a regression. A blocker closed by a fix PR is one.

    If the C+ does not post by the payment date, the CM assumes every mention of a regression or a deploy blocker reduces the amount.

  8. mallenexpensify commented on Sep 8, 2026

    @mallenexpensify
    Contributor

    @huult 👀 above plz

  9. huult commented on Sep 9, 2026

    @huult
    Contributor

    #99806 Not a regression.

    The App side already copies requireMapOrGPS when duplicating a workspace; the value that sticks comes from the server-side DuplicatePolicy copy, which doesn't carry this brand new field yet. Reverting or patching App cannot fix this, and the server-side fix ships independently of the App deploy...

    Source: comment

    This was demoted from deploy-blocker status by @marcochavezf (comment) on that finding — #99433's App code already handles this correctly; the missing piece is the server-side DuplicatePolicy copy list, outside this PR's diff and outside the App repo. The issue is still open pending a backend-only fix; no App PR has closed or needs to close it.

    #99925 It was a regression.

    Confirmed: PR #99433 added the new toggle and, in a later "visual fixes" commit within the same PR, switched it from a hand-rolled row to ToggleSettingOptionRow, which does not carry the extra styles.mr2 that the neighbouring hand-rolled rows on this page still have — an 8px right-margin mismatch.

    Source: comment

    Fixed by #100143, deployed to production in 9.4.73-3 (currently in the 7-day regression period). Root cause traces to a commit inside #99433, so this counts as a regression on that PR.

    @mallenexpensify @Gonals Confirmed regression on #99925, but flagging it was purely cosmetic (8px margin), not yet in production, and fixed within days via #100143. please consider a reduced deduction given the low impact.

  10. huult commented on Sep 9, 2026

    @huult
    Contributor

    @huult 👀 above plz

    Sorry, @mallenexpensify, about this. I'm updating it and adding a comment above.

  11. mallenexpensify commented on Sep 9, 2026

    @mallenexpensify
    Contributor

    Claude posting on behalf of Matt:

    @huult thanks, that is the format the C+ doc asks for. You took each blocker separately and gave a source link for each.

    #99806 is not a regression. Accepted. The issue is still open, no App PR closed it, and @marcochavezf demoted it on your finding. The missing piece is the server-side DuplicatePolicy copy list, outside this PR and outside this repo.

    #99925 is a regression. You confirmed it, and #100143 fixed it.

    Two of your three grounds for a smaller deduction do not hold:

    The third ground holds. The fault was visual only, an 8px right margin, and one 2-line PR fixed it.

    So the position is:

    This one is a judgment call, not an automatic cut. @Gonals you were tagged above, so please weigh in.

    My lean is $125. The past waivers each carried a second reason beyond the size of the fault, ie. the payee fixed it themselves at once (#97541) or the task was unusually complex (#97616). This one rests on size alone.


    Claude posting on behalf of Matt. PAYRUBRICTEST v1

  12. Gonals commented on Sep 9, 2026

    @Gonals
    Contributor

    I'd vote against reduction for this one. It is a very small cosmetic issue I jumped to fix quickly. It didn't cost any relevant amount of time/resources.

  13. mallenexpensify commented on Sep 9, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @huult due $250 via NewDot

  14. JmillsExpensify commented on Oct 14, 2026

    @JmillsExpensify
    Contributor

    $250 approved for @huult

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions