Repository navigation
[Payment due @Pujan92] Send the add_delegate and update_delegate validate code reasons - #100449
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…te-code-reason # Conflicts: # src/libs/API/parameters/ResendValidateCodeParams.ts
…-validate-code-reason # Conflicts: # src/libs/API/parameters/ResendValidateCodeParams.ts
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d279dd1a20
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| sendValidateCode={() => requestValidateCodeAction({reasonCode: COMMON_CONST.VALIDATE_CODE_REASONS.UPDATE_DELEGATE, reasonTargetEmail: login})} | ||
| validateCodeReasonCode={COMMON_CONST.VALIDATE_CODE_REASONS.UPDATE_DELEGATE} |
There was a problem hiding this comment.
Include the target email in resend deduplication
When roles for two different copilot emails are changed within REQUEST_CODE_DELAY, the second screen is treated as the same flow because ValidateCodeActionContent compares only lastValidateCodeReason. It therefore skips this sendValidateCode call even though reasonTargetEmail differs, so no email naming the second copilot is sent and the countdown prevents an immediate resend. Persist and compare the target email as part of the deduplication key; the new add_delegate flow has the same issue.
Useful? React with 👍 / 👎.
dylanexpensify
left a comment
There was a problem hiding this comment.
good from product POV
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2026-09-22.at.17.35.46.mov |
|
@Pujan92 updated the testing steps please check |
|
@allgandalf I am not seeing the updated copy in the email. Are BE changes deployed? |
|
Please use the staging toggle, the PR is yet to reach prod, it should happen on monday , but you can test using staging toggle for now |
|
Staging toggle is already on, but not able to see it yet |
|
🎯 @Pujan92, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
🚧 chuckdries has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/chuckdries in version: 9.4.94-0 🚀
|
|
No help site changes are needed for this PR, so I didn't create a docs PR. This PR only changes the text of the magic code email sent when you add a copilot or change a copilot's role. The email now names the person getting access. No feature names, buttons, settings labels, or steps change in the app. What I checked
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #102452 |
Explanation of Change
Passes the
add_delegatereason when you invite a copilot and theupdate_delegatereason when you change a copilot's role, so the magic code email says who is getting access or whose role is changing instead of nothing.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/679000
$ https://github.com/Expensify/Expensify/issues/679001
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari