Repository navigation
[Payment due @Pujan92] Send the add_delegate and update_delegate validate code reasons #100449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chuckdries
merged 12 commits into
Expensify:main
from
allgandalf:update-delegate-validate-code-reason
Sep 24, 2026
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9eeb4d3
require reasonTargetEmail for the add_delegate reason
allgandalf 2e80600
send the add_delegate reason when inviting a copilot
allgandalf 3904efc
scope the resend dedup to the add_delegate reason
allgandalf 8d940d0
run oxfmt on the delegate validate code page
allgandalf fa294cb
require reasonTargetEmail for the update_delegate reason
allgandalf 0c467ec
send the update_delegate reason when changing a copilot role
allgandalf f164e8e
Merge remote-tracking branch 'upstream/main' into add-delegate-valida…
allgandalf bc4a279
bump expensify-common to 2.0.204
allgandalf 1df8592
Merge branch 'add-delegate-validate-code-reason' into update-delegate…
allgandalf e39cd44
restore the action bundles the merge rebuilt
allgandalf 187fbfc
rebuild the action bundles for expensify-common 2.0.204
allgandalf d279dd1
Merge branch 'add-delegate-validate-code-reason' into update-delegate…
allgandalf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When roles for two different copilot emails are changed within
REQUEST_CODE_DELAY, the second screen is treated as the same flow becauseValidateCodeActionContentcompares onlylastValidateCodeReason. It therefore skips thissendValidateCodecall even thoughreasonTargetEmaildiffers, so no email naming the second copilot is sent and the countdown prevents an immediate resend. Persist and compare the target email as part of the deduplication key; the newadd_delegateflow has the same issue.Useful? React with 👍 / 👎.