Skip to content

Revert "🍒 Cherry pick PR #101459 to production 🍒" - #101603

Merged
Beamanator merged 1 commit into
productionfrom
revert-101598-cherry-pick-production-101459-35370059055-1
Sep 18, 2026
Merged

Beamanator merged 1 commit into
productionfrom
revert-101598-cherry-pick-production-101459-35370059055-1

Conversation

@Julesssss

Copy link
Copy Markdown
Contributor

@Julesssss
Julesssss requested review from a team as code owners September 18, 2026 18:07
@melvin-bot
melvin-bot Bot requested review from flaviadefaria and removed request for a team September 18, 2026 18:07
@melvin-bot
melvin-bot Bot requested review from grgia and removed request for a team September 18, 2026 18:08
@melvin-bot

melvin-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Beamanator
Beamanator merged commit 1f1250c into production Sep 18, 2026
14 of 15 checks passed
@Beamanator
Beamanator deleted the revert-101598-cherry-pick-production-101459-35370059055-1 branch September 18, 2026 18:09

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dfb1b4a99a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread android/app/build.gradle
Comment on lines +114 to +115
versionCode 1009048101
versionName "9.4.81-1"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep mobile release build numbers monotonic

When this revision is released after its parent production build, lowering versionCode from 1009048500 to 1009048101 makes the Android package older than the already-issued 9.4.85 build, so stores will reject it as an update and installed clients cannot upgrade to it. The same revert also lowers the iOS and package versions and rewinds the Mobile-Expensify pointer; revert the feature code without rolling back the release metadata.

Useful? React with 👍 / 👎.

const variant = getProductMarketingAnnouncementVariant(announcement, !!targetAdminPolicyID, lastDismissedMarketingWindow);
const isVendorMatchingBetaEnabled = isBetaEnabled(CONST.BETAS.VENDOR_MATCHING);
const shouldPrefetchTargetPolicyConnections = !!targetAdminPolicyID && targetAdminPolicyID !== activePolicyID;
const shouldPrefetchTargetPolicyConnections = isVendorMatchingBetaEnabled && !!targetAdminPolicyID && targetAdminPolicyID !== activePolicyID;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Prefetch fallback connections for GA QBO workspaces

When the selected admin workspace differs from the active workspace and the account lacks the vendor-matching beta, this condition skips connection hydration even though QBO vendor matching is GA and hasVendorFeature() deliberately does not require the beta for QBO. If that fallback policy is cached without its connections, the CTA immediately treats connection data as available and routes a QBO-enabled admin to More Features instead of Vendors; the fallback connection prefetch must not be conditioned solely on this beta.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants