Repository navigation
Revert "🍒 Cherry pick PR #101459 to production 🍒" - #101603
Beamanator merged 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfb1b4a99a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| versionCode 1009048101 | ||
| versionName "9.4.81-1" |
There was a problem hiding this comment.
Keep mobile release build numbers monotonic
When this revision is released after its parent production build, lowering versionCode from 1009048500 to 1009048101 makes the Android package older than the already-issued 9.4.85 build, so stores will reject it as an update and installed clients cannot upgrade to it. The same revert also lowers the iOS and package versions and rewinds the Mobile-Expensify pointer; revert the feature code without rolling back the release metadata.
Useful? React with 👍 / 👎.
| const variant = getProductMarketingAnnouncementVariant(announcement, !!targetAdminPolicyID, lastDismissedMarketingWindow); | ||
| const isVendorMatchingBetaEnabled = isBetaEnabled(CONST.BETAS.VENDOR_MATCHING); | ||
| const shouldPrefetchTargetPolicyConnections = !!targetAdminPolicyID && targetAdminPolicyID !== activePolicyID; | ||
| const shouldPrefetchTargetPolicyConnections = isVendorMatchingBetaEnabled && !!targetAdminPolicyID && targetAdminPolicyID !== activePolicyID; |
There was a problem hiding this comment.
Prefetch fallback connections for GA QBO workspaces
When the selected admin workspace differs from the active workspace and the account lacks the vendor-matching beta, this condition skips connection hydration even though QBO vendor matching is GA and hasVendorFeature() deliberately does not require the beta for QBO. If that fallback policy is cached without its connections, the CTA immediately treats connection data as available and routes a QBO-enabled admin to More Features instead of Vendors; the fallback connection prefetch must not be conditioned solely on this beta.
Useful? React with 👍 / 👎.
Reverts #101598
Resolve fire: https://expensify.enterprise.slack.com/archives/C0C31U55AA0