Repository navigation
Revert "🍒 Cherry pick PR #101459 to production 🍒" #101603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -92,7 +92,7 @@ function ProductMarketingWindowManager({topmostRouteName}: ProductMarketingWindo | |
| const illustrations = useMemoizedLazyIllustrations(illustrationNames); | ||
| const variant = getProductMarketingAnnouncementVariant(announcement, !!targetAdminPolicyID, lastDismissedMarketingWindow); | ||
| const isVendorMatchingBetaEnabled = isBetaEnabled(CONST.BETAS.VENDOR_MATCHING); | ||
| const shouldPrefetchTargetPolicyConnections = !!targetAdminPolicyID && targetAdminPolicyID !== activePolicyID; | ||
| const shouldPrefetchTargetPolicyConnections = isVendorMatchingBetaEnabled && !!targetAdminPolicyID && targetAdminPolicyID !== activePolicyID; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When the selected admin workspace differs from the active workspace and the account lacks the vendor-matching beta, this condition skips connection hydration even though QBO vendor matching is GA and Useful? React with 👍 / 👎. |
||
| const {isFetchNeeded, isLoadingFetchedFlag, hasBeenFetched} = usePolicyConnectionsPrefetch(targetAdminPolicy, shouldPrefetchTargetPolicyConnections); | ||
| const isAdminCtaPending = shouldPrefetchTargetPolicyConnections && (isLoadingFetchedFlag || (isFetchNeeded && hasBeenFetched === undefined)); | ||
| const isAdminPolicyConnectionDataAvailable = !shouldPrefetchTargetPolicyConnections || hasBeenFetched === true; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this revision is released after its parent production build, lowering
versionCodefrom1009048500to1009048101makes the Android package older than the already-issued 9.4.85 build, so stores will reject it as an update and installed clients cannot upgrade to it. The same revert also lowers the iOS and package versions and rewinds the Mobile-Expensify pointer; revert the feature code without rolling back the release metadata.Useful? React with 👍 / 👎.