Skip to content

[No QA] Docs updates for E/A#99385 attachment behavior when editing chat comments - #101640

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsAttachmentEditDownload
Closed

MelvinBot wants to merge 1 commit into
mainfrom
claude-docsAttachmentEditDownload

Conversation

@MelvinBot

Copy link
Copy Markdown

Explanation of Change

Documentation-only follow-up to Keep a file attachment intact when its comment is edited.

That PR fixed four things that are visible to members but were not described anywhere on the help site:

  • Editing a comment that holds a file attachment no longer degrades the attachment into a plain link — it stays a downloadable file card.
  • An edit saved while the attachment is still uploading (or while offline) no longer drops the file.
  • Renaming an attachment while editing now sticks, and the downloaded file keeps its original extension even if the new name leaves it off.
  • The context menu Download action now downloads the attachment instead of opening the chat URL.

docs/articles/new-expensify/chat/Chat-Features-and-Moderation-Tools.md documented how to Add attachment but never how to download one, and said nothing about what happens to an attachment when its message is edited. This PR fills that gap:

  • Adds a ## How to download a file attachment from a chat message section with web and mobile steps, and explains the download file-name behavior.
  • Adds a note under Edit or Delete Messages stating that editing changes only the message text and the attachment stays attached, including mid-upload.
  • Adds two FAQ entries: whether an attachment survives an edit, and how to rename an attachment.
  • Adds the required internalScope metadata field and extends description / keywords to match the new search intent.

UI labels used here were checked against the product rather than assumed. Add attachment was confirmed in the live web UI (composer + menu, alongside Create expense, Track distance, and Assign task), and Edit comment and Download were confirmed against src/languages/en.ts (reportActionContextMenu.editAction and common.download).

Applied per docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md. The article's pre-existing multiple # headings were left as-is — restructuring that legacy article is out of scope for this change.

Fixed Issues

$ #98743
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

Not applicable — documentation-only change.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@mukhrr, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Mukhriddin Shakhriyorov <mukhrr@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 18, 2026 20:46
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 18, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#99385 attachment behavior when editing chat comments [No QA] Docs updates for E/A#99385 attachment behavior when editing chat comments Sep 18, 2026
@OSBotify

Copy link
Copy Markdown

A preview of your ExpensifyHelp changes have been deployed to https://9335a623.helpdot.pages.dev ⚡️

Updated articles:

@mukhrr mukhrr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stephanieelliott

Copy link
Copy Markdown

Handling in #101950

bernhardoj pushed a commit to bernhardoj/Expensify that referenced this pull request Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants