Repository navigation
Conversation
Co-authored-by: Mukhriddin Shakhriyorov <mukhrr@users.noreply.github.com>
53 tasks done
|
A preview of your ExpensifyHelp changes have been deployed to https://9335a623.helpdot.pages.dev ⚡️ Updated articles: |
3 tasks
|
Handling in #101950 |
bernhardoj
pushed a commit
to bernhardoj/Expensify
that referenced
this pull request
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Documentation-only follow-up to Keep a file attachment intact when its comment is edited.
That PR fixed four things that are visible to members but were not described anywhere on the help site:
docs/articles/new-expensify/chat/Chat-Features-and-Moderation-Tools.mddocumented how to Add attachment but never how to download one, and said nothing about what happens to an attachment when its message is edited. This PR fills that gap:## How to download a file attachment from a chat messagesection with web and mobile steps, and explains the download file-name behavior.internalScopemetadata field and extendsdescription/keywordsto match the new search intent.UI labels used here were checked against the product rather than assumed. Add attachment was confirmed in the live web UI (composer
+menu, alongside Create expense, Track distance, and Assign task), and Edit comment and Download were confirmed againstsrc/languages/en.ts(reportActionContextMenu.editActionandcommon.download).Applied per
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md. The article's pre-existing multiple#headings were left as-is — restructuring that legacy article is out of scope for this change.Fixed Issues
$ #98743
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
Not applicable — documentation-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@mukhrr, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.