Repository navigation
[Payment due @truph01] Add natural language filter entry point to Spend page (re-PR with deploy blocker fixes) - #102237
Conversation
- Add CONST.BETAS.NL_FILTERS and gate the "Describe your search" entry point in the popup and full-screen page so only opted-in users see the feature - Disable the Apply button when the input is empty (#102200) - Call e.preventDefault() on Enter to stop newline insertion on web (#102174) - Wrap input section in ScrollView so the page scrolls in landscape (#102186)
Wrap new URL() in a try-catch so a malformed searchURL shows a proper error message instead of propagating to the outer catch handler and showing the generic "Something went wrong" toast.
# Conflicts: # src/components/Search/FilterComponents/AdvancedFilters/SearchNLFilterContent.tsx # src/components/Search/FilterDropdowns/SearchAdvancedFiltersPopup/index.tsx # src/pages/Search/SearchNLFilterPage.tsx
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…d main The merge with main (which had the NL filters revert) removed: - parseExpenseFilters function and PARSE_EXPENSE_FILTERS command from API types - ParseExpenseFiltersParams type - search.filters.describeSearch translation keys - Imports, hook calls, and helpers in SearchAdvancedFiltersPopup - closeOverlay prop threading through SearchAdvancedFiltersButton Re-adds all of the above so typecheck passes.
This comment has been minimized.
This comment has been minimized.
Adds SEARCH_NL_FILTER route and NL_FILTER_RHP screen, registers the page in the modal navigator, adds linking config, updates nav types, and adds a beta-gated "Describe your search" button to the mobile advanced filters page.
…escribe row doesn't expand it
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e790645b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@carlosmiceli Could you continue reviewing it? |
|
@carlosmiceli thanks, updated! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 marcaaron has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/marcaaron in version: 9.5.16-0 🚀
|
|
No help site update needed. Every user-facing change in this PR, including the "Describe your search" entry point and page, only appears for accounts on the |
|
Deploy Blocker #104631 was identified to be related to this PR. |
|
Deploy Blocker #104642 was identified to be related to this PR. |
|
Deploy Blocker #104658 was identified to be related to this PR. |
|
Deploy Blocker #104683 was identified to be related to this PR. |
|
🚀 Deployed to staging by https://github.com/marcaaron in version: 9.5.18-0 🚀
|
|
No help site update needed: the new "Describe your search" entry point in Advanced Filters only shows to accounts on the new |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.18-1 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #104877 |
Explanation of Change
Re-PR of the NL filters feature that was reverted from staging after QA found 9 deploy blockers. This addresses the 4 App-side blockers; 5 backend parsing fixes land in a companion Web-Expensify PR (https://github.com/Expensify/Web-Expensify/pull/56459).
Changes from the original reverted version:
nlFiltersbeta flag so the feature only shows to opted-in users -- prevents another mass revert if more issues surface before a full rolloutViewwith aScrollViewso the input is reachable in landscape (Android & iOS - Spend - Unable to scroll down Describe your search page in landscape #102186)Fixed Issues
$ https://github.com/Expensify/Expensify/issues/647828
$ #102200
$ https://github.com//Expensify/App/issues/102174
Tests
nlFiltersbeta.nlFiltersbeta.Offline tests
No offline behavior to test -- the NL filter requires a network call to parse the query; that already shows a loading state and the button is disabled while loading.
QA Steps
Scenario 1: Feature hidden for non-beta users
nlFiltersbeta enabled.Scenario 2: Apply button disabled when input is empty
nlFiltersbeta.Scenario 3: Enter key submits on web
Scenario 4: Landscape scroll on mobile
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari