Skip to content

Describe search - billable:no filter is applied when searching for non-reimbursable expenses #104658

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.16-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #102237
Email or phone of affected tester (no customers): jsoidjndoiniodnsjojd@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Enable nlFilters beta.
  1. Go to staging.new.expensify.com
  2. Go to Spend > Expenses.
  3. Open Filters > Describe your search.
  4. Type find non-reimbursable expenses > click Apply.

Expected Result:

reimbursable:no filter will be applied.

Actual Result:

billable:no filter is applied when searching for non-reimbursable expenses.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7292564_1792615496627.12.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7292564

Activity

  1. applause-bot commented on Oct 21, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/28bce201e910fd28185d8044425aafac7348d73970ab3cf46a7e52bb03dd54a5

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 21, 2026
  3. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #102237

  4. github-actions commented on Oct 21, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    @carlosmiceli @truph01 you have been assigned to this deploy blocker because you reviewed the offending PR: #102237

  6. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    @marcaaron you have been assigned to this deploy blocker because you authored the offending PR: #102237

  7. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Oct 21, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Recommendation: Demote (not a blocker). App is working correctly. The wrong billable:no filter comes from the backend's natural-language parser. The fix needs a backend change, so an internal engineer should handle it. No App change or revert is needed.

    Related PR: [Payment due @truph01] Add natural language filter entry point to Spend page (re-PR with deploy blocker fixes) adds the "Describe your search" entry point, but it does not create the wrong mapping.

    Why demote:

    Investigation details
    • src/libs/actions/Search.ts:1101-1112: parseExpenseFilters sends only {nlQuery, policyID, today} to ParseExpenseFilters and returns the server's searchURL unchanged.
    • SearchNLFilterContent.tsx:76-93: App reads q from that URL and navigates to it. App never builds or rewrites filter keys.
    • The PR diff contains no "reimbursable" or "billable" mapping or prompt.
    • App already supports the reimbursable search key (src/CONST/index.ts:9353). If the backend returns reimbursable:no, App applies it correctly.

    Other parsing bugs for this feature are also open as non-blockers:


    Next Steps: An internal owner should remove DeployBlockerCash and route the parser fix internally. Reply with @MelvinBot <your feedback> to refine this analysis.


    view run

  9. 6 remaining items

  10. melvin-bot commented on Oct 30, 2026

    @melvin-bot

    @marcaaron, @truph01 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  11. marcaaron commented on Nov 3, 2026

    @marcaaron
    Contributor

    Looking at this

  12. melvin-bot commented on Nov 4, 2026

    @melvin-bot

    @marcaaron @truph01 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  13. melvin-bot commented on Nov 6, 2026

    @melvin-bot

    @marcaaron, @truph01 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  14. marcaaron commented on Nov 7, 2026

    @marcaaron
    Contributor

    This will be closed by https://github.com/Expensify/Web-Expensify/pull/57891, which is merged. The parser prompt now maps non-reimbursable to reimbursable:no instead of billable:no.

  15. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    @marcaaron, @truph01 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. melvin-bot commented on Nov 12, 2026

    @melvin-bot

    @marcaaron, @truph01 Huh... This is 4 days overdue. Who can take care of this?

  17. expensify-chore-bot commented on Nov 18, 2026

    @expensify-chore-bot

    @marcaaron, @truph01 10 days overdue. Is anyone even seeing these? Hello?

  18. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    @marcaaron, @truph01 12 days overdue. Walking. Toward. The. Light...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringOverdue

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions