You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Describe search - billable:no filter is applied when searching for non-reimbursable expenses #104658
Version Number: 9.5.16-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#102237 Email or phone of affected tester (no customers):jsoidjndoiniodnsjojd@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Enable nlFilters beta.
Go to staging.new.expensify.com
Go to Spend > Expenses.
Open Filters > Describe your search.
Type find non-reimbursable expenses > click Apply.
Expected Result:
reimbursable:no filter will be applied.
Actual Result:
billable:no filter is applied when searching for non-reimbursable expenses.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Recommendation: Demote (not a blocker). App is working correctly. The wrong billable:no filter comes from the backend's natural-language parser. The fix needs a backend change, so an internal engineer should handle it. No App change or revert is needed.
src/libs/actions/Search.ts:1101-1112: parseExpenseFilters sends only {nlQuery, policyID, today} to ParseExpenseFilters and returns the server's searchURL unchanged.
Next Steps: An internal owner should remove DeployBlockerCash and route the parser fix internally. Reply with @MelvinBot <your feedback> to refine this analysis.
@marcaaron@truph01 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Activity
applause-bot commentedon Oct 21, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/28bce201e910fd28185d8044425aafac7348d73970ab3cf46a7e52bb03dd54a5
melvin-bot commentedon Oct 21, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #102237
github-actions commentedon Oct 21, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 21, 2026
@carlosmiceli @truph01 you have been assigned to this deploy blocker because you reviewed the offending PR: #102237
melvin-bot commentedon Oct 21, 2026
@marcaaron you have been assigned to this deploy blocker because you authored the offending PR: #102237
melvin-bot commentedon Oct 21, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Oct 21, 2026
Deploy Blocker Analysis
Recommendation: Demote (not a blocker). App is working correctly. The wrong
billable:nofilter comes from the backend's natural-language parser. The fix needs a backend change, so an internal engineer should handle it. No App change or revert is needed.Related PR: [Payment due @truph01] Add natural language filter entry point to Spend page (re-PR with deploy blocker fixes) adds the "Describe your search" entry point, but it does not create the wrong mapping.
Why demote:
nlFiltersbeta.marcaarondemoted the same type of parsing bug, Describe search - Keyword hasReceipt:yes is applied when searching for expenses with receipt, saying "This is behind a beta, not a blocker."Investigation details
src/libs/actions/Search.ts:1101-1112:parseExpenseFilterssends only{nlQuery, policyID, today}toParseExpenseFiltersand returns the server'ssearchURLunchanged.SearchNLFilterContent.tsx:76-93: App readsqfrom that URL and navigates to it. App never builds or rewrites filter keys.reimbursablesearch key (src/CONST/index.ts:9353). If the backend returnsreimbursable:no, App applies it correctly.Other parsing bugs for this feature are also open as non-blockers:
Next Steps: An internal owner should remove
DeployBlockerCashand route the parser fix internally. Reply with@MelvinBot <your feedback>to refine this analysis.view run
6 remaining items
melvin-bot commentedon Oct 30, 2026
@marcaaron, @truph01 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
marcaaron commentedon Nov 3, 2026
Looking at this
melvin-bot commentedon Nov 4, 2026
@marcaaron @truph01 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
melvin-bot commentedon Nov 6, 2026
@marcaaron, @truph01 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
marcaaron commentedon Nov 7, 2026
This will be closed by https://github.com/Expensify/Web-Expensify/pull/57891, which is merged. The parser prompt now maps non-reimbursable to
reimbursable:noinstead ofbillable:no.melvin-bot commentedon Nov 10, 2026
@marcaaron, @truph01 Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Nov 12, 2026
@marcaaron, @truph01 Huh... This is 4 days overdue. Who can take care of this?
expensify-chore-bot commentedon Nov 18, 2026
@marcaaron, @truph01 10 days overdue. Is anyone even seeing these? Hello?
expensify-chore-bot commentedon Nov 20, 2026
@marcaaron, @truph01 12 days overdue. Walking. Toward. The. Light...