Repository navigation
[Part 2] Refactor iou Hold functions to remove allReports onyx references - #102348
Conversation
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-10-02.at.14.05.56.mov |
ikevin127
left a comment
There was a problem hiding this comment.
🔴 The merge of main reverted the compiled bundles from main's undici 6.29.0 update (de30e671999). The newer header validation (isValidHeaderValue) is removed, and the verify job fails with "Diff found when Github Actions were rebuilt". Please restore them from main:
git checkout origin/main -- .github/actions/javascriptTests not updated
🟠 These fail on CI because they still assert on reportID or the old signature:
BaseReportActionContextMenuTest.tsx› calls unholdRequest when pressing the unhold actionuseSearchBulkActionsTest.ts› bulk unhold › calls unholdRequest with the live Onyx transaction…useSelectedTransactionsActions.test.ts› should show unhold option…, and › should pass isOffline=true…ReportUtilsTest.ts› changeMoneyRequestHoldStatus › should unhold request…
Could you also add a test for RemoveHoldPrimaryAction that checks changeMoneyRequestHoldStatus receives a defined report ? That would have caught the wrong key.
Please tag me for rereview once comments and issues are addressed 🙌
|
all fixed @ikevin127 |
|
PR description, Offline tests 🔴 Offline Test 2 (bulk unhold from Search while offline) can't be run: Search hides Remove hold while offline (
@parasharrajat Ready after these 4 items:
|
|
will update this soon. |
|
Ready @ikevin127 |
ikevin127
left a comment
There was a problem hiding this comment.
Thanks for addressing my previous 8 inline comments which are now fixed except the distinct-reports test ask.
@parasharrajat Ready after these 4 items:
- Assert the IOU report update in
HoldTest.tsso a report swap fails the test. - Drop the type casts in
RemoveHoldPrimaryAction.test.tsx. - Cover the multi-expense
IOUActionsloop inRemoveHoldPrimaryAction.test.tsx.
|
All set. |
ikevin127
left a comment
There was a problem hiding this comment.
🟢 LGTM - All previous comments are addressed, only one type cast left - should be fixed before merge but I won't block 🙌
|
Ready. |
|
@danieldoglas Ready for you! |
mountiny
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @parasharrajat and @ikevin127
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.33-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.5.33-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #66517
PROPOSAL:
Tests
Test 1 — Single unhold from the context menu
Test 2 — Single unhold from the report/expense header
Test 3 — Bulk unhold from Search
Offline tests
Test 1 — Single unhold offline
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
27.09.2026_14.13.04_REC.mp4