You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[No QA] Fix HoldTest types and the Bill Pay history actor that break main - #106277
main fails typecheck, test (job 5) and test (job 8). Each failure comes from two PRs that merged cleanly on their own but conflict together. This PR fixes both.
Result: typecheck fails with 2 errors. test (job 8) also fails, because unholdRequest reads the report status from transactionReport. Without it, the open report case never builds the next step.
Fix: the putOnHold test passes transactionReportActions: undefined, the same as the other tests in this file. The unholdRequest test passes transactionReport: iouReport and report: undefined, and no longer saves the report to Onyx first.
Result: Bill Pay history rows show the bill's receiver instead of the person who entered the bill. 12 tests in Bill Pay creation and submission history in tests/ui/ReportActionItemTest.tsx fail with Unable to find an element with text: Tom Jones (or Concierge).
Fix: useActionAvatar now does the same as useReportActionAvatars:
It reads isInvoiceLinkedToBill and the bill's processor, and passes them to getReportActionActorAccountID.
It shows the Concierge avatar when Concierge is the Bill Pay actor.
Fixed Issues
$ N/A
PROPOSAL: N/A
Tests
Run npm run typecheck and confirm it passes.
Run npx jest tests/actions/IOUTest/HoldTest.ts and confirm all 38 tests pass.
Run npx jest tests/ui/ReportActionItemTest.tsx and confirm all 257 tests pass, including Bill Pay creation and submission history.
Run npx jest tests/unit/components/Avatar/connected/useActionAvatarTest.tsx tests/unit/ReportActionItemSingleTest.tsx tests/unit/useReportActionAvatarsTest.tsx and confirm they pass.
Verify that no errors appear in the JS console
Offline tests
N/A. The change reads data that is already in Onyx and makes no API calls.
QA Steps
[No QA] This fixes main. The Jest tests above cover the Bill Pay history behavior that this PR restores.
Verify that no errors appear in the JS console
PR Author Checklist
I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
I added steps for local testing in the Tests section
I added steps for the expected offline behavior in the Offline steps section
I added steps for Staging and/or Production testing in the QA steps section
I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
I verified that comments were added to code that is not self explanatory
I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
If any new file was added I verified that:
The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
A similar style doesn't already exist
The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
The assets are optimized and compressed (for SVG files, run npm run compress-svg)
The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
I verified that all the inputs inside a form are aligned with each other.
I added Design label and/or tagged @Expensify/design so the design team can review the changes.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
mountiny
changed the title
[No QA] Fix HoldTest calls to the updated putOnHold and unholdRequest params
[No QA] Fix HoldTest types and the Bill Pay history actor that break main
Nov 7, 2026
I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
I verified the steps for local testing are in the Tests section
I verified the steps for Staging and/or Production testing are in the QA steps section
I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
I verified that comments were added to code that is not self explanatory
I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
A similar component doesn't exist in the codebase
All props are defined accurately and each prop has a /** comment above it */
The file is named correctly
The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
The only data being stored in the state is data necessary for rendering and nothing else
For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
All JSX used for rendering exists in the render method
The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
A similar style doesn't already exist
The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
I verified that all the inputs inside a form are aligned with each other.
I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #106277 with the pinned Mobile-Expensify submodule.
No FullStory changes needed — this PR only fixes test compatibility and restores the correct actor/avatar in existing Bill Pay history rows, without adding new user-facing functionality.
No help site update needed — this PR restores expected bill history attribution and fixes test parameters; it adds no new workflow and makes no existing article sentence incorrect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
mainfailstypecheck,test (job 5)andtest (job 8). Each failure comes from two PRs that merged cleanly on their own but conflict together. This PR fixes both.1.
HoldTest.ts: typecheck andtest (job 8)putOnHoldandunholdRequestwith their old parameters.transactionReportActionsa required parameter ofputOnHold, and [Part 2] Refactor iou Hold functions to remove allReports onyx references #102348 madetransactionReportandreportrequired parameters ofunholdRequest.test (job 8)also fails, becauseunholdRequestreads the report status fromtransactionReport. Without it, the open report case never builds the next step.putOnHoldtest passestransactionReportActions: undefined, the same as the other tests in this file. TheunholdRequesttest passestransactionReport: iouReportandreport: undefined, and no longer saves the report to Onyx first.2.
useActionAvatar.ts:test (job 5)processoron the bill's created action. If the bill came from an email, it credits Concierge. It added this logic touseReportActionAvatars.ReportActionItemSingleto the newuseActionAvatarhook. Its branch started before Show separate creation and submission history for bills and linked invoices #105815 merged, so the new hook never got the Bill Pay logic.Bill Pay creation and submission historyintests/ui/ReportActionItemTest.tsxfail withUnable to find an element with text: Tom Jones(orConcierge).useActionAvatarnow does the same asuseReportActionAvatars:isInvoiceLinkedToBilland the bill'sprocessor, and passes them togetReportActionActorAccountID.Fixed Issues
$ N/A
PROPOSAL: N/A
Tests
npm run typecheckand confirm it passes.npx jest tests/actions/IOUTest/HoldTest.tsand confirm all 38 tests pass.npx jest tests/ui/ReportActionItemTest.tsxand confirm all 257 tests pass, includingBill Pay creation and submission history.npx jest tests/unit/components/Avatar/connected/useActionAvatarTest.tsx tests/unit/ReportActionItemSingleTest.tsx tests/unit/useReportActionAvatarsTest.tsxand confirm they pass.Offline tests
N/A. The change reads data that is already in Onyx and makes no API calls.
QA Steps
[No QA] This fixes
main. The Jest tests above cover the Bill Pay history behavior that this PR restores.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Not yet tested — needs manual QA.
Android: mWeb Chrome
Not yet tested — needs manual QA.
iOS: Native
Not yet tested — needs manual QA.
iOS: mWeb Safari
Not yet tested — needs manual QA.
MacOS: Chrome / Safari
Not yet tested — needs manual QA.