Repository navigation
ReportActionAvatars - ReportActionItemSingle migration - #105254
roryabraham merged 8 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@MelvinBot review |
ReviewThe PR looks good overall. IOU previews and ordinary messages render the same as on 1. Invoice previews with no workspace
The same changes go the other way when the room loads without a 2.
To fix both, pass the preview action into 3. Minor: the child report's What I checked and found equivalentI compared the old
|
|
@MelvinBot recheck plz |
RecheckAll three points are addressed in
The new personal-details selectors in
Non-blocking edge case: the sender stand-in is applied after CI: |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
I lost track of this PR on the K2 extension. I'll prioritize reviewing it today |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppaz_recorder_20261105_161502.1.mp4Android: mWeb Chromeaz_recorder_20261105_161936.2.mp4iOS: HybridAppCleanShot.2026-11-05.at.16.49.31.4.mp4iOS: mWeb SafariCleanShot.2026-11-05.at.16.49.31.4.mp4MacOS: Chrome / SafariCleanShot.2026-11-05.at.16.13.48.3.mp4CleanShot.2026-11-05.at.16.52.41.6.mp4AutomationSame Onyx data rendered on this PR (with `main` merged) and on `main`: layout, header, accessibility label and navigation target match in every case
web.mp4 |
|
The implementation LGTM. I just found an existing bug while testing as a copilot, It also happens on staging, so it should be tracked as a separate issue:
Inconsistent display & avatarCleanShot.2026-11-05.at.16.52.41.6.mp4So this isn't a blocker for moving this PR forward |
| * IOU and invoice report previews come from their report's avatar hooks. Every other action follows the rules of `useReportActionAvatars`, | ||
| * subscribing only to what its kind of action reads. | ||
| */ | ||
| function useActionAvatar({action: passedAction, report, shouldUseRealActor}: UseActionAvatarParams): ActionAvatarData { |
There was a problem hiding this comment.
Didn't see anything obvious, but this is a super complex hook that's doing a ton for something that runs on every ReportAction in a chat or report view. We should look closer at it in a follow-up.
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.34-0 🚀
|
|
No help site update needed — this PR refactors avatar rendering and fixes invoice accessibility labels and loading-state behavior without adding a workflow or making any existing article sentence incorrect. |
|
No FullStory changes needed — this PR refactors avatar rendering and fixes invoice accessibility labels and loading-state fallbacks without adding new user flows, controls, screens, or tracking requirements. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.34-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
ReportActionItemSingleused to calluseReportActionAvatarstwice per row, once for the header and once insideReportActionAvatars. Now it calls a newuseActionAvatarhook once and renders the avatar layout directly.IOU and invoice previews go through
useIOUReportIconsanduseInvoiceReportIcons, which are extracted fromIOUReportAvatarandInvoiceReportAvatar.Behavior changes:
policyIDyet but the invoice has one, the preview shows the sending workspace instead of the sender, asInvoiceReportAvataralready does in the LHN.Fixed Issues
$ #94588
PROPOSAL:
Tests
In each chat below, check that the message avatars and sender names look the same as on
main.type:chatand open the chat from step 2. Both avatars still show.Offline tests
Go offline and change your avatar. Your message avatars show as pending, and the pending state clears once you're back online.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
action-avatar-retest-android.mp4
Android: mWeb Chrome
action-avatar-retest-android-chrome.mp4
iOS: Native
action-avatar-retest-ios.mp4
iOS: mWeb Safari
action-avatar-retest-ios-safari.mp4
MacOS: Chrome / Safari
action-avatar-retest.mp4