Repository navigation
Show separate creation and submission history for bills and linked invoices - #105815
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment has been minimized.
This comment has been minimized.
…es linked to bills
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 36079041..79ee64b7 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -36,8 +36,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
type AllCountries = Record<Country, string>;
const translations: TranslationDeepObject<typeof en> = {
billPay: {
- billSubmitted: ({sender, receiver}) => `hat diese Rechnung im Namen von ${sender} erstellt\nhat diese Rechnung an ${receiver} gesendet`,
- invoiceSubmitted: ({sender, receiver}) => `hat diese Rechnung im Namen von ${sender} erstellt\nhat diese Rechnung an ${receiver} gesendet`,
+ billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `hat diese Rechnung im Namen von ${sender} erstellt
+hat diese Rechnung an ${receiver} gesendet`,
+ invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `hat diese Rechnung im Namen von ${sender} erstellt
+hat diese Rechnung an ${receiver} gesendet`,
},
common: {
durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/el.ts b/src/languages/el.ts
index 77e608ba..e9d99011 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -33,8 +33,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
type AllCountries = Record<Country, string>;
const translations: TranslationDeepObject<typeof en> = {
billPay: {
- billSubmitted: ({sender, receiver}) => `δημιούργησε αυτόν τον λογαριασμό εκ μέρους του ${sender}\nέστειλε αυτόν τον λογαριασμό στον ${receiver}`,
- invoiceSubmitted: ({sender, receiver}) => `δημιούργησε αυτό το τιμολόγιο εκ μέρους του ${sender}\nέστειλε αυτό το τιμολόγιο στον ${receiver}`,
+ billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `δημιούργησε αυτόν τον λογαριασμό εκ μέρους του/της ${sender}
+έστειλε αυτόν τον λογαριασμό στον/στην ${receiver}`,
+ invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `δημιούργησε αυτό το τιμολόγιο για λογαριασμό του/της ${sender}
+έστειλε αυτό το τιμολόγιο στον/στην ${receiver}`,
},
common: {
durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/es.ts b/src/languages/es.ts
index cfa83797..1e576e2c 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -22,8 +22,10 @@ import type {AllConnectionName, PolicyConnectionSyncStage} from './TranslationTy
import type {TranslationDeepObject} from './types';
const translations: TranslationDeepObject<typeof en> = {
billPay: {
- billSubmitted: ({sender, receiver}) => `creó esta factura en nombre de ${sender}\nenvió esta factura a ${receiver}`,
- invoiceSubmitted: ({sender, receiver}) => `creó esta factura en nombre de ${sender}\nenvió esta factura a ${receiver}`,
+ billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `creó esta factura en nombre de ${sender}
+envió esta factura a ${receiver}`,
+ invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `creó esta factura en nombre de ${sender}
+envió esta factura a ${receiver}`,
},
common: {
durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index dfd4df66..624dfb36 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -36,8 +36,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
type AllCountries = Record<Country, string>;
const translations: TranslationDeepObject<typeof en> = {
billPay: {
- billSubmitted: ({sender, receiver}) => `a créé cette facture au nom de ${sender}\na envoyé cette facture à ${receiver}`,
- invoiceSubmitted: ({sender, receiver}) => `a créé cette facture au nom de ${sender}\na envoyé cette facture à ${receiver}`,
+ billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `a créé cette facture pour le compte de ${sender}
+a envoyé cette facture à ${receiver}`,
+ invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `a créé cette facture au nom de ${sender}
+a envoyé cette facture à ${receiver}`,
},
common: {
durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 3b186b24..dbe2d23f 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -36,8 +36,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
type AllCountries = Record<Country, string>;
const translations: TranslationDeepObject<typeof en> = {
billPay: {
- billSubmitted: ({sender, receiver}) => `ha creato questa fattura per conto di ${sender}\nha inviato questa fattura a ${receiver}`,
- invoiceSubmitted: ({sender, receiver}) => `ha creato questa fattura per conto di ${sender}\nha inviato questa fattura a ${receiver}`,
+ billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `ha creato questo conto per conto di ${sender}
+ha inviato questo conto a ${receiver}`,
+ invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `ha creato questa fattura per conto di ${sender}
+ha inviato questa fattura a ${receiver}`,
},
common: {
durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 19303dc1..f1e6129e 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -36,8 +36,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
type AllCountries = Record<Country, string>;
const translations: TranslationDeepObject<typeof en> = {
billPay: {
- billSubmitted: ({sender, receiver}) => `${sender} に代わってこの請求書を作成しました\nこの請求書を ${receiver} に送信しました`,
- invoiceSubmitted: ({sender, receiver}) => `${sender} に代わってこの請求書を作成しました\nこの請求書を ${receiver} に送信しました`,
+ billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `${sender}の代理としてこの請求書を作成しました
+この請求書を${receiver}に送信しました`,
+ invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `${sender} に代わってこの請求書を作成しました
+この請求書を ${receiver} に送信しました`,
},
common: {
durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 958c181b..56007535 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -36,8 +36,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
type AllCountries = Record<Country, string>;
const translations: TranslationDeepObject<typeof en> = {
billPay: {
- billSubmitted: ({sender, receiver}) => `heeft deze factuur aangemaakt namens ${sender}\nheeft deze factuur verzonden naar ${receiver}`,
- invoiceSubmitted: ({sender, receiver}) => `heeft deze factuur aangemaakt namens ${sender}\nheeft deze factuur verzonden naar ${receiver}`,
+ billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `heeft deze rekening aangemaakt namens ${sender}
+heeft deze rekening verzonden naar ${receiver}`,
+ invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `heeft deze factuur aangemaakt namens ${sender}
+heeft deze factuur verzonden naar ${receiver}`,
},
common: {
durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 425baba2..a2ca0a85 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -36,8 +36,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
type AllCountries = Record<Country, string>;
const translations: TranslationDeepObject<typeof en> = {
billPay: {
- billSubmitted: ({sender, receiver}) => `utworzono ten rachunek w imieniu ${sender}\nwysłano ten rachunek do ${receiver}`,
- invoiceSubmitted: ({sender, receiver}) => `utworzono tę fakturę w imieniu ${sender}\nwysłano tę fakturę do ${receiver}`,
+ billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `utworzył ten rachunek w imieniu użytkownika ${sender}
+wysłał ten rachunek do użytkownika ${receiver}`,
+ invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `utworzył ten rachunek w imieniu ${sender}
+wysłał ten rachunek do ${receiver}`,
},
common: {
durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 5dd2cf8a..16f1025b 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -36,8 +36,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
type AllCountries = Record<Country, string>;
const translations: TranslationDeepObject<typeof en> = {
billPay: {
- billSubmitted: ({sender, receiver}) => `criou esta conta em nome de ${sender}\nenviou esta conta para ${receiver}`,
- invoiceSubmitted: ({sender, receiver}) => `criou esta fatura em nome de ${sender}\nenviou esta fatura para ${receiver}`,
+ billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `criou esta cobrança em nome de ${sender}
+enviou esta cobrança para ${receiver}`,
+ invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `criou esta fatura em nome de ${sender}
+enviou esta fatura para ${receiver}`,
},
common: {
durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index e75c76e9..0e4142c5 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -36,8 +36,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
type AllCountries = Record<Country, string>;
const translations: TranslationDeepObject<typeof en> = {
billPay: {
- billSubmitted: ({sender, receiver}) => `代表 ${sender} 创建了此账单\n将此账单发送给 ${receiver}`,
- invoiceSubmitted: ({sender, receiver}) => `代表 ${sender} 创建了此发票\n将此发票发送给 ${receiver}`,
+ billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `代表 ${sender} 创建了此账单
+已将此账单发送给 ${receiver}`,
+ invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `代表 ${sender} 创建了此发票
+已将此发票发送给 ${receiver}`,
},
common: {
durationDays: ({count}: {count: number}) => ({
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
…n-history # Conflicts: # src/pages/inbox/report/ReportActionsList/useReportActionsListRenderItem.tsx
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.32-0 🚀
|
|
No help site update needed — this PR corrects bill and linked-invoice history wording and attribution without changing workflows or making existing article instructions incorrect. |
|
No FullStory changes needed. This PR only corrects bill and linked-invoice history wording, actor attribution, timestamps, and grouping within existing report views. |
|
Are we fixing that bill report UI elsewhere, yeah? |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.5.32-7 🚀
|


Explanation of Change
As per https://expensify.slack.com/archives/C0C3YKA2Z16/p1793665960275259, we're updating the submitted report action for bills invoices
Blls
In NewDot think should read:
Invoices
Fixed Issues
For https://github.com/Expensify/Expensify/issues/684654
PROPOSAL: N/A. Internal change requested in https://expensify.slack.com/archives/C0C3YKA2Z16/p1793665960275259.
Tests
created this bill on behalf of <sender>without submission text.sent this bill to <receiver>.created this invoice on behalf of <sender>without submission text.sent this invoice to <receiver>.Offline tests
Pending manual verification.
QA Steps
Web QA
Same as tests (cc @trjExpensify )
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Not recorded. Manual verification remains pending.
Android: mWeb Chrome
Not recorded. Manual verification remains pending.
iOS: Native
Not recorded. Manual verification remains pending.
iOS: mWeb Safari
Not recorded. Manual verification remains pending.
MacOS: Chrome / Safari
Intake Address
Invoice
Bill
Manual Creation
Invoice
Bill