Skip to content

Show separate creation and submission history for bills and linked invoices - #105815

Merged
roryabraham merged 9 commits into
mainfrom
carlos-bill-submission-history
Nov 4, 2026
Merged

roryabraham merged 9 commits into
mainfrom
carlos-bill-submission-history

Conversation

@cead22

@cead22 cead22 commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

As per https://expensify.slack.com/archives/C0C3YKA2Z16/p1793665960275259, we're updating the submitted report action for bills invoices

Blls

In NewDot think should read:

  • For the manually created bill case:
<avatar> Tom Rhys Jones <day time>
created this bill on behalf of <sender> 
sent this bill to <receiver>
  • For the case where the invoice was submitted to the bill intake address
<concierge avatar> Concierge <day time>
created this bill on behalf of <sender> 
sent this bill to <receiver>

Invoices

  • For the manually created bill case:
<avatar> Tom Rhys Jones <day time>
created this invoice on behalf of <sender>
sent this invoice to <receiver>
  • For the case where the invoice was submitted to the bill intake address:
<concierge avatar> Concierge <day time>
created this invoice on behalf of <sender>
sent this invoice to <receiver>

Fixed Issues

For https://github.com/Expensify/Expensify/issues/684654

PROPOSAL: N/A. Internal change requested in https://expensify.slack.com/archives/C0C3YKA2Z16/p1793665960275259.

Tests

  1. Open a manually created bill in New Expensify after the separate Bill Pay support changes are available.
  2. Confirm the creation action shows the creator's avatar, name, and creation timestamp.
  3. Confirm that action says created this bill on behalf of <sender> without submission text.
  4. Confirm the separate submission action shows the creator and the submission timestamp, with only sent this bill to <receiver>.
  5. Sign in as the vendor and open the invoice linked to that bill.
  6. Confirm the creation action shows the creator's avatar, name, and creation timestamp instead of the vendor's identity.
  7. Confirm that action says created this invoice on behalf of <sender> without submission text.
  8. Confirm the separate submission action shows the creator and the submission timestamp, with only sent this invoice to <receiver>.
  9. Email an invoice to the domain's bill intake address.
  10. Open the bill and the invoice that bill intake created.
  11. Confirm each creation and submission action shows Concierge's avatar, name, and the event's own timestamp.
  12. Open a bill whose current approver differs from its original receiver.
  13. Confirm the submission action names the original receiver.
  14. Add a comment immediately after a bill or invoice submission from the same account as the stored submission actor.
  15. Confirm the creation and submission actions keep separate actor headers, and the comment shows its own author.
  16. Repeat with bills whose policies require approval and whose policies disable approval.
  17. Send an ordinary invoice that is not linked to a bill.
  18. Confirm its submission keeps the vendor as actor and the usual wording.
  19. Open an ordinary expense report and confirm its submission wording does not change.
  20. Repeat with a single expense and multiple expenses. Confirm each history shows both events and the report header once.
  • Verify that no errors appear in the JS console

Offline tests

Pending manual verification.

  1. Open the manual bill, the emailed bill, and their linked invoices while online.
  2. Turn off the network connection.
  3. Reopen the history of each bill and invoice.
  4. Confirm each cached creation and submission action keeps its actor, participant, and timestamp.
  5. Restore the network connection.
  6. Confirm the history keeps the same actors and participant names.

QA Steps

Web QA

Same as tests (cc @trjExpensify )

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Not recorded. Manual verification remains pending.

Android: mWeb Chrome

Not recorded. Manual verification remains pending.

iOS: Native

Not recorded. Manual verification remains pending.

iOS: mWeb Safari

Not recorded. Manual verification remains pending.

MacOS: Chrome / Safari

Intake Address

Invoice

image

Bill

image

Manual Creation

Invoice

image

Bill

image

@cead22
cead22 requested review from a team as code owners November 3, 2026 20:53
@melvin-bot
melvin-bot Bot requested review from heyjennahay and removed request for a team November 3, 2026 20:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T21:01:35.802585Z b0a49f7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from carlosmiceli and removed request for a team November 3, 2026 20:53
@melvin-bot

melvin-bot Bot commented Nov 3, 2026

Copy link
Copy Markdown

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@OSBotify

This comment has been minimized.

@cead22 cead22 changed the title Show the creator and participants in bill submission history Show the creator and participants in bill and invoice submission history Nov 4, 2026
@OSBotify

OSBotify commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index 36079041..79ee64b7 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -36,8 +36,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
 type AllCountries = Record<Country, string>;
 const translations: TranslationDeepObject<typeof en> = {
     billPay: {
-        billSubmitted: ({sender, receiver}) => `hat diese Rechnung im Namen von ${sender} erstellt\nhat diese Rechnung an ${receiver} gesendet`,
-        invoiceSubmitted: ({sender, receiver}) => `hat diese Rechnung im Namen von ${sender} erstellt\nhat diese Rechnung an ${receiver} gesendet`,
+        billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `hat diese Rechnung im Namen von ${sender} erstellt
+hat diese Rechnung an ${receiver} gesendet`,
+        invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `hat diese Rechnung im Namen von ${sender} erstellt
+hat diese Rechnung an ${receiver} gesendet`,
     },
     common: {
         durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/el.ts b/src/languages/el.ts
index 77e608ba..e9d99011 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -33,8 +33,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
 type AllCountries = Record<Country, string>;
 const translations: TranslationDeepObject<typeof en> = {
     billPay: {
-        billSubmitted: ({sender, receiver}) => `δημιούργησε αυτόν τον λογαριασμό εκ μέρους του ${sender}\nέστειλε αυτόν τον λογαριασμό στον ${receiver}`,
-        invoiceSubmitted: ({sender, receiver}) => `δημιούργησε αυτό το τιμολόγιο εκ μέρους του ${sender}\nέστειλε αυτό το τιμολόγιο στον ${receiver}`,
+        billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `δημιούργησε αυτόν τον λογαριασμό εκ μέρους του/της ${sender}
+έστειλε αυτόν τον λογαριασμό στον/στην ${receiver}`,
+        invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `δημιούργησε αυτό το τιμολόγιο για λογαριασμό του/της ${sender}
+έστειλε αυτό το τιμολόγιο στον/στην ${receiver}`,
     },
     common: {
         durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/es.ts b/src/languages/es.ts
index cfa83797..1e576e2c 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -22,8 +22,10 @@ import type {AllConnectionName, PolicyConnectionSyncStage} from './TranslationTy
 import type {TranslationDeepObject} from './types';
 const translations: TranslationDeepObject<typeof en> = {
     billPay: {
-        billSubmitted: ({sender, receiver}) => `creó esta factura en nombre de ${sender}\nenvió esta factura a ${receiver}`,
-        invoiceSubmitted: ({sender, receiver}) => `creó esta factura en nombre de ${sender}\nenvió esta factura a ${receiver}`,
+        billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `creó esta factura en nombre de ${sender}
+envió esta factura a ${receiver}`,
+        invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `creó esta factura en nombre de ${sender}
+envió esta factura a ${receiver}`,
     },
     common: {
         durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index dfd4df66..624dfb36 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -36,8 +36,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
 type AllCountries = Record<Country, string>;
 const translations: TranslationDeepObject<typeof en> = {
     billPay: {
-        billSubmitted: ({sender, receiver}) => `a créé cette facture au nom de ${sender}\na envoyé cette facture à ${receiver}`,
-        invoiceSubmitted: ({sender, receiver}) => `a créé cette facture au nom de ${sender}\na envoyé cette facture à ${receiver}`,
+        billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `a créé cette facture pour le compte de ${sender}
+a envoyé cette facture à ${receiver}`,
+        invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `a créé cette facture au nom de ${sender}
+a envoyé cette facture à ${receiver}`,
     },
     common: {
         durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 3b186b24..dbe2d23f 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -36,8 +36,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
 type AllCountries = Record<Country, string>;
 const translations: TranslationDeepObject<typeof en> = {
     billPay: {
-        billSubmitted: ({sender, receiver}) => `ha creato questa fattura per conto di ${sender}\nha inviato questa fattura a ${receiver}`,
-        invoiceSubmitted: ({sender, receiver}) => `ha creato questa fattura per conto di ${sender}\nha inviato questa fattura a ${receiver}`,
+        billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `ha creato questo conto per conto di ${sender}
+ha inviato questo conto a ${receiver}`,
+        invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `ha creato questa fattura per conto di ${sender}
+ha inviato questa fattura a ${receiver}`,
     },
     common: {
         durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 19303dc1..f1e6129e 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -36,8 +36,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
 type AllCountries = Record<Country, string>;
 const translations: TranslationDeepObject<typeof en> = {
     billPay: {
-        billSubmitted: ({sender, receiver}) => `${sender} に代わってこの請求書を作成しました\nこの請求書を ${receiver} に送信しました`,
-        invoiceSubmitted: ({sender, receiver}) => `${sender} に代わってこの請求書を作成しました\nこの請求書を ${receiver} に送信しました`,
+        billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `${sender}の代理としてこの請求書を作成しました
+この請求書を${receiver}に送信しました`,
+        invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `${sender} に代わってこの請求書を作成しました  
+この請求書を ${receiver} に送信しました`,
     },
     common: {
         durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 958c181b..56007535 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -36,8 +36,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
 type AllCountries = Record<Country, string>;
 const translations: TranslationDeepObject<typeof en> = {
     billPay: {
-        billSubmitted: ({sender, receiver}) => `heeft deze factuur aangemaakt namens ${sender}\nheeft deze factuur verzonden naar ${receiver}`,
-        invoiceSubmitted: ({sender, receiver}) => `heeft deze factuur aangemaakt namens ${sender}\nheeft deze factuur verzonden naar ${receiver}`,
+        billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `heeft deze rekening aangemaakt namens ${sender}
+heeft deze rekening verzonden naar ${receiver}`,
+        invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `heeft deze factuur aangemaakt namens ${sender}
+heeft deze factuur verzonden naar ${receiver}`,
     },
     common: {
         durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 425baba2..a2ca0a85 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -36,8 +36,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
 type AllCountries = Record<Country, string>;
 const translations: TranslationDeepObject<typeof en> = {
     billPay: {
-        billSubmitted: ({sender, receiver}) => `utworzono ten rachunek w imieniu ${sender}\nwysłano ten rachunek do ${receiver}`,
-        invoiceSubmitted: ({sender, receiver}) => `utworzono tę fakturę w imieniu ${sender}\nwysłano tę fakturę do ${receiver}`,
+        billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `utworzył ten rachunek w imieniu użytkownika ${sender}
+wysłał ten rachunek do użytkownika ${receiver}`,
+        invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `utworzył ten rachunek w imieniu ${sender}  
+wysłał ten rachunek do ${receiver}`,
     },
     common: {
         durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 5dd2cf8a..16f1025b 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -36,8 +36,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
 type AllCountries = Record<Country, string>;
 const translations: TranslationDeepObject<typeof en> = {
     billPay: {
-        billSubmitted: ({sender, receiver}) => `criou esta conta em nome de ${sender}\nenviou esta conta para ${receiver}`,
-        invoiceSubmitted: ({sender, receiver}) => `criou esta fatura em nome de ${sender}\nenviou esta fatura para ${receiver}`,
+        billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `criou esta cobrança em nome de ${sender}
+enviou esta cobrança para ${receiver}`,
+        invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `criou esta fatura em nome de ${sender}
+enviou esta fatura para ${receiver}`,
     },
     common: {
         durationDays: ({count}: {count: number}) => ({
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index e75c76e9..0e4142c5 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -36,8 +36,10 @@ type States = Record<keyof typeof COMMON_CONST.STATES, StateValue>;
 type AllCountries = Record<Country, string>;
 const translations: TranslationDeepObject<typeof en> = {
     billPay: {
-        billSubmitted: ({sender, receiver}) => `代表 ${sender} 创建了此账单\n将此账单发送给 ${receiver}`,
-        invoiceSubmitted: ({sender, receiver}) => `代表 ${sender} 创建了此发票\n将此发票发送给 ${receiver}`,
+        billSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `代表 ${sender} 创建了此账单
+已将此账单发送给 ${receiver}`,
+        invoiceSubmitted: ({sender, receiver}: {sender: string; receiver: string}) => `代表 ${sender} 创建了此发票
+已将此发票发送给 ${receiver}`,
     },
     common: {
         durationDays: ({count}: {count: number}) => ({

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@cead22 cead22 changed the title Show the creator and participants in bill and invoice submission history Show separate creation and submission history for bills and linked invoices Nov 4, 2026
@cead22
cead22 requested review from roryabraham and removed request for carlosmiceli November 4, 2026 03:49
@cead22 cead22 added Internal Requires API changes or must be handled by Expensify staff InternalQA This pull request required internal QA and removed Internal Requires API changes or must be handled by Expensify staff labels Nov 4, 2026
@roryabraham
roryabraham merged commit 0dc7cb4 into main Nov 4, 2026
45 of 46 checks passed
@roryabraham
roryabraham deleted the carlos-bill-submission-history branch November 4, 2026 16:37
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #105815 with the pinned Mobile-Expensify submodule.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0dc7cb4b-4ae6788-2bd31b26ca63f3c01245e2428f1d85a7cdda7f60/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0dc7cb4b-4ae6788-af9bd59aa7f8ae6ecdde6cf4e5ae25dff554dfcf/index.html
Android iOS
Web 🕸️
❌ FAILED ❌
The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Nov 4, 2026
88 tasks done
@OSBotify

OSBotify commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.32-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR corrects bill and linked-invoice history wording and attribution without changing workflows or making existing article instructions incorrect.

@MelvinBot

Copy link
Copy Markdown
Contributor

No FullStory changes needed. This PR only corrects bill and linked-invoice history wording, actor attribution, timestamps, and grouping within existing report views.

@cead22

cead22 commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Not sure why the header isn't showing but the report actions look good on staging
Bill
image

Invoice
image

@trjExpensify

Copy link
Copy Markdown
Contributor

Are we fixing that bill report UI elsewhere, yeah?

@OSBotify

OSBotify commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.5.32-7 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

InternalQA This pull request required internal QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants