Repository navigation
[Insights Polish] Bar chart's bars and category labels - #102991
luacmartins merged 8 commits into
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@MelvinBot review |
Code reviewI found no blocking bugs. The cleanup removes every horizontal-bar symbol without leaving a dangling reference, and the hidden-label path works: an empty label layout returns
Minor: |
I think that's expected, right? @dannymcclain
fixed!
we do show the percentOfTotal data outside of beta too, in the tooltips |
Yeah I suppose this is expected with the new bar paradigm. @JmillsExpensify @Expensify/design should we maybe add a max-width to these bars so we don't get this situation? Something like this perhaps?
Here I'm using a max-width of 320px for the bars - but I just picked that semi-arbitrarily. TBH I'm not super duper concerned with this situation as it's really not our mainline use case here. |
|
Yeah, great catch. I'm a fan of using max-width for this case. No passionate on the actual width we land on, though your example looks fine. |
|
Big fan of that idea! |
|
🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
JmillsExpensify
left a comment
There was a problem hiding this comment.
The charts look really good!
|
@truph01 this is ready for your review. Please prioritize when you're next online. |
|
Also heads up that I noticed something in this PR, not sure if it's coming from this one or another one: On Home we are showing the table. We want to ensure that's an "Insight-exclusive." The overarching design for Home is that it's a preview of things, you can go to other parts of the app for details. |
yeah, it's coming from this PR, I'll remove it. should the Home bar charts keep their X axis labels then too? |
|
That's a great question. Danny, for Insights we show the x-axis for the headline/spend over time graph, but we don't show them for the ranking/top graphs. Should we keep that the same on Home too? |
removed! |
|
and while keeping in mind that we want to focus on Home and Insights for now, I'd like to make sure it's clear how this PR changes the bar charts in Spend: we keep the group labels there and remove the horizontal fallback when labels rotate to 90 degrees (undoes #99939) (cc: @Expensify/design)
|
|
@truph01 back to you |
|
🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-10-06.at.16.27.37.movAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safarioutput.mp4 |
|
@mhawryluk On mobile devices, I’m unable to long-press to see the details. Should we support long-press on mobile to show the details, similar to how we allow users to hover over the chart on wide screens? Screen.Recording.2026-10-06.at.16.31.17.mov |
We could, though this is currently the design spec (from the tracking issue).
I don't feel strongly about this, though the long-term design is to no longer take you to the Spend page on either platform, and instead, keep you on the Insights page. |
|
yeah, we'll implement changes regarding tap on mobile as part of this issue: #102865 |
|
Let's hold on merging this PR until Danny is online. |
|
This is looking great to me 🚀 And it will be even better once we implement the mobile tooltip changes—I know they're coming 😁 we just really need them for the mobile experience to make sense haha. |
|
We got the blessing from @dannymcclain, gonna merge! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.5.4-0 🚀
|
|
No help site update needed. This PR only changes how bar charts look: bar width, gaps, corners, colors, and labels. Horizontal bars and hidden labels were only visible behind the |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.4-3 🚀
Bundle Size Analysis (Sentry): |





Explanation of Change
Updates bar charts to match the new Insights designs:
Outside the
insightsPagebeta, Spend and Home bar charts also get the wider bars and 4px corners. Their labels are unchanged.Fixed Issues
$ #102863
PROPOSAL: N/A
Tests
insightsPagebeta.Offline tests
N/A
QA Steps
insightsPagebeta disabled.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: Native
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-10-05.at.14.16.29.mov
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-10-5.o.13.58.10.mov