Skip to content

[Insights polish] Mark the in-progress period on time-based charts - #103168

Merged
cristipaval merged 10 commits into
Expensify:mainfrom
software-mansion-labs:insights/partial-bucket
Oct 7, 2026
Merged

cristipaval merged 10 commits into
Expensify:mainfrom
software-mansion-labs:insights/partial-bucket

Conversation

@mhawryluk

@mhawryluk mhawryluk commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Explanation of Change

Marks the time bucket that contains today as in progress, so a partial total doesn't read as a drop in spend:

  • Detecting it: each date group-by (day, week, month, quarter, year) can now report the dates it covers. The group whose dates include today is treated as in progress.
  • Label: that group's label names how far it has got, followed by "so far", for example Oct 5 so far, Oct so far, Week of Oct 5 so far, Q4 so far or 2026 so far. It shows in tooltips, legends and inline tables for line, bar and donut charts. The x-axis label is unchanged.
  • Line chart: the segment leading into the in-progress point is dashed, the area fill stops at the last complete point, and the in-progress dot is drawn hollow. The dashed segment uses the same dash pattern as the gridlines.

Fixed Issues

$ #103089
PROPOSAL: N/A

Tests

  1. Open Spend over time on Insights with Last 12 months, grouped by month.
  2. Verify the line into the current month is dashed, and there's no area fill under it, the current month's dot is hollow, its x-axis label reads Oct '26 as usual, hovering it shows Oct so far in the tooltip.
  3. Switch the group-by and check the current bucket's tooltip:
    • Day: Oct (today's date) so far
    • Week: Week of Oct 5 so far
    • Quarter: Q4 so far
    • Year: 2026 so far
  4. Pick a range that ends before today, for example Last month. Verify nothing is dashed or hollow, and no label says "so far".
  5. Pick a custom range that ends today, verify the last segment is marked. Pick a custom range that ends after today, verify the last segment is marked. Pick a custom range that ends before today, verify the last segment is not marked.
  6. Pick Custom day set to today. Verify the single point shows Oct 6 so far, with no stray line and no fill.
  7. In Spend, group by month and switch to the Bar view, then the Pie view. Verify hovering the current month shows "so far", and the donut legend shows it too.

Offline tests

N/A

QA Steps

Same as tests, but test in Home and Spend, instead of Insights.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native Zrzut ekranu 2026-10-6 o 13 42 04
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-10-6.o.13.38.27.mov
Nagranie.z.ekranu.2026-10-6.o.13.43.18.mov

@melvin-bot

melvin-bot Bot commented Oct 6, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@mhawryluk

Copy link
Copy Markdown
Member Author

@MelvinBot review

@OSBotify

OSBotify commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index ce09105a..4a4ac7f8 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -10076,6 +10076,8 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
             title: 'Berichte zusammenführen',
             description: 'Wählen Sie den Bericht aus, der beibehalten werden soll. Alle Ausgaben werden in ihn verschoben und die anderen Berichte werden gelöscht.',
         },
+        periodSoFar: ({period}: {period: string}) => `${period} bisher`,
+        weekOf: ({date}: {date: string}) => `Woche vom ${date}`,
     },
     genericErrorPage: {
         title: 'Ups, da ist etwas schiefgelaufen!',
diff --git a/src/languages/el.ts b/src/languages/el.ts
index 6759a8aa..076ae5e8 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -10273,6 +10273,8 @@ ${reportName}`,
             title: 'Λήψη κατάστασης',
             oneFeedAtATime: 'Παρακαλούμε επιλέγετε διακανονισμούς από μία ροή Κάρτας Expensify κάθε φορά.',
         },
+        periodSoFar: ({period}: {period: string}) => `${period} μέχρι τώρα`,
+        weekOf: ({date}: {date: string}) => `Εβδομάδα από ${date}`,
     },
     genericErrorPage: {
         title: 'Ωχ, κάτι πήγε στραβά!',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 5f05b228..3bd5d18b 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -9891,6 +9891,8 @@ ${reportName}`,
             pleaseSelectDatesForBothFromAndTo: 'Por favor, selecciona fechas para Desde y Hasta',
         },
         mergeReports: {title: 'Combinar informes', description: 'Selecciona el informe que quieres conservar. Todos los gastos se moverán a él y los demás informes se eliminarán.'},
+        periodSoFar: ({period}: {period: string}) => `${period} hasta ahora`,
+        weekOf: ({date}: {date: string}) => `Semana del ${date}`,
     },
     genericErrorPage: {
         title: '¡Oh-oh, algo salió mal!',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 2f0e5b4b..d343567a 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -10099,6 +10099,8 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
             title: 'Fusionner des notes de frais',
             description: 'Sélectionnez la note de frais à conserver. Toutes les dépenses y seront déplacées et les autres notes de frais seront supprimées.',
         },
+        periodSoFar: ({period}: {period: string}) => `${period} jusqu’à présent`,
+        weekOf: ({date}: {date: string}) => `Semaine du ${date}`,
     },
     genericErrorPage: {
         title: 'Oups, quelque chose s’est mal passé !',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index d91cccc5..399f6812 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -10026,6 +10026,8 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
             violationsBySubmitter: 'Violazioni da parte dell’autore dell’invio',
         },
         mergeReports: {title: 'Unisci report', description: 'Seleziona il report da mantenere. Tutte le spese verranno spostate al suo interno e gli altri report verranno eliminati.'},
+        periodSoFar: ({period}: {period: string}) => `${period} finora`,
+        weekOf: ({date}: {date: string}) => `Settimana del ${date}`,
     },
     genericErrorPage: {
         title: 'Oops, qualcosa è andato storto!',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 1bce0fc6..b43c0470 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -9878,6 +9878,8 @@ ${reportName}`,
             violationsBySubmitter: '申請者による違反',
         },
         mergeReports: {title: 'レポートをマージする', description: '保持するレポートを選択してください。すべての経費はそのレポートに移動され、他のレポートは削除されます。'},
+        periodSoFar: ({period}: {period: string}) => `これまでの${period}`,
+        weekOf: ({date}: {date: string}) => `${date} の週`,
     },
     genericErrorPage: {
         title: 'おっと、問題が発生しました!',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 4fb2801b..e8f7c96a 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -9996,6 +9996,8 @@ er bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
             title: 'Rapporten samenvoegen',
             description: 'Selecteer het rapport dat je wilt behouden. Alle uitgaven worden daarheen verplaatst en de andere rapporten worden verwijderd.',
         },
+        periodSoFar: ({period}: {period: string}) => `${period} tot nu toe`,
+        weekOf: ({date}: {date: string}) => `Week van ${date}`,
     },
     genericErrorPage: {
         title: 'Oeps, er is iets misgegaan!',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 8f3224f0..4c84cd09 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -10009,6 +10009,8 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
             violationsBySubmitter: 'Naruszenia przez zgłaszającego',
         },
         mergeReports: {title: 'Połącz raporty', description: 'Wybierz raport, który chcesz zachować. Wszystkie wydatki zostaną do niego przeniesione, a pozostałe raporty zostaną usunięte.'},
+        periodSoFar: ({period}: {period: string}) => `${period} do tej pory`,
+        weekOf: ({date}: {date: string}) => `Tydzień od ${date}`,
     },
     genericErrorPage: {
         title: 'Ups, coś poszło nie tak!',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 232e0d95..e762f55d 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -9994,6 +9994,8 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
             title: 'Mesclar relatórios',
             description: 'Selecione o relatório que você quer manter. Todas as despesas serão movidas para ele e os outros relatórios serão excluídos.',
         },
+        periodSoFar: ({period}: {period: string}) => `${period} até agora`,
+        weekOf: ({date}: {date: string}) => `Semana de ${date}`,
     },
     genericErrorPage: {
         title: 'Opa, algo deu errado!',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index b0f910cd..e44dc4c3 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -9621,6 +9621,8 @@ ${reportName}`,
             violationsBySubmitter: '提交人违规',
         },
         mergeReports: {title: '合并报表', description: '选择要保留的报表。所有费用都将移入该报表,其他报表将被删除。'},
+        periodSoFar: ({period}: {period: string}) => `目前 ${period}`,
+        weekOf: ({date}: {date: string}) => `${date} 当周`,
     },
     genericErrorPage: {
         title: '哎呀,出错了!',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@MelvinBot

Copy link
Copy Markdown
Contributor

Review

The in-progress detection logic and its tests look correct. One behavior bug and one CI blocker need fixing before merge.

1. CI blocker: missing translations. typecheck and test (job 6) (TranslateTest) both fail because periodSoFar and weekOf exist only in en.ts. This is a fork PR, so an Expensify employee needs to run the Generate static translations workflow.

2. Bug: horizontal bar charts change the axis label to "Oct so far". buildChartSeries.ts:65 overwrites point.label. Horizontal bars use point.label for their category axis (HorizontalBarChartContent.tsx:337). They also size the label column from it (line 289).

With the Insights beta on, wide layouts always use horizontal bars (useBarChartOrientation.ts:14). So test step 6 on desktop shows "Oct so far" on the axis, and the year disappears. This contradicts "The x-axis label is unchanged."

Suggested fix: keep label as is. Put the "so far" text in its own field, and read that field only in tooltips, legends, and inline tables.

Nits
  • LineChartContent.tsx:46: the dashed segment is 4px wide while the solid line is 2px. Round caps make the DASH_INTERVALS dashes about 7px long with 5px gaps, not the gridlines' 4px/8px. Please confirm the thicker stroke and the different rhythm with design.
  • The PR description doesn't match the code. It says "Oct 5 for now" and "Oct for now", and the Year test step expects "Jan 1-Oct … so far". The code produces "Oct 5 so far", "Oct so far", and "2026 so far".

view run

@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/Charts/VictoryTheme.ts 100.00% <100.00%> (ø)
...rc/components/Charts/components/ChartGridLines.tsx 16.66% <ø> (-20.84%) ⬇️
src/components/Search/buildChartSeries.ts 100.00% <100.00%> (ø)
src/components/Search/chartGroupByConfig.ts 13.63% <100.00%> (+11.07%) ⬆️
src/components/Search/getInProgressBucketLabel.ts 100.00% <100.00%> (ø)
...ponents/Charts/components/ActivePointIndicator.tsx 13.33% <20.00%> (+4.24%) ⬆️
src/components/Search/SearchChartView.tsx 0.00% <0.00%> (ø)
...c/components/Charts/LineChart/LineChartContent.tsx 0.00% <0.00%> (ø)
... and 29 files with indirect coverage changes

@mhawryluk

mhawryluk commented Oct 6, 2026 •

Copy link
Copy Markdown
Member Author

1. CI blocker: missing translations.

done

2. Bug: horizontal bar charts change the axis label to "Oct so far".

we're removing horizontal bar charts here: #102991

Nits

  • LineChartContent.tsx:46: the dashed segment is 4px wide while the solid line is 2px. Round caps make the DASH_INTERVALS dashes about 7px long with 5px gaps, not the gridlines' 4px/8px. Please confirm the thicker stroke and the different rhythm with design.

I changed both to match Figma (stroke-dasharray="4 8"), now it looks like this:

Zrzut ekranu 2026-10-6 o 13 59 19
  • The PR description doesn't match the code. It says "Oct 5 for now" and "Oct for now", and the Year test step expects "Jan 1-Oct … so far". The code produces "Oct 5 so far", "Oct so far", and "2026 so far".

fixed

@mhawryluk
mhawryluk marked this pull request as ready for review October 6, 2026 12:06
@mhawryluk
mhawryluk requested review from a team as code owners October 6, 2026 12:06
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and Krishna2323 and removed request for a team October 6, 2026 12:06
@melvin-bot

melvin-bot Bot commented Oct 6, 2026

Copy link
Copy Markdown

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team October 6, 2026 12:06
@mhawryluk

Copy link
Copy Markdown
Member Author

@daledah @truph01 can one of you review this PR? it's part of the Insights page project

@daledah

daledah commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

I can review it today

@daledah daledah self-assigned this Oct 6, 2026
@dylanexpensify

Copy link
Copy Markdown
Contributor

Thanks @daledah 🙌

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@Krishna2323
Krishna2323 removed their request for review October 6, 2026 13:46
JmillsExpensify
JmillsExpensify previously approved these changes Oct 6, 2026

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very very good!

@daledah

daledah commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

working on it now

@daledah

daledah commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

iOS: HybridApp
ios.mov
MacOS: Chrome / Safari
web-resize.mp4

@daledah

daledah commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@mhawryluk @JmillsExpensify I created an expense dated Oct 31 and set the filter to This month + group by Day (today is Oct 6). The segment from Oct 6 -> Oct 31 isn't dashed, and the Oct 6 dot isn't hollow, but its tooltip still reads Oct 6 so far.

Is this expected, or a bug?

Screenshot 2026-10-06 at 22 47 31 Screenshot 2026-10-06 at 22 47 35

@daledah

daledah commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@mhawryluk could you please resolve conflict?

@JmillsExpensify

Copy link
Copy Markdown
Contributor

@mhawryluk @JmillsExpensify I created an expense dated Oct 31 and set the filter to This month + group by Day (today is Oct 6). The segment from Oct 6 -> Oct 31 isn't dashed, and the Oct 6 dot isn't hollow, but its tooltip still reads Oct 6 so far.

Is this expected, or a bug?

Screenshot 2026-10-06 at 22 47 31 Screenshot 2026-10-06 at 22 47 35

The issue kind of comes down to the fact that we now allow future-dated expenses, which are past "today" in the timeline. So I kind of think that this is expected. We are graphing the end of the month.

@daledah daledah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aldo-expensify
aldo-expensify previously approved these changes Oct 6, 2026
luacmartins
luacmartins previously approved these changes Oct 6, 2026
@aldo-expensify

Copy link
Copy Markdown
Contributor

@mhawryluk this has conflicts 😬

@mhawryluk

Copy link
Copy Markdown
Member Author

I resolved the conflicts, this is what it looks like all together:

Nagranie.z.ekranu.2026-10-7.o.10.20.18.mov

@cristipaval
cristipaval merged commit 570debe into Expensify:main Oct 7, 2026
36 of 37 checks passed
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

🚧 cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103168.

Android 🤖 iOS 🍎
❌ FAILED ❌ https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-570debe-82e2701-409fa2374d39bfb9dfa5df06f1f5a7ad865d396a/index.html
The QR code can't be generated, because the Android build failed iOS
Web 🕸️
https://103168.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Oct 7, 2026
68 tasks done
@OSBotify

OSBotify commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.5.5-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This PR only changes how charts show the in-progress period (a "so far" label, a dashed line segment, and a hollow dot), and no article under docs/articles describes how the current period appears, so no existing sentence is now incorrect.


view run

@OSBotify

OSBotify commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.5-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants