Repository navigation
[Insights polish] Mark the in-progress period on time-based charts - #103168
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@MelvinBot review |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index ce09105a..4a4ac7f8 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -10076,6 +10076,8 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
title: 'Berichte zusammenführen',
description: 'Wählen Sie den Bericht aus, der beibehalten werden soll. Alle Ausgaben werden in ihn verschoben und die anderen Berichte werden gelöscht.',
},
+ periodSoFar: ({period}: {period: string}) => `${period} bisher`,
+ weekOf: ({date}: {date: string}) => `Woche vom ${date}`,
},
genericErrorPage: {
title: 'Ups, da ist etwas schiefgelaufen!',
diff --git a/src/languages/el.ts b/src/languages/el.ts
index 6759a8aa..076ae5e8 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -10273,6 +10273,8 @@ ${reportName}`,
title: 'Λήψη κατάστασης',
oneFeedAtATime: 'Παρακαλούμε επιλέγετε διακανονισμούς από μία ροή Κάρτας Expensify κάθε φορά.',
},
+ periodSoFar: ({period}: {period: string}) => `${period} μέχρι τώρα`,
+ weekOf: ({date}: {date: string}) => `Εβδομάδα από ${date}`,
},
genericErrorPage: {
title: 'Ωχ, κάτι πήγε στραβά!',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 5f05b228..3bd5d18b 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -9891,6 +9891,8 @@ ${reportName}`,
pleaseSelectDatesForBothFromAndTo: 'Por favor, selecciona fechas para Desde y Hasta',
},
mergeReports: {title: 'Combinar informes', description: 'Selecciona el informe que quieres conservar. Todos los gastos se moverán a él y los demás informes se eliminarán.'},
+ periodSoFar: ({period}: {period: string}) => `${period} hasta ahora`,
+ weekOf: ({date}: {date: string}) => `Semana del ${date}`,
},
genericErrorPage: {
title: '¡Oh-oh, algo salió mal!',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 2f0e5b4b..d343567a 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -10099,6 +10099,8 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
title: 'Fusionner des notes de frais',
description: 'Sélectionnez la note de frais à conserver. Toutes les dépenses y seront déplacées et les autres notes de frais seront supprimées.',
},
+ periodSoFar: ({period}: {period: string}) => `${period} jusqu’à présent`,
+ weekOf: ({date}: {date: string}) => `Semaine du ${date}`,
},
genericErrorPage: {
title: 'Oups, quelque chose s’est mal passé !',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index d91cccc5..399f6812 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -10026,6 +10026,8 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
violationsBySubmitter: 'Violazioni da parte dell’autore dell’invio',
},
mergeReports: {title: 'Unisci report', description: 'Seleziona il report da mantenere. Tutte le spese verranno spostate al suo interno e gli altri report verranno eliminati.'},
+ periodSoFar: ({period}: {period: string}) => `${period} finora`,
+ weekOf: ({date}: {date: string}) => `Settimana del ${date}`,
},
genericErrorPage: {
title: 'Oops, qualcosa è andato storto!',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 1bce0fc6..b43c0470 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -9878,6 +9878,8 @@ ${reportName}`,
violationsBySubmitter: '申請者による違反',
},
mergeReports: {title: 'レポートをマージする', description: '保持するレポートを選択してください。すべての経費はそのレポートに移動され、他のレポートは削除されます。'},
+ periodSoFar: ({period}: {period: string}) => `これまでの${period}`,
+ weekOf: ({date}: {date: string}) => `${date} の週`,
},
genericErrorPage: {
title: 'おっと、問題が発生しました!',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 4fb2801b..e8f7c96a 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -9996,6 +9996,8 @@ er bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
title: 'Rapporten samenvoegen',
description: 'Selecteer het rapport dat je wilt behouden. Alle uitgaven worden daarheen verplaatst en de andere rapporten worden verwijderd.',
},
+ periodSoFar: ({period}: {period: string}) => `${period} tot nu toe`,
+ weekOf: ({date}: {date: string}) => `Week van ${date}`,
},
genericErrorPage: {
title: 'Oeps, er is iets misgegaan!',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 8f3224f0..4c84cd09 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -10009,6 +10009,8 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
violationsBySubmitter: 'Naruszenia przez zgłaszającego',
},
mergeReports: {title: 'Połącz raporty', description: 'Wybierz raport, który chcesz zachować. Wszystkie wydatki zostaną do niego przeniesione, a pozostałe raporty zostaną usunięte.'},
+ periodSoFar: ({period}: {period: string}) => `${period} do tej pory`,
+ weekOf: ({date}: {date: string}) => `Tydzień od ${date}`,
},
genericErrorPage: {
title: 'Ups, coś poszło nie tak!',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 232e0d95..e762f55d 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -9994,6 +9994,8 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
title: 'Mesclar relatórios',
description: 'Selecione o relatório que você quer manter. Todas as despesas serão movidas para ele e os outros relatórios serão excluídos.',
},
+ periodSoFar: ({period}: {period: string}) => `${period} até agora`,
+ weekOf: ({date}: {date: string}) => `Semana de ${date}`,
},
genericErrorPage: {
title: 'Opa, algo deu errado!',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index b0f910cd..e44dc4c3 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -9621,6 +9621,8 @@ ${reportName}`,
violationsBySubmitter: '提交人违规',
},
mergeReports: {title: '合并报表', description: '选择要保留的报表。所有费用都将移入该报表,其他报表将被删除。'},
+ periodSoFar: ({period}: {period: string}) => `目前 ${period}`,
+ weekOf: ({date}: {date: string}) => `${date} 当周`,
},
genericErrorPage: {
title: '哎呀,出错了!',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
ReviewThe in-progress detection logic and its tests look correct. One behavior bug and one CI blocker need fixing before merge. 1. CI blocker: missing translations. 2. Bug: horizontal bar charts change the axis label to "Oct so far". With the Insights beta on, wide layouts always use horizontal bars ( Suggested fix: keep Nits
|
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
done
we're removing horizontal bar charts here: #102991
I changed both to match Figma (
fixed |
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I can review it today |
|
Thanks @daledah 🙌 |
|
🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
JmillsExpensify
left a comment
There was a problem hiding this comment.
This is looking very very good!
|
working on it now |
Reviewer Checklist
Screenshots/VideosiOS: HybridAppios.movMacOS: Chrome / Safariweb-resize.mp4 |
|
@mhawryluk @JmillsExpensify I created an expense dated Is this expected, or a bug?
|
|
@mhawryluk could you please resolve conflict? |
The issue kind of comes down to the fact that we now allow future-dated expenses, which are past "today" in the timeline. So I kind of think that this is expected. We are graphing the end of the month. |
|
@mhawryluk this has conflicts 😬 |
b64c5c8
|
I resolved the conflicts, this is what it looks like all together: Nagranie.z.ekranu.2026-10-7.o.10.20.18.mov |
|
🚧 cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.5.5-0 🚀
|
|
No help site update is needed. This PR only changes how charts show the in-progress period (a "so far" label, a dashed line segment, and a hollow dot), and no article under |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.5-2 🚀
Bundle Size Analysis (Sentry): |





Explanation of Change
Marks the time bucket that contains today as in progress, so a partial total doesn't read as a drop in spend:
Fixed Issues
$ #103089
PROPOSAL: N/A
Tests
Oct '26as usual, hovering it showsOct so farin the tooltip.Offline tests
N/A
QA Steps
Same as tests, but test in Home and Spend, instead of Insights.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-10-6.o.13.38.27.mov
Nagranie.z.ekranu.2026-10-6.o.13.43.18.mov