Repository navigation
Conversation
|
|
…kip-unchanged-subtrees # Conflicts: # package-lock.json # package.json
|
@fabioh8010 yes, will do |
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Its ready for review already, i will unhold it once #105110 hits production |
|
#105110 (comment) hit production! |
|
I removed hold, its ready for review now @fabioh8010 @Krishna2323 |

Explanation of Change
Bumps
react-native-onyxfrom 3.0.143 to 3.0.145. Version 3.0.144 contains only Expensify/react-native-onyx#856, and 3.0.145 only overrides theundicidev dependency to fix Dependabot alerts (Expensify/react-native-onyx#885), with no runtime change.Onyx.setand the other writes no longer walk nested objects that are the same as in the cache when they remove nestednullvalues, so large writes like derived values and Pusher updates stop rebuilding objects that did not change. Subscribers get the same values as before. Details and measurements are in the Onyx PR.Fixed Issues
$ #103616
Tests
removeNestedNullValues skipped a cached subtreealert during the steps above.Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-native.mp4
Android: mWeb Chrome
android-mweb-chrome-emulated.mp4
iOS: Native
ios-native.mp4
iOS: mWeb Safari
ios-mweb-emulated.mp4
MacOS: Chrome / Safari
macos-chrome.mp4