Skip to content

[Onyx bump] Bump react-native-onyx to 3.0.145 - #103978

Open
arekm213 wants to merge 6 commits into
Expensify:mainfrom
arekm213:arekm213/onyx-856-skip-unchanged-subtrees
Open

arekm213 wants to merge 6 commits into
Expensify:mainfrom
arekm213:arekm213/onyx-856-skip-unchanged-subtrees

Conversation

@arekm213

@arekm213 arekm213 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Bumps react-native-onyx from 3.0.143 to 3.0.145. Version 3.0.144 contains only Expensify/react-native-onyx#856, and 3.0.145 only overrides the undici dev dependency to fix Dependabot alerts (Expensify/react-native-onyx#885), with no runtime change.

Onyx.set and the other writes no longer walk nested objects that are the same as in the cache when they remove nested null values, so large writes like derived values and Pusher updates stop rebuilding objects that did not change. Subscribers get the same values as before. Details and measurements are in the Onyx PR.

Fixed Issues

$ #103616

Tests

  1. Sign in, open the Inbox and a few reports, and verify they load as before.
  2. Send a message in a chat and verify it shows up.
  3. Open an expense, edit its description and save it, then clear it again. Reload and verify the expense shows the expected values.
  4. Open the Spend tab and verify the expenses list loads.
  5. Sign out and sign in again, and verify no error indicator shows on the account.
  6. In a dev build, verify the console shows no removeNestedNullValues skipped a cached subtree alert during the steps above.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline.
  2. Send a message and edit an expense description.
  3. Verify both show as pending.
  4. Go back online and verify they sync, with no stale or missing fields.

QA Steps

  1. Sign in, open the Inbox and a few reports, and verify they load as before.
  2. Send a message in a chat and verify it shows up.
  3. Open an expense, edit its description and save it. Reload and verify the new description shows.
  4. Open the Spend tab and verify the expenses list loads.
  5. Sign out and sign in again, and verify no error indicator shows on the account.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android-native.mp4
Android: mWeb Chrome
android-mweb-chrome-emulated.mp4
iOS: Native
ios-native.mp4
iOS: mWeb Safari
ios-mweb-emulated.mp4
MacOS: Chrome / Safari
macos-chrome.mp4

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@arekm213 arekm213 changed the title [Onyx bump] Bump react-native-onyx to 3.0.120 (test Expensify/react-native-onyx#856) [HOLD on #102422 #103351][Onyx bump] Bump react-native-onyx to 3.0.144 Nov 2, 2026
@arekm213 arekm213 changed the title [HOLD on #102422 #103351][Onyx bump] Bump react-native-onyx to 3.0.144 [HOLD on https://github.com/Expensify/App/pull/102422 https://github.com/Expensify/App/pull/103351][Onyx bump] Bump react-native-onyx to 3.0.144 Nov 2, 2026
…kip-unchanged-subtrees

# Conflicts:
#	package-lock.json
#	package.json
@arekm213 arekm213 changed the title [HOLD on https://github.com/Expensify/App/pull/102422 https://github.com/Expensify/App/pull/103351][Onyx bump] Bump react-native-onyx to 3.0.144 [Onyx bump] Bump react-native-onyx to 3.0.144 Nov 16, 2026
@fabioh8010

fabioh8010 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

@arekm213 You can unhold this one once #105110 hit production!

EDIT
@arekm213 Could you also change PR to bump to 3.0.145?

Screenshot 2026-11-17 at 07 33 36

@arekm213 arekm213 changed the title [Onyx bump] Bump react-native-onyx to 3.0.144 [Onyx bump] Bump react-native-onyx to 3.0.145 Nov 17, 2026
@arekm213 arekm213 changed the title [Onyx bump] Bump react-native-onyx to 3.0.145 [HOLD App#105110 production] [Onyx bump] Bump react-native-onyx to 3.0.145 Nov 17, 2026
@arekm213

Copy link
Copy Markdown
Contributor Author

@fabioh8010 yes, will do

@arekm213
arekm213 marked this pull request as ready for review November 17, 2026 17:20
@arekm213
arekm213 requested a review from a team as a code owner November 17, 2026 17:20
@expensify-chore-bot
expensify-chore-bot Bot requested review from Krishna2323 and removed request for a team November 17, 2026 17:20
@expensify-chore-bot

Copy link
Copy Markdown

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T17:49:07.657188Z 622da4e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@arekm213

Copy link
Copy Markdown
Contributor Author

Its ready for review already, i will unhold it once #105110 hits production

@fabioh8010

Copy link
Copy Markdown
Contributor

#105110 (comment) hit production!

@arekm213 arekm213 changed the title [HOLD App#105110 production] [Onyx bump] Bump react-native-onyx to 3.0.145 [Onyx bump] Bump react-native-onyx to 3.0.145 Nov 18, 2026
@arekm213

Copy link
Copy Markdown
Contributor Author

I removed hold, its ready for review now @fabioh8010 @Krishna2323

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants