Repository navigation
Override undici to ^6.29.1 to fix Dependabot alerts - #885
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
melvin-bot
Bot
requested review from
puneetlath
and removed request for
a team
November 2, 2026 12:30
puneetlath
approved these changes
Nov 2, 2026
JS00001
approved these changes
Nov 2, 2026
Contributor
|
merging through the 'must have an e/app issue linked' check, since this is an e/e issue |
Contributor
|
@JS00001 looks like this was merged without a test passing. These checks had not passed on 94e952b when it was merged:
Please add a note explaining why this was done and remove the |
Contributor
|
Not an emergency, commented above: #885 (comment) |
38 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adds an
undicioverride (5.29.0→6.29.1) to fix all open undici Dependabot alerts, then rebuilds the bundled GitHub Actions.Usage: Dev-only, transitive via
@actions/core/@actions/github(@actions/http-clientproxy agent +getOctokitfetch). Only used by our GitHub Actions in.github/actions/javascript/*(requireTests,validatePRChecklist,validateReassureOutput,reassureStabilityCheck). Not shipped in the published package (dist/has no undici).Why override:
@actions/github@6pinsundici@^5, which has no patched release. Upgrading@actions/*to latest is a larger ESM-only migration.Change Log
ProxyAgent/fetchAPI changes used by@actions/*.Related Issues
$ https://github.com/Expensify/Expensify/issues/698707
Linked E/App PR
N/A — dev-only dependency; the published package doesn't change.
Automated Tests
None added; no library code changed.
npm ci,npm run typecheck, andnpm run gh-actions-buildpass locally, andnpm auditreports no undici issues.npm testpasses exceptSQLiteProviderTest, which fails only because thebetter-sqlite3native binding isn't built in my sandbox (unrelated).Manual Tests
// TODO: The human co-author must fill out the tests they ran before marking this PR as "ready for review".
Suggested:
Validate Github Actionspasses (bundles match the lockfile).requireTestsandvalidatePRChecklistrun without network/undici errors (they call the GitHub API viagetOctokit).lib/, confirm the Reassure workflow'svalidateReassureOutputstep runs normally.Author Checklist
### Related Issuessection above### Linked E/App PRsection above, and verified this change against it (E/App CI passed and manual testing completed)TestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari