Repository navigation
Pass translate to tax rate name helpers instead of using translateLocal - #105555
Conversation
Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
|
Fixed the failing This PR added a
|
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🤖 Android test steps verification results: ✅ pass Verified on standalone Android NewDot that PR #105555's translate-based tax rate name helpers render correctly end-to-end: no console errors occurred, the Taxes list and Settings default picker show correctly built names, the expense confirmation Tax field and picker show the default label, and switching to Spanish correctly translates the "Default" suffix to "Predeterminado".
|
|
@MelvinBot, suggest main test steps for changed flows in this PR. No need for edge case tests. |
|
Here are the main test steps for the flows this PR changes. Each step covers a screen that now passes Setup: Use a workspace with Taxes enabled and at least two tax rates. Enable Distance rates with tax tracking turned on.
Earlier web and Android runs on this PR covered parts of steps 1, 3, and 9: the Workspace currency default picker, the expense Tax picker, and the Spanish label. Nobody has run the rest yet. |
|
@MelvinBot Update description to |
|
@MelvinBot Mark it ready for review. |
|
🤖 Updated the PR description with the text you provided, including the new 9-step Tests section, "Same as tests" for Offline tests and QA Steps, and the checked PR Author Checklist. |
|
🤖 This PR is now marked ready for review. The |
|
@shubham1206agra @carlosmiceli One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
01.11.2026_21.51.33_REC.mp4
🎀 👀 🎀 C+ reviewed
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
|
I merged
Checks run locally after the merge:
|
|
@parasharrajat @carlosmiceli One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
No fix needed. The checks on the current commit (
All other checks (TypeScript, Jest, Oxlint, Oxfmt, Knip, React Compiler, Bun) passed. Some showed as cancelled because they were duplicate runs. |
|
@parasharrajat we have conflicts 😞 |
|
@MelvinBot Resolve conflicts and merge main. |
Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
|
Merged Spelling passed. Final validation remains blocked: Bun’s missing postinstall blocked lint/typecheck, Jest could not load React Navigation’s ES module, and web testing encountered a blank page. view run · no recording available |
|
@carlosmiceli Please merge this. |
|
@carlosmiceli Bump |
|
🚧 carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.5.37-0 🚀
|
|
No help site update needed — this PR fixes tax-label localization when switching languages, restoring expected behavior without adding a feature, changing a workflow, or making existing article text incorrect. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.37-1 🚀
Bundle Size Analysis (Sentry): |












Explanation of Change
Part of deprecating
Localize.translateLocal.transformedTaxRatesinsrc/libs/TransactionUtils/tax.tsusedtranslateLocal('common.default')to build each rate's display name (for example, "Tax exempt (0%) • Default"). BecausetranslateLocalis impure, views using these names did not re-render when the preferred locale changed.This PR passes
translatedown as a parameter instead, following the same pattern as #102363:transformedTaxRates,getTaxName,getTaxRateTitle, andgetWorkspaceTaxesSettingsNamenow taketranslateas their first parameter.translatefromuseLocalize()(all of them already had it). Library callers get it threaded through:getTransactionSortValue(ReportUtils),getTaxRatesSection(TaxOptionsListUtils),getMergeableDataAndConflictFields/getMergeFieldUpdatedValues(MergeTransactionUtils), andsetupMergeTransactionDataAndNavigate(actions/MergeTransaction).getTaxValueandhasTaxRateWithMatchingValueonly need a rate'svalue, not its localized display name. They now look the rate up directly with a small privategetPolicyTaxRatehelper instead of callingtransformedTaxRates. Their behavior is unchanged, and their many action-level callers (IOU, BulkEdit, SplitExpense, and others) don't needtranslate.translateLocalseatbelt entry fortax.ts.translateLocalfromTestHelper.Locally verified by Melvin:
npm run typecheckpasses,npm run lint-changedpasses,npm run spell-changedpasses, and the related Jest suites pass (TransactionUtils, TaxOptionsListUtils, MergeTransactionUtils, MergeTransaction, MergeTransactionDetailsReview, ReportUtils, SearchUIUtils, useMoneyRequestReportSortedTransactions, useTaxAmount, BulkEdit, SplitExpenseItems, PolicyTax, UpdateMoneyRequest, SearchEditMultiplePage, DynamicSplitExpensePage, MoneyRequestHeaderSecondaryActions, IOURequestStepConfirmationPage).react-compiler-compliance-checkcould not run in Melvin's environment becauseGITHUB_BASE_REFis empty there; component changes only add an argument to existing calls.Fixed Issues
$ #64943
PROPOSAL:
Tests
Setup: Use a workspace with Taxes enabled and at least two tax rates. Enable Distance rates with tax tracking turned on.
• Default. Pick another rate and verify the Settings row shows its name.• Predeterminado. Switch back to English.Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari