You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm plagiarizing Tim G's proposal here, because this is essentially an analog of the same problem.
Problem
When a UI view calls a method that uses Localize.translateLocal (i.e: an impure function), the UI view will become out-of-date because it was not re-rendered when the preferredLocale changed.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.37-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@MelvinBot We need to refactor getUpdatedTransaction function to pass the translate function down as a parameter directly instead of using translateLocal.
Assign me for review only.
Here is the plan:
Create 3 PRs as follows:
First PR, updates only all callers of getUpdateTrackExpenseParams function which use getUpdatedTransaction.
Second PR, updates only all callers of getUpdateMoneyRequestParams function which use getUpdatedTransaction.
Third PR, updates only all callers of setDraftSplitTransaction function which use getUpdatedTransaction in the split module as well as updateMultipleMoneyRequests in BulkEdit module.
Give me an action plan here and wait for approval before implementation.
Create three sequential PRs, keeping each buildable and limiting caller migration to your requested groups.
PR 1 — Track-expense updates
Add a typed translate parameter to getUpdatedTransaction, including its distance-merchant helper.
Thread translate through getUpdateTrackExpenseParams and all upstream callers: track-expense editing, inline edits, amount submission, and transaction merging.
Temporarily retain a translateLocal default only at the shared function boundary, allowing the other groups to remain unchanged.
Remove transitional optionality/defaults, make translate required throughout, and verify every production caller supplies it explicitly.
For each PR: update affected tests, run targeted Jest suites and required static checks, and verify affected flows on web. Request parasharrajatas reviewer only, not assignee or contributor.
No implementation changes made. This revised plan remains subject to approval.
parasharrajat is requested as reviewer, with no PR assignee.
Typecheck, lint, spelling, Storybook smoke, and 696 targeted tests passed.
Web verification was blocked by a blank app page. Full Jest timed out; React Compiler verification was blocked by base-reference resolution.
Remaining
PR 2: initial local changes only; caller migration and validation are unfinished.
PRs 3–4: not implemented or created.
Temporary translation defaults remain, as planned.
Review-only caveat: the commit hook automatically added a co-author trailer for parasharrajat, despite the requested review-only role.
Next step: finish and validate PR 2, then implement PRs 3–4, retaining the approved scope boundaries. Resolve the attribution and web-testing limitations before marking the drafts ready for review.
Edit reported-expense category/tag/taxBlocked: no rendered controls.
❌
Verify distance merchant and language changesBlocked by the same blank page; behavior remains unverified.
❌
Passed: 167 targeted tests, typecheck, lint, spelling, explicit React Compiler checks, and Storybook smoke. Full Jest timed out; changed-file compiler checking remains blocked by base-reference resolution.
parasharrajat is requested as reviewer, with no assignee. The commit hook still automatically adds co-authorship. Split drafts, existing-split updates, and bulk edits remain excluded.
Activity
roryabraham commentedon Jul 8, 2025
Looks like @shubham1206agra got started a couple weeks ago
shubham1206agra commentedon Jul 9, 2025
@roryabraham I need to write a design doc before kicking this issue off.
roryabraham commentedon Jul 22, 2025
no update
roryabraham commentedon Aug 11, 2025
Going to put this on HOLD for #66329
[-]Deprecate Localize.translateLocal[/-][+][HOLD #66329] Deprecate Localize.translateLocal[/+]430 remaining items
parasharrajat commentedon Nov 1, 2026
@MelvinBot Close the upwork job. It is not needed.
MelvinBot commentedon Nov 1, 2026
🤖 I couldn't close the Upwork job because I don't have access to Upwork. I can only work with GitHub.
An Expensify team member with Upwork access needs to close it there: https://www.upwork.com/jobs/~022116931309428775204
This issue is labeled
Skip Paymentand the work here is review-only, so no Upwork offer is needed.shubham1206agra commentedon Nov 10, 2026
@roryabraham What do you think optimal payout is here?
PRs I wrote - #73179, #73487, #73493, #74355, #74494, #74498, #75768, #75771, #76612, #76623, #76732, #78453, #78490, #78493, #78494, #79023, #79349, #79354, #79643, #79645, #79649, #79651, #81274, #81324, #82497, #86013, #95340, #102364
PRs I reviewed - #73104, #73109, #73110, #73111, #73114, #73366, #73367, #73368, #73369, #73370, #73371, #73374, #73375, #73376, #73450, #79668, #79679, #79683, #79688, #79694, #102361, #102362, #102363, #102608, #105554
melvin-bot commentedon Nov 13, 2026
@parasharrajat / @shubham1206agra
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.37-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
parasharrajat commentedon Nov 14, 2026
@MelvinBot We need to refactor getUpdatedTransaction function to pass the translate function down as a parameter directly instead of using
translateLocal.Here is the plan:
Create 3 PRs as follows:
getUpdateTrackExpenseParamsfunction which usegetUpdatedTransaction.getUpdateMoneyRequestParamsfunction which usegetUpdatedTransaction.setDraftSplitTransactionfunction which usegetUpdatedTransactionin the split module as well asupdateMultipleMoneyRequestsin BulkEdit module.Give me an action plan here and wait for approval before implementation.
MelvinBot commentedon Nov 14, 2026
Action plan
Create three sequential PRs, keeping each buildable and limiting caller migration to your requested groups.
PR 1 — Track-expense updates
translateparameter togetUpdatedTransaction, including its distance-merchant helper.translatethroughgetUpdateTrackExpenseParamsand all upstream callers: track-expense editing, inline edits, amount submission, and transaction merging.translateLocaldefault only at the shared function boundary, allowing the other groups to remain unchanged.PR 2 — Money-request updates
translatethroughgetUpdateMoneyRequestParamsand all upstream callers.updateSplitTransactionspath.PR 3 — Split drafts and bulk edits
translatethroughsetDraftSplitTransactionand every caller, plusupdateMultipleMoneyRequests.translaterequired ingetUpdatedTransaction.Validation and review
parasharrajatas reviewer only, not as assignee or contributor.No code changes or PRs have been made. Approval is required before implementation, including the temporary fallback strategy.
view run
parasharrajat commentedon Nov 14, 2026
@MelvinBot Let's add another PR which takes care of updating updateSplitTransactions path as well updateMultipleMoneyRequests from BulkEdit module. Remove these updates from PR 2 and PR 3.
Give me an updated plan.
MelvinBot commentedon Nov 14, 2026
Updated plan — four sequential PRs
PR 1 — Track-expense updates
translateparameter togetUpdatedTransaction, including its distance-merchant helper.getUpdateTrackExpenseParamsand its upstream caller chains.translateLocaldefault at the shared boundary for unmigrated callers.PR 2 — Money-request updates
translatethroughgetUpdateMoneyRequestParamsand its upstream callers, excludingupdateSplitTransactions.translateparameter to be omitted so the deferred split-update path remains buildable.PR 3 — Split drafts only
translatethroughsetDraftSplitTransactionand every upstream caller.PR 4 — Existing-split updates, bulk edits, and final cleanup
updateSplitTransactionscaller chain.updateMultipleMoneyRequestsand its callers.translaterequired throughout, and verify every production caller supplies it explicitly.For each PR: update affected tests, run targeted Jest suites and required static checks, and verify affected flows on web. Request
parasharrajatas reviewer only, not assignee or contributor.No implementation changes made. This revised plan remains subject to approval.
view run
parasharrajat commentedon Nov 14, 2026
@MelvinBot Plan looks good. let's implement #64943 (comment)
MelvinBot commentedon Nov 14, 2026
Partially completed—the run reached its execution limit.
Created draft Pass translate through track-expense updates (1 of 4).
parasharrajatis requested as reviewer, with no PR assignee.Remaining
Review-only caveat: the commit hook automatically added a co-author trailer for
parasharrajat, despite the requested review-only role.Next step: finish and validate PR 2, then implement PRs 3–4, retaining the approved scope boundaries. Resolve the attribution and web-testing limitations before marking the drafts ready for review.
view run · no recording available
parasharrajat commentedon Nov 14, 2026
@MelvinBot, continue with creating PR 2.
MelvinBot commentedon Nov 14, 2026
🤖 Web test steps verification results: ❌ fail
Web verification was blocked by a blank dev app page—not a confirmed PR regression. Created draft Pass translate through money-request updates (2 of 4), stacked on PR 1.
Edit reported-expense category/tag/tax
Blocked: no rendered controls.Verify distance merchant and language changes
Blocked by the same blank page; behavior remains unverified.Passed: 167 targeted tests, typecheck, lint, spelling, explicit React Compiler checks, and Storybook smoke. Full Jest timed out; changed-file compiler checking remains blocked by base-reference resolution.
parasharrajatis requested as reviewer, with no assignee. The commit hook still automatically adds co-authorship. Split drafts, existing-split updates, and bulk edits remain excluded.view run · no recording available
parasharrajat commentedon Nov 14, 2026
@MelvinBot Create the PR 3 and PR 4.
MelvinBot commentedon Nov 14, 2026
🤖 Web test steps verification results: ❌ fail
Created draft PR 3 — Split-draft updates and PR 4 — Existing-split updates, bulk edits, and cleanup, stacked in order. Browser verification was blocked by a blank dev app—not a confirmed regression.
Edit split-draft fields
Blocked: zero UI nodes.Verify localized distance split draft
Not tested due to the environment blocker.Edit and save existing splits
Blocked: blank app.Delete a split and verify remaining splits
Not executed.Bulk edit, including after changing language
Not executed.Passed: 902 targeted tests across 13 suites, typecheck, lint, spelling, explicit compiler checks, and Storybook smoke. Full Jest timed out; changed-file compiler checking remains blocked.
PR 4 removes the temporary translation fallback. Both PRs request
parasharrajatas reviewer with no assignee; automatic commit co-authorship remains.view run · no recording available
expensify-chore-bot commentedon Nov 17, 2026
@parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!