Repository navigation
Conversation
Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
|
Both failing Jest jobs hit CI’s coverage transform makes barrel re-exports non-configurable. The minimal fix is to import the defining module, No changes pushed: the request did not identify the requester, so I couldn’t verify authorization. An existing co-author or PR assignee must retry the request with their identity available. |
|
🤖 Android test steps verification results: Android testing was blocked because the signed-in account has no expenses or existing splits; no product regression was established. The PR’s detailed Tests/QA steps remain TODO, so the intended split and bulk-edit cases could not be verified.
|
|
🤖 Web test steps verification results: All four functional assertions passed on dev NewDot web. JavaScript console verification remains blocked by the supported browser interface; no product regression was observed.
|









Explanation of Change
Part 4 of the approved four-PR refactor. Pass the caller's translator through existing-split saves, split deletion, and bulk edits so every production
getUpdatedTransactioninvocation now has an explicit translation dependency.translatethroughupdateSplitTransactionsandupdateMultipleMoneyRequests, including their page/hook callers.getUpdateMoneyRequestParams.translateandgetUpdatedTransaction.translaterequired; remove the temporarytranslateLocaldefault and import from the transaction helper.translateLocalusages remain outside this refactor.Dependency: stacked on Pass translate through split draft updates (3 of 4). Merge preceding parts first, then retarget to
main.AI Tests
origin/); explicit file checks passed. Noprettiernpm script exists; Oxfmt runs in the commit hook.parasharrajatis requested as reviewer, not assignee. The environment's commit hook automatically adds requester co-authorship, as noted on preceding parts.Fixed Issues
$ #64943
PROPOSAL: #64943 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari