Skip to content

Refactor: pass translate through track expense updates (1 of 4) - #106922

Draft
MelvinBot wants to merge 1 commit into
mainfrom
claude-transactionTranslateTrackExpense
Draft

MelvinBot wants to merge 1 commit into
mainfrom
claude-transactionTranslateTrackExpense

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Part 1 of the approved four-PR translation refactor: inject the caller's translator into track-expense updates, including inline edits, amount submission and merges. This lets optimistic transaction labels use the caller's locale rather than implicit global translation state.

The shared transaction helper temporarily defaults to translateLocal for callers intentionally deferred to parts 2–4. Part 4 removes this compatibility default. No split/bulk caller migrations are included here.

AI Tests

  • Passed: typecheck, full lint, lint-changed, spell-changed, Storybook smoke, and 696 tests across six targeted suites.
  • Full Jest run exceeded the 200-second local execution window; no failures were reported before termination.
  • React Compiler changed-file command could not resolve its base (origin/) in this environment. The repository has no prettier script; formatting is handled by the lint pipeline.
  • Read-only coding-standards review: no violations or correctness findings.
  • Browser verification blocked by a blank dev app page; neither expense-edit nor distance-edit behavior was verified.

Blank app page preventing expense verification

Fixed Issues

$ #64943
PROPOSAL: #64943 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
@MelvinBot
MelvinBot requested review from a team and parasharrajat November 14, 2026 11:59
@melvin-bot melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Nov 14, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ Something went wrong. This may be a transient issue. Try again. If it persists, check status.openai.com.

Run details

@codecov

codecov Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/hooks/useTransactionInlineEdit.ts 100.00% <100.00%> (ø)
src/libs/IOUAmountSubmission.ts 86.77% <ø> (ø)
src/libs/TransactionUtils/getUpdatedTransaction.ts 96.92% <100.00%> (+0.01%) ⬆️
src/libs/actions/IOU/UpdateMoneyRequest.ts 92.19% <ø> (+0.20%) ⬆️
src/libs/actions/MergeTransaction.ts 90.38% <ø> (ø)
src/libs/actions/TransactionInlineEdit.ts 96.73% <ø> (ø)
...pages/TransactionMerge/DynamicConfirmationPage.tsx 74.80% <100.00%> (+0.19%) ⬆️
.../request/step/DynamicIOURequestStepDescription.tsx 85.21% <100.00%> (+0.12%) ⬆️
...iou/request/step/DynamicIOURequestStepDistance.tsx 90.19% <100.00%> (+0.02%) ⬆️
...quest/step/DynamicIOURequestStepDistanceManual.tsx 78.33% <ø> (ø)
... and 4 more
... and 5 files with indirect coverage changes

@MelvinBot

MelvinBot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Android test steps verification results: ⚠️ partial

Exploratory amount editing succeeded on standalone Android NewDot. Console-error verification was blocked by log-access restrictions, and repeatable Tests/QA steps are missing.
Personal expense displaying the saved amount of $15.67; console cleanliness and locale behavior remain unverified

Step Status
No JS console errors during track-expense editingBlocked—not a confirmed product failure. Console logs could not be read, so console cleanliness remains unverified.
Personal expense displaying the saved amount of $15.67; console cleanliness and locale behavior remain unverified
❌
Repeatable Tests/QA documentationDocumentation blocker: Tests/QA sections remain TODO, with no repeatable steps or expected translation outcomes. Screenshot shows execution context only.
Personal expense displaying the saved amount of $15.67; console cleanliness and locale behavior remain unverified
❌
Exploratory: personal expense amount edit and submissionCreated a $12.34 expense, edited Amount to $15.67, and saved. Read-back confirmed $15.67 in both the title and Amount row. Locale translations, inline edits, merges, and distance edits remain unverified.
Personal expense displaying the saved amount of $15.67; console cleanliness and locale behavior remain unverified
✅

view run · view recording

@MelvinBot

MelvinBot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ⚠️ partial

Exploratory tracked-expense amount editing succeeded on Web, but the documented console-error assertion remains unverified because console logs were unavailable. Tests/QA remain TODO without repeatable functional steps; distance editing and locale behavior were not verified.
Expense updated from $12.34 to $23.45; console status unavailable

Step Status
No JS console errors during track-expense editing (combined Tests/QA assertion)Blocked—not an observed application failure. Console logs were unavailable; the screenshot documents the exercised screen, not console cleanliness.
Expense updated from $12.34 to $23.45; console status unavailable
❌
Exploratory tracked-expense amount editCreated a $12.34 personal expense and changed its amount to $23.45. Read-back confirmed the updated amount and activity recording both values. This was exploratory, not documented QA or proof of locale behavior.
Expense updated from $12.34 to $23.45; console status unavailable
✅

view run · view recording

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant