Repository navigation
Conversation
Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
🤖 Android test steps verification results: Verified category and tag edits on a submitted expense in standalone Android NewDot, with screenshots. Tax, distance/language, and JavaScript-error checks remain incomplete; the exact PR revision and recording availability could not be confirmed.
|
|
🤖 Web test steps verification results: Category, tag, and tax edits passed on dev NewDot web; a submitted distance expense was also edited in Spanish, but transient optimistic labels were not observed. The tested revision remains unconfirmed, and JavaScript-console inspection was unavailable.
|






Explanation of Change
Part 2 of the approved four-PR refactor. Thread the caller's
translateintogetUpdateMoneyRequestParamsand thengetUpdatedTransaction, so optimistic reported-expense labels use the caller's translator instead of silently falling back to global translation state.translateoptional on the builder only for the existing-split caller deferred to part 4. Split drafts, existing-split updates, BulkEdit, and removal of the shared fallback are intentionally excluded.Dependency: stacked on Pass translate through track expense updates (1 of 4). Merge that PR first, then retarget this PR to
main.Review:
parasharrajatrequested as reviewer, not assignee. The environment's commit hook automatically adds requester co-authorship; that attribution limitation also applies here.AI Tests
prettiernpm script.origin/.Fixed Issues
$ #64943
PROPOSAL: #64943 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari