Skip to content

Refactor: pass translate through money request updates (2 of 4) - #106923

Draft
MelvinBot wants to merge 1 commit into
claude-transactionTranslateTrackExpensefrom
claude-transactionTranslateMoneyRequest-parasharrajat
Draft

MelvinBot wants to merge 1 commit into
claude-transactionTranslateTrackExpensefrom
claude-transactionTranslateMoneyRequest-parasharrajat

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Part 2 of the approved four-PR refactor. Thread the caller's translate into getUpdateMoneyRequestParams and then getUpdatedTransaction, so optimistic reported-expense labels use the caller's translator instead of silently falling back to global translation state.

  • Forward translation through all thirteen reported-expense edit actions and the reported-expense merge branch.
  • Pass the hook translator from category/tag/tax hooks, money-request controls, and attendees/tax-amount pages. Inline edits use the shared translator parameters introduced in part 1.
  • Add a real-action regression asserting the injected pending-route label reaches optimistic Onyx data, and strengthen hook/inline forwarding assertions.
  • Keep translate optional on the builder only for the existing-split caller deferred to part 4. Split drafts, existing-split updates, BulkEdit, and removal of the shared fallback are intentionally excluded.

Dependency: stacked on Pass translate through track expense updates (1 of 4). Merge that PR first, then retarget this PR to main.

Review: parasharrajat requested as reviewer, not assignee. The environment's commit hook automatically adds requester co-authorship; that attribution limitation also applies here.

AI Tests

  • Passed: 167 tests across eight targeted Jest suites (money-request actions/builders, distance messages, merge, inline edits, category/tag/tax hooks).
  • Passed: typecheck, lint, lint-changed, spell-changed, and Storybook smoke. Oxfmt ran successfully in the commit hook; the repository no longer has a prettier npm script.
  • Passed: explicit React Compiler checks for all six changed hooks/components/pages. The changed-file command is blocked because its base resolves to origin/.
  • Read-only coding-standards and correctness review returned no findings.
  • Full Jest run exceeded the 600-second execution window; no failing suites were reported before termination. This is not a full-suite pass.
  • Web verification blocked: dev NewDot rendered a blank page with zero snapshot nodes, so reported-expense edits and distance/language behavior were not verified. This is not a confirmed PR regression.

Blank app page blocking expense verification

Fixed Issues

$ #64943
PROPOSAL: #64943 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
@melvin-bot melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Nov 14, 2026
@MelvinBot
MelvinBot requested review from a team and parasharrajat November 14, 2026 12:26
@codecov

codecov Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...c/components/ReportActionItem/MoneyRequestView.tsx 79.80% <ø> (ø)
src/hooks/useUpdateTransactionCategory.ts 100.00% <100.00%> (ø)
src/hooks/useUpdateTransactionTag.ts 100.00% <100.00%> (ø)
src/hooks/useUpdateTransactionTaxRate.ts 100.00% <100.00%> (ø)
src/libs/actions/IOU/UpdateMoneyRequest.ts 91.99% <ø> (-0.21%) ⬇️
src/libs/actions/MergeTransaction.ts 90.38% <ø> (ø)
...equest/step/DynamicIOURequestStepTaxAmountPage.tsx 0.00% <ø> (ø)
...ou/request/step/DynamicIOURequestStepAttendees.tsx 0.00% <0.00%> (ø)
... and 4 files with indirect coverage changes

@MelvinBot

MelvinBot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Android test steps verification results: ⚠️ partial

Verified category and tag edits on a submitted expense in standalone Android NewDot, with screenshots. Tax, distance/language, and JavaScript-error checks remain incomplete; the exact PR revision and recording availability could not be confirmed.

Submitted expense showing saved tag QA Project

Step Status
Edit a reported expense’s categoryChanged Advertising to Car; the submitted expense displayed Car afterward.
Submitted expense showing category Car and tag QA Project
✅
Edit a reported expense’s tagSelected QA Project; the submitted expense displayed that tag afterward.
Submitted expense showing saved tag QA Project
✅
Edit a reported expense’s taxNot completed before the tester reached its execution limit. Not a confirmed product failure.
❌
Verify distance-expense labels after changing languageNot executed; optimistic translated labels remain unverified.
❌
Verify no JavaScript errorsUnverified: log access was restricted, and the requested flows were incomplete.
❌

view run · view recording

@MelvinBot

MelvinBot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ⚠️ partial

Category, tag, and tax edits passed on dev NewDot web; a submitted distance expense was also edited in Spanish, but transient optimistic labels were not observed. The tested revision remains unconfirmed, and JavaScript-console inspection was unavailable.

Saved submitted distance expense in Spanish; not evidence of transient labels

Step Status
Edit reported-expense categoryChanged Professional Services to Travel; Travel persisted after reopening.
Reopened submitted expense with saved Travel category
✅
Edit reported-expense tagSelected QA Translation; the tag persisted after reopening.
Reopened expense with saved QA Translation tag
✅
Edit reported-expense taxChanged Tax exempt to Tax Rate 1 (5%); the rate and $1.14 tax amount persisted after reopening.
Saved 5% tax rate and .14 tax amount
✅
Verify optimistic distance labels use the selected languageSelected Español and changed the submitted route to San Francisco–Berkeley. Saved details displayed “Distancia, 13.59 millas” and 10,33 US$, but transient optimistic merchant labels remain unverified—not a confirmed defect.
Saved submitted distance expense in Spanish; not evidence of transient labels
❌
Verify no JavaScript-console errorsUnverified: console inspection was unavailable through the permitted testing interface.
❌

view run · view recording

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant